search for: get_panic_act

...Component: core Assignee: wayned at samba.org Reporter: brant at gurganus.name QA Contact: rsync-qa at samba.org The rsync_panic_handler currently defined at line 1490 of main.c writes into a fixed size cmd_buf at line 1492 a non-controlled value returned ultimately in get_panic_action() using snprintf at line 1495. The combined values destined for cmd_buf by way of snprintf may be greater than the 300 character buffer. This is not checked. Consequently, a command may attempt to execute that was not intended. To address this specific issue, if the snprintf function returns a...

...addrinfo.h" @@ -4777,9 +4777,18 @@ +#endif /* SUPPORT_ACLS */ +#include "smb_acls.h" + ++#define UNUSED(x) x __attribute__((__unused__)) ++ #include "proto.h" /* We have replacement versions of these if they're missing. */ +@@ -861,6 +901,4 @@ + const char *get_panic_action(void); + #endif + +-#define UNUSED(x) x __attribute__((__unused__)) +- + extern const char *io_write_phase, *io_read_phase; --- orig/rsync.yo 2005-05-22 20:53:34 +++ rsync.yo 2004-07-03 20:11:58 @@ -317,6 +317,7 @@ to the detailed description below for a -- Configure bugmail: https://bugzi...

...dif /* log the transfer */ if (log_before_transfer) log_item(FCLIENT, file, iflags, NULL); diff --git a/rsync.h b/rsync.h index 731f4fe..b293edc 100644 --- a/rsync.h +++ b/rsync.h @@ -1241,3 +1241,7 @@ int inet_pton(int af, const char *src, void *dst); #ifdef MAINTAINER_MODE const char *get_panic_action(void); #endif + +#ifdef HAVE_FALLOCATE +#include <linux/falloc.h> +#endif diff --git a/syscall.c b/syscall.c index aba0009..854010e 100644 --- a/syscall.c +++ b/syscall.c @@ -189,6 +189,15 @@ int do_open(const char *pathname, int flags, mode_t mode) return open(pathname, flags | O_BINAR...

...sappend, %sACLs, %sxattrs, %siconv\n", - have_inplace, acls, xattrs, iconv); + rprintf(f, " %sappend, %sACLs, %sxattrs, %siconv, %sfile-flags\n", + have_inplace, acls, xattrs, iconv, fileflags); #ifdef MAINTAINER_MODE rprintf(f, "Panic Action: \"%s\"\n", get_panic_action()); @@ -333,6 +338,7 @@ void usage(enum logcode F) rprintf(F," -K, --keep-dirlinks treat symlinked dir on receiver as dir\n"); rprintf(F," -H, --hard-links preserve hard links\n"); rprintf(F," -p, --perms preserve permissions\n...

...; #endif -#define SUPPORT_LINKS HAVE_READLINK -#define SUPPORT_HARD_LINKS HAVE_LINK - /* This could be bad on systems which have no lchown and where chown * follows symbollic links. On such systems it might be better not to * try to chown symlinks at all. */ @@ -629,3 +636,8 @@ const char *get_panic_action(void); #define UNUSED(x) x __attribute__((__unused__)) extern const char *io_write_phase, *io_read_phase; + + + +/* Global command-line options */ +extern int opt_xattr; diff -urpdN -x .ignore -x packaging -x cvs.log -x configure -x config.h.in -x autom4te.cache -x config.log -x .cvsignore -...

...m inums, %d-bit internal inums,\n", ipv6, (int) (sizeof(dumstat->st_ino) * 8), (int) (sizeof(INO64_T) * 8)); + rprintf(f, " HFS+ (Mac OS X) resource forks\n"); #ifdef MAINTAINER_MODE rprintf(f, " panic action: \"%s\"\n", get_panic_action()); @@ -277,6 +279,7 @@ rprintf(F," --stats give some file transfer stats\n"); rprintf(F," --progress show progress during transfer\n"); rprintf(F," --log-format=FORMAT log file transfers using specified format\n&quot...

I've read up some more on the subject, and it seems the proper way to do this with GCC is g++ and target attributes. I've refactored the patch that way, and it indeed uses SSSE3 automatically on supporting CPUs, regardless of the build host, so this should be ideal both for home builders and distros. Getting the code to build right in c++ mode (checksum_sse2.cpp only) was a bit of an