search for: get_multistream_decod

...p" in mapping_matrix_multiply_short, and even in the > MATRIX_INDEX macro, multiplication may overflow if int is 16 bits. > One of the operands of the multiplication should be cast to opus_int32 > in such cases to ensure a 32-bit multiply and avoid overflow. > > Done. > 4) get_multistream_decoder: align() must be applied separately to > sizeof(OpusProjectionDecoder) and st->demixing_matrix_size_in_bytes > since they may each have padding. Including the alignment padding in > demixing_matrix_size_in_bytes as in (5) avoids the second call to > align(). Similarly in opus_pro...

...ould be obtained from >> mapping_matrix_get_size() and the field should be opus_int32. >> > This value is only meant to represent the "data" portion of the > mappingmatrix struct. Note that we include the struct size when computing > the multistream decoder pointer in get_multistream_decoder(). > I will make it opus_int32 though. Where in get_multistream_decoder() does it include the size of struct MappingMatrix? It only includes sizeof(OpusProjectionDecoder) and st->demixing_matrix_size_in_bytes, neither of which includes the size of struct MappingMatrix. And if you're...

...ltiply_short, and even in the > MATRIX_INDEX macro, multiplication may overflow if int is 16 bits. > One of the operands of the multiplication should be cast to opus_int32 > in such cases to ensure a 32-bit multiply and avoid overflow. > > Done. >   > >  4) get_multistream_decoder: align() must be applied separately to > sizeof(OpusProjectionDecoder) and st->demixing_matrix_size_in_bytes > since they may each have padding.  Including the alignment padding in > demixing_matrix_size_in_bytes as in (5) avoids the second call to > align().  Simil...

...cation in the computation of "tmp" in mapping_matrix_multiply_short, and even in the MATRIX_INDEX macro, multiplication may overflow if int is 16 bits. One of the operands of the multiplication should be cast to opus_int32 in such cases to ensure a 32-bit multiply and avoid overflow. 4) get_multistream_decoder: align() must be applied separately to sizeof(OpusProjectionDecoder) and st->demixing_matrix_size_in_bytes since they may each have padding. Including the alignment padding in demixing_matrix_size_in_bytes as in (5) avoids the second call to align(). Similarly in opus_projection_decoder_get_...

On 11/09/2017 01:58 PM, Drew Allen wrote: > Attached is a quick patch that addresses a bug when exporting the matrix > from the encoder. Actually, I don't see what your encoder change is supposed to do. Are there cases where demixing_matrix->rows != nb_output_streams ? Cheers, Jean-Marc > Cheers, > Drew > > On Wed, Nov 8, 2017 at 4:44 PM Drew Allen <bitllama at