search for: get_mod

Hello, This patch series aims at replacing all dummy ->best_encoder() implementations where we have a 1:1 relationship between encoders and connectors. The core already provides the drm_atomic_helper_best_encoder() function which is taking the first encoder attached to the connector (after making sure only one encoder was attached to the connector), but it's not automatically used, and

Hello, This patch series aims at replacing all dummy ->best_encoder() implementations where we have a 1:1 relationship between encoders and connectors. The core already provides the drm_atomic_helper_best_encoder() function which is taking the first encoder attached to the connector (after making sure only one encoder was attached to the connector), but it's not automatically used, and

Hello, This patch series aims at replacing all dummy ->best_encoder() implementations where we have a 1:1 relationship between encoders and connectors. The core already provides the drm_atomic_helper_best_encoder() function which is taking the first encoder attached to the connector (after making sure only one encoder was attached to the connector), but it's not automatically used, and

Hello, This patch series aims at replacing all dummy ->best_encoder() implementations where we have a 1:1 relationship between encoders and connectors. The core already provides the drm_atomic_helper_best_encoder() function which is taking the first encoder attached to the connector (after making sure only one encoder was attached to the connector), but it's not automatically used, and

...00644 --- a/drivers/gpu/drm/i915/intel_crt.c +++ b/drivers/gpu/drm/i915/intel_crt.c @@ -753,7 +753,6 @@ static const struct drm_connector_funcs intel_crt_connector_funcs = { static const struct drm_connector_helper_funcs intel_crt_connector_helper_funcs = { .mode_valid = intel_crt_mode_valid, .get_modes = intel_crt_get_modes, - .best_encoder = intel_best_encoder, }; static const struct drm_encoder_funcs intel_crt_enc_funcs = { diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 2113f40..77026ce 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b...

Here is a preliminary fix for this bug. I'm running the test suite on this now. Rich.

...rm/i915/intel_crt.c > +++ b/drivers/gpu/drm/i915/intel_crt.c > @@ -753,7 +753,6 @@ static const struct drm_connector_funcs intel_crt_connector_funcs = { > static const struct drm_connector_helper_funcs intel_crt_connector_helper_funcs = { > .mode_valid = intel_crt_mode_valid, > .get_modes = intel_crt_get_modes, > - .best_encoder = intel_best_encoder, > }; > > static const struct drm_encoder_funcs intel_crt_enc_funcs = { > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 2113f40..77026ce 100644 > --- a/drivers...

...rm/i915/intel_crt.c > +++ b/drivers/gpu/drm/i915/intel_crt.c > @@ -753,7 +753,6 @@ static const struct drm_connector_funcs intel_crt_connector_funcs = { > static const struct drm_connector_helper_funcs intel_crt_connector_helper_funcs = { > .mode_valid = intel_crt_mode_valid, > .get_modes = intel_crt_get_modes, > - .best_encoder = intel_best_encoder, > }; > > static const struct drm_encoder_funcs intel_crt_enc_funcs = { > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 2113f40..77026ce 100644 > --- a/drivers...

...eedback on, I'm not sure if it's worth maybe just reworking how we do mode pruning in nouveau instead...) and start using this in our mst ->mode_valid callback to filter out impossible to set modes on MST connectors. Lyude Paul (2): drm/probe_helper: Add drm_connector_helper_funcs->get_modes_ctx() drm/nouveau/kms/nv50-: Check MST display modes against available PBN drivers/gpu/drm/drm_probe_helper.c | 11 +++++- drivers/gpu/drm/nouveau/dispnv50/disp.c | 41 ++++++++++++++------ drivers/gpu/drm/nouveau/nouveau_connector.c | 24 ++++++++++-- drivers/gpu/drm/nouveau/nou...

...100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_hdmicon.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_hdmicon.c > @@ -52,7 +52,6 @@ static int rcar_du_hdmi_connector_mode_valid(struct > drm_connector *connector, static const struct drm_connector_helper_funcs > connector_helper_funcs = { .get_modes = rcar_du_hdmi_connector_get_modes, > .mode_valid = rcar_du_hdmi_connector_mode_valid, > - .best_encoder = rcar_du_connector_best_encoder, > }; > > static enum drm_connector_status > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_lvdscon.c > b/drivers/gpu/drm/rcar-du/rcar_...

...100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_hdmicon.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_hdmicon.c > @@ -52,7 +52,6 @@ static int rcar_du_hdmi_connector_mode_valid(struct > drm_connector *connector, static const struct drm_connector_helper_funcs > connector_helper_funcs = { .get_modes = rcar_du_hdmi_connector_get_modes, > .mode_valid = rcar_du_hdmi_connector_mode_valid, > - .best_encoder = rcar_du_connector_best_encoder, > }; > > static enum drm_connector_status > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_lvdscon.c > b/drivers/gpu/drm/rcar-du/rcar_...

...ector *connector) -{ - struct sti_dvo_connector *dvo_connector - = to_sti_dvo_connector(connector); - - /* Best encoder is the one associated during connector creation */ - return dvo_connector->encoder; -} - static const struct drm_connector_helper_funcs sti_dvo_connector_helper_funcs = { .get_modes = sti_dvo_connector_get_modes, .mode_valid = sti_dvo_connector_mode_valid, - .best_encoder = sti_dvo_best_encoder, }; static enum drm_connector_status diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c index f7d3464..c4649f5 100644 --- a/drivers/gpu/drm/sti/sti_hda.c...

.../02_xapi-vbd_basic.py @@ -4,13 +4,14 @@ # Author: Stefan Berger <stefanb@us.ibm.com> # Tests related to SR, VDI, VBD +# Based on the ''C'' code. # # Used methods: # SR: get_by_name_label, get_VDIs # # VDI: create, get_name_label, destroy # -# VBD: create, get_driver, get_mode, get_VM, get_VDI, get_device +# VBD: create, get_driver, get_mode, get_VM, get_VDI, get_device, get_type # # VM: get_VBDs @@ -43,15 +44,17 @@ vdi_rec = { ''name_label'' : "My disk", ''sector_size'' : 512, ''type'...

...onst struct drm_connector_funcs edp_connector_funcs = { .dpms = drm_atomic_helper_connector_dpms, .detect = edp_connector_detect, @@ -113,7 +104,6 @@ static const struct drm_connector_funcs edp_connector_funcs = { static const struct drm_connector_helper_funcs edp_connector_helper_funcs = { .get_modes = edp_connector_get_modes, .mode_valid = edp_connector_mode_valid, - .best_encoder = edp_connector_best_encoder, }; /* initialize connector */ diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c index b15d726..a2515b4 100644 --- a/drivers/gpu/d...

...index 6c92714..612b4d5 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_hdmicon.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_hdmicon.c @@ -52,7 +52,6 @@ static int rcar_du_hdmi_connector_mode_valid(struct drm_connector *connector, static const struct drm_connector_helper_funcs connector_helper_funcs = { .get_modes = rcar_du_hdmi_connector_get_modes, .mode_valid = rcar_du_hdmi_connector_mode_valid, - .best_encoder = rcar_du_connector_best_encoder, }; static enum drm_connector_status diff --git a/drivers/gpu/drm/rcar-du/rcar_du_lvdscon.c b/drivers/gpu/drm/rcar-du/rcar_du_lvdscon.c index e905f5d..6afd0a...

...@ -39,36 +39,6 @@ do_exists (const char *path) /* Takes optional arguments, consult optargs_bitmask. */ int -do_is_file (const char *path, int followsymlinks) -{ - mode_t mode; - int r; - - if (!(optargs_bitmask & GUESTFS_IS_FILE_FOLLOWSYMLINKS_BITMASK)) - followsymlinks = 0; - - r = get_mode (path, &mode, followsymlinks); - if (r <= 0) return r; - return S_ISREG (mode); -} - -/* Takes optional arguments, consult optargs_bitmask. */ -int -do_is_dir (const char *path, int followsymlinks) -{ - mode_t mode; - int r; - - if (!(optargs_bitmask & GUESTFS_IS_DIR_FOLLOWSYMLINKS...

...ate *new_cstate) +{ + struct amdgpu_dm_connector *aconnector = + to_amdgpu_dm_connector(connector); + + return drm_dp_mst_connector_atomic_check(connector, new_cstate, + &aconnector->mst_mgr); +} + static const struct drm_connector_helper_funcs dm_dp_mst_connector_helper_funcs = { .get_modes = dm_dp_mst_get_modes, .mode_valid = amdgpu_dm_connector_mode_valid, .best_encoder = dm_mst_best_encoder, + .atomic_check = amdgpu_dm_mst_connector_atomic_check, }; static void amdgpu_dm_encoder_destroy(struct drm_encoder *encoder) -- 2.17.1

...18 ------------------ 1 file changed, 18 deletions(-) diff --git a/drivers/gpu/drm/arc/arcpgu_hdmi.c b/drivers/gpu/drm/arc/arcpgu_hdmi.c index 08b6bae..b7a8b2a 100644 --- a/drivers/gpu/drm/arc/arcpgu_hdmi.c +++ b/drivers/gpu/drm/arc/arcpgu_hdmi.c @@ -46,23 +46,6 @@ static int arcpgu_drm_connector_get_modes(struct drm_connector *connector) return sfuncs->get_modes(&slave->base, connector); } -struct drm_encoder * -arcpgu_drm_connector_best_encoder(struct drm_connector *connector) -{ - struct drm_encoder_slave *slave; - struct arcpgu_drm_connector *con = - container_of(connector, stru...

...rn mode_status; } -static struct drm_encoder *dw_mipi_dsi_connector_best_encoder( - struct drm_connector *connector) -{ - struct dw_mipi_dsi *dsi = con_to_dsi(connector); - - return &dsi->encoder; -} - static struct drm_connector_helper_funcs dw_mipi_dsi_connector_helper_funcs = { .get_modes = dw_mipi_dsi_connector_get_modes, .mode_valid = dw_mipi_dsi_mode_valid, - .best_encoder = dw_mipi_dsi_connector_best_encoder, }; static enum drm_connector_status diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index f8b4feb..006260d 100644 --- a/dri...

On Wed, 26 Jun 2024, Ma Ke <make24 at iscas.ac.cn> wrote: > In nouveau_connector_get_modes(), the return value of drm_mode_duplicate() > is assigned to mode, which will lead to a possible NULL pointer > dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. > > Signed-off-by: Ma Ke <make24 at iscas.ac.cn> > --- > drivers/gpu/drm/nouveau/nouve...