search for: get_legacy_featur

...gt; > > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> > > > > So now we have both get_features and get_features_rev, and > > it's never clear which revision does host_features refer to. > > IMHO that's just too messy. > > Let's add get_legacy_features and host_legacy_features instead? > > I wanted to avoid touching anything that does not support version 1. > And this interface might still work for later revisions, no? We can add _modern_ then, or rename host_features to host_legacy_features everywhere as preparation. -- MST

...gt; > > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> > > > > So now we have both get_features and get_features_rev, and > > it's never clear which revision does host_features refer to. > > IMHO that's just too messy. > > Let's add get_legacy_features and host_legacy_features instead? > > I wanted to avoid touching anything that does not support version 1. > And this interface might still work for later revisions, no? We can add _modern_ then, or rename host_features to host_legacy_features everywhere as preparation. -- MST

...ts features when the revision has been > changed. > > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> So now we have both get_features and get_features_rev, and it's never clear which revision does host_features refer to. IMHO that's just too messy. Let's add get_legacy_features and host_legacy_features instead? > --- > hw/s390x/virtio-ccw.c | 12 ++++++++++-- > hw/virtio/virtio-bus.c | 14 ++++++++++++-- > include/hw/virtio/virtio-bus.h | 3 +++ > include/hw/virtio/virtio.h | 3 +++ > 4 files changed, 28 insertions(+),...

...ts features when the revision has been > changed. > > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> So now we have both get_features and get_features_rev, and it's never clear which revision does host_features refer to. IMHO that's just too messy. Let's add get_legacy_features and host_legacy_features instead? > --- > hw/s390x/virtio-ccw.c | 12 ++++++++++-- > hw/virtio/virtio-bus.c | 14 ++++++++++++-- > include/hw/virtio/virtio-bus.h | 3 +++ > include/hw/virtio/virtio.h | 3 +++ > 4 files changed, 28 insertions(+),...

...nelia.huck at de.ibm.com> > > > > > > > > So now we have both get_features and get_features_rev, and > > > > it's never clear which revision does host_features refer to. > > > > IMHO that's just too messy. > > > > Let's add get_legacy_features and host_legacy_features instead? > > > > > > I wanted to avoid touching anything that does not support version 1. > > > And this interface might still work for later revisions, no? > > > > We can add _modern_ then, or rename host_features to host_legacy_f...

...nelia.huck at de.ibm.com> > > > > > > > > So now we have both get_features and get_features_rev, and > > > > it's never clear which revision does host_features refer to. > > > > IMHO that's just too messy. > > > > Let's add get_legacy_features and host_legacy_features instead? > > > > > > I wanted to avoid touching anything that does not support version 1. > > > And this interface might still work for later revisions, no? > > > > We can add _modern_ then, or rename host_features to host_legacy_f...

...gt; > changed. > > > > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> > > So now we have both get_features and get_features_rev, and > it's never clear which revision does host_features refer to. > IMHO that's just too messy. > Let's add get_legacy_features and host_legacy_features instead? I wanted to avoid touching anything that does not support version 1. And this interface might still work for later revisions, no?

...by: Cornelia Huck <cornelia.huck at de.ibm.com> > > > > > > So now we have both get_features and get_features_rev, and > > > it's never clear which revision does host_features refer to. > > > IMHO that's just too messy. > > > Let's add get_legacy_features and host_legacy_features instead? > > > > I wanted to avoid touching anything that does not support version 1. > > And this interface might still work for later revisions, no? > > We can add _modern_ then, or rename host_features to host_legacy_features > everywhere a...

...gt; > changed. > > > > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> > > So now we have both get_features and get_features_rev, and > it's never clear which revision does host_features refer to. > IMHO that's just too messy. > Let's add get_legacy_features and host_legacy_features instead? I wanted to avoid touching anything that does not support version 1. And this interface might still work for later revisions, no?

...by: Cornelia Huck <cornelia.huck at de.ibm.com> > > > > > > So now we have both get_features and get_features_rev, and > > > it's never clear which revision does host_features refer to. > > > IMHO that's just too messy. > > > Let's add get_legacy_features and host_legacy_features instead? > > > > I wanted to avoid touching anything that does not support version 1. > > And this interface might still work for later revisions, no? > > We can add _modern_ then, or rename host_features to host_legacy_features > everywhere a...

And yet another iteration of virtio-1 support in qemu, tested with the latest virtio kernel patches. Find it at git://github.com/cohuck/qemu virtio-1 Changes from v5: - fixed stupid bug in "virtio: support more feature bits": we need to define a proper prop backend for 64 bit wide handling... - don't negotiate revision 1 unless VERSION_1 is offered - use 64 bit wide features

And yet another iteration of virtio-1 support in qemu, tested with the latest virtio kernel patches. Find it at git://github.com/cohuck/qemu virtio-1 Changes from v5: - fixed stupid bug in "virtio: support more feature bits": we need to define a proper prop backend for 64 bit wide handling... - don't negotiate revision 1 unless VERSION_1 is offered - use 64 bit wide features