search for: get_cmdline_key

These are a prelude to fixing https://bugzilla.redhat.com/show_bug.cgi?id=1590220 A lot of the virt-p2v configuration code was duplicated manually. These changes make sure that most of it is generated. Rich.

...onfig($fh, $lprefix, $lv, $field->elements); + } else { + my $key = $prefix . '.' . $field->name; + + if (not (any { $_ eq $key } @cmdline_ignore)) { + # Is there an alias for this field? + my $alias = find_alias($key); + + printf $fh " if ((p = get_cmdline_key (cmdline, \"%s\")) != NULL", $key; + if (defined($alias)) { + print $fh " ||\n"; + printf $fh " (p = get_cmdline_key (cmdline, \"%s\")) != NULL", $alias; + } + print $fh ") {\n"; + + # Parse th...

As preliminary steps in splitting virt-p2v to an own repository, start making p2v more independent within libguestfs. This is accomplished by the following changes: - generate the p2v kernel config sources & docs at build time using a Perl script, rather than the generator (so no need for OCaml when building from git, and no generated sources in dist tarballs) - create two local test

A mixed bag, but all the patches make sense together! Patch 1: Fix a bug that Tingting found: https://bugzilla.redhat.com/show_bug.cgi?id=1256222 Patch 2: Revert a patch that makes no sense now that we've added virt-v2v into base RHEL. This is just included because it's a cleanup needed before applying patch 3. Patch 3: Add the ability to use SSH identities (private keys) for virt-p2v

Fixes https://bugzilla.redhat.com/1256222

...LURE, err, "pthread_create"); pthread_attr_destroy (&attr); } diff --git a/p2v/kernel.c b/p2v/kernel.c index 61fbecd..fb52785 100644 --- a/p2v/kernel.c +++ b/p2v/kernel.c @@ -54,11 +54,9 @@ kernel_configuration (struct config *config, char **cmdline, int cmdline_source) p = get_cmdline_key (cmdline, "p2v.port"); if (p) { - if (sscanf (p, "%d", &config->port) != 1) { - fprintf (stderr, "%s: cannot parse p2v.port from kernel command line", - guestfs_int_program_name); - exit (EXIT_FAILURE); - } + if (sscanf (p, &q...

In an effort to reduce the code, start to use few bits of GLib: - replace the gnulib c-type module - replace the gnulib getprogname module - use g_spawn_sync to launch curl, and drop a file reading function Pino Toscano (6): Include glib.h in p2v.h Use g_ascii_isspace instead of c_isspace from gnulib Use g_get_prgname instead of getprogname from gnulib build: remove no more used gnulib

Wherever we had code which did: if (something_bad) { perror (...); exit (EXIT_FAILURE); } replace this with use of the error(3) function: if (something_bad) error (EXIT_FAILURE, errno, ...); The error(3) function is supplied by glibc, or by gnulib on platforms which don't have it, and is much more flexible than perror(3). Since we already use error(3), there seems to be

Hi, this series update libguestfs to a recent gnulib version, so that we can use its new getprogname module, and solve altogether one of the porting issues (the need for 'program_name' by the error module of gnulib), and have a single way to get the name of the current program. A number of changes in tools mostly, although mechanical. Thanks, Pino Toscano (3): Update gnulib to latest

Now that virt-p2v has its own repository [1] and releases [2], it is time to remove it from libguestfs. [1] https://github.com/libguestfs/virt-p2v [2] http://download.libguestfs.org/virt-p2v/ Pino Toscano (2): Remove virt-p2v Remove remaining virt-p2v bits .gitignore | 4 - Makefile.am | 7 +- bash/Makefile.am