search for: genpool

...tic int io_subchannel_probe(struct subchannel *sch) > if (!io_priv) > goto out_schedule; > > + io_priv->dma_area = dma_alloc_coherent(&sch->dev, > + sizeof(*io_priv->dma_area), > + &io_priv->dma_area_dma, GFP_KERNEL); This needs GFP_DMA. You use a genpool for ccw_private->dma and not for iopriv->dma - looks kinda inconsistent.

...tic int io_subchannel_probe(struct subchannel *sch) > if (!io_priv) > goto out_schedule; > > + io_priv->dma_area = dma_alloc_coherent(&sch->dev, > + sizeof(*io_priv->dma_area), > + &io_priv->dma_area_dma, GFP_KERNEL); This needs GFP_DMA. You use a genpool for ccw_private->dma and not for iopriv->dma - looks kinda inconsistent.

...* @tx_tr: transmit tail room + * @rx_tr: receive tail room + * @mtu: transmit max size + * @mru: receive max size + * @allocsz: size of dma memory reserved for TX buffers + * @alloc_addr: virtual address to dma memory for TX buffers + * @alloc_dma: dma address to dma memory for TX buffers + * @genpool: Gen Pool used for allocating TX buffers + * @reserved_mem: Pointer to memory reserve allocated from genpool + * @reserved_size: Size of memory reserve allocated from genpool + * @stats: Statistics exposed in sysfs + * @debugfs: Debugfs dentry for statistic counters + */ +struct cfv_inf...

...* @tx_tr: transmit tail room + * @rx_tr: receive tail room + * @mtu: transmit max size + * @mru: receive max size + * @allocsz: size of dma memory reserved for TX buffers + * @alloc_addr: virtual address to dma memory for TX buffers + * @alloc_dma: dma address to dma memory for TX buffers + * @genpool: Gen Pool used for allocating TX buffers + * @reserved_mem: Pointer to memory reserve allocated from genpool + * @reserved_size: Size of memory reserve allocated from genpool + * @stats: Statistics exposed in sysfs + * @debugfs: Debugfs dentry for statistic counters + */ +struct cfv_inf...

...hedule; > > > > + io_priv->dma_area = dma_alloc_coherent(&sch->dev, > > + sizeof(*io_priv->dma_area), > > + &io_priv->dma_area_dma, GFP_KERNEL); > > This needs GFP_DMA. Christoph already answered this one. Thanks Christoph! > You use a genpool for ccw_private->dma and not for iopriv->dma - looks > kinda inconsistent. > Please have a look at patch #9. A virtio-ccw device uses the genpool of it's ccw device (the pool from which ccw_private->dma is allicated) for the ccw stuff it needs to do. AFAICT for a subchannel dev...

...t; cio" despite the small changes pointed out below. Please do complain if > > it ain't OK for you! > > > > Change log > > ========== > > > > v4 --> v5: > > * work around dma_pool API not tolerating NULL dma pool (patch 4) > > * make the genpool based dma pools API tolerate NULL genpool (patch 2) > > * fix typo (patch 2) > > * fix unintended code move (patch 7) > > * add more r-b's > > > > > > > > v3 --> v4 > > * fixed cleanup in css_bus_init() (Connie) > > * made cio.h inclu...

...quot;s390/cio: introduce DMA pools to > cio" despite the small changes pointed out below. Please do complain if > it ain't OK for you! > > Change log > ========== > > v4 --> v5: > * work around dma_pool API not tolerating NULL dma pool (patch 4) > * make the genpool based dma pools API tolerate NULL genpool (patch 2) > * fix typo (patch 2) > * fix unintended code move (patch 7) > * add more r-b's > > > > v3 --> v4 > * fixed cleanup in css_bus_init() (Connie) > * made cio.h include genalloc.h instead of a forward declaratio...

...gt; > + size_t chunk_size; > > > > if (!addr) { > > + chunk_size = round_up(size, PAGE_SIZE); > > Doesn't that mean that we still go up to chunks of at least PAGE_SIZE? > Or can vectors now share the same chunk? Exactly! We put the allocated dma mem into the genpool. So if the next request can be served from what is already in the genpool we don't end up in this fallback path where we grow the pool. > > > addr = (unsigned long) dma_alloc_coherent(dma_dev, > > - PAGE_SIZE, &dma_addr, CIO_DMA_GFP); > > + chunk_size, &a...

On Sun, 12 May 2019 20:22:56 +0200 Halil Pasic <pasic at linux.ibm.com> wrote: > On Fri, 10 May 2019 16:10:13 +0200 > Cornelia Huck <cohuck at redhat.com> wrote: > > > On Fri, 10 May 2019 00:11:12 +0200 > > Halil Pasic <pasic at linux.ibm.com> wrote: > > > > > On Thu, 9 May 2019 12:11:06 +0200 > > > Cornelia Huck <cohuck at

On Sun, 12 May 2019 20:22:56 +0200 Halil Pasic <pasic at linux.ibm.com> wrote: > On Fri, 10 May 2019 16:10:13 +0200 > Cornelia Huck <cohuck at redhat.com> wrote: > > > On Fri, 10 May 2019 00:11:12 +0200 > > Halil Pasic <pasic at linux.ibm.com> wrote: > > > > > On Thu, 9 May 2019 12:11:06 +0200 > > > Cornelia Huck <cohuck at

...I). @Sebastian: I kept your r-b on patch 2 "s390/cio: introduce DMA pools to cio" despite the small changes pointed out below. Please do complain if it ain't OK for you! Change log ========== v4 --> v5: * work around dma_pool API not tolerating NULL dma pool (patch 4) * make the genpool based dma pools API tolerate NULL genpool (patch 2) * fix typo (patch 2) * fix unintended code move (patch 7) * add more r-b's v3 --> v4 * fixed cleanup in css_bus_init() (Connie) * made cio.h include genalloc.h instead of a forward declaration (Connie) * added comments about dma_mask/...

...I). @Sebastian: I kept your r-b on patch 2 "s390/cio: introduce DMA pools to cio" despite the small changes pointed out below. Please do complain if it ain't OK for you! Change log ========== v4 --> v5: * work around dma_pool API not tolerating NULL dma pool (patch 4) * make the genpool based dma pools API tolerate NULL genpool (patch 2) * fix typo (patch 2) * fix unintended code move (patch 7) * add more r-b's v3 --> v4 * fixed cleanup in css_bus_init() (Connie) * made cio.h include genalloc.h instead of a forward declaration (Connie) * added comments about dma_mask/...

Enhanced virtualization protection technology may require the use of bounce buffers for I/O. While support for this was built into the virtio core, virtio-ccw wasn't changed accordingly. Some background on technology (not part of this series) and the terminology used. * Protected Virtualization (PV): Protected Virtualization guarantees, that non-shared memory of a guest that operates in PV

Enhanced virtualization protection technology may require the use of bounce buffers for I/O. While support for this was built into the virtio core, virtio-ccw wasn't changed accordingly. Some background on technology (not part of this series) and the terminology used. * Protected Virtualization (PV): Protected Virtualization guarantees, that non-shared memory of a guest that operates in PV