search for: genhd

In add_disk(), don't send uevent to userspace when gen_uevent is true; also export the refactored function disk_gen_uevents for later use. Signed-off-by: Fam Zheng <famz at redhat.com> --- block/genhd.c | 23 +++++++++++++++++++---- include/linux/genhd.h | 1 + 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/block/genhd.c b/block/genhd.c index 8e1bfa1..9b66953 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -506,12 +506,10 @@ static int exact_lock(dev_t devt, void *dat...

...n device_add_disk that can fail, and even more to come as we extend it. Switch the return type of the function, and return the error code when error happens. The WARN_ON is kept because callers are not updated to check the error yet. Signed-off-by: Fam Zheng <famz at redhat.com> --- block/genhd.c | 49 ++++++++++++++++++++++++++++++++++--------------- include/linux/genhd.h | 2 +- 2 files changed, 35 insertions(+), 16 deletions(-) diff --git a/block/genhd.c b/block/genhd.c index 4316d2d..ffb3929 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -595,9 +595,10 @@ exit: * This f...

...lers. So this adds a new helper to just propagate the size, and cleans up all kinds of mess around this area. Follow on patches will eventuall kill of ->revalidate_disk entirely, but ther are a lot more patches needed for that. Diffstat: Documentation/filesystems/locking.rst | 3 -- block/genhd.c | 9 ++---- drivers/block/nbd.c | 8 ++--- drivers/block/rbd.c | 2 - drivers/block/rnbd/rnbd-clt.c | 10 +------ drivers/block/virtio_blk.c | 2 - drivers/block/zram/zram_drv.c | 4 +- drivers...

...lar help functions. Ren Mingxin (4): block: add function disk_name_format() into block core scsi: replace sd_format_disk_name() to disk_name_format() block: replace rssd_disk_name_format() to disk_name_format() virtio_blk: use disk_name_format() to support mass of disks naming block/genhd.c | 49 ++++++++++++++++++++++++++++++++++++++ drivers/block/mtip32xx/mtip32xx.c | 33 ------------------------- drivers/block/virtio_blk.c | 13 ---------- drivers/scsi/sd.c | 48 ------------------------------------- include/linux/genhd.h...

...lar help functions. Ren Mingxin (4): block: add function disk_name_format() into block core scsi: replace sd_format_disk_name() to disk_name_format() block: replace rssd_disk_name_format() to disk_name_format() virtio_blk: use disk_name_format() to support mass of disks naming block/genhd.c | 49 ++++++++++++++++++++++++++++++++++++++ drivers/block/mtip32xx/mtip32xx.c | 33 ------------------------- drivers/block/virtio_blk.c | 13 ---------- drivers/scsi/sd.c | 48 ------------------------------------- include/linux/genhd.h...

On Wed, 08/17 10:49, Cornelia Huck wrote: > On Wed, 17 Aug 2016 15:15:06 +0800 > Fam Zheng <famz at redhat.com> wrote: > > > @@ -613,10 +614,8 @@ void device_add_disk(struct device *parent, struct gendisk *disk) > > disk->flags |= GENHD_FL_UP; > > > > retval = blk_alloc_devt(&disk->part0, &devt); > > - if (retval) { > > - WARN_ON(1); > > - return; > > - } > > + if (retval) > > + goto fail; > > disk_to_dev(disk)->devt = devt; > > > > /* ->...

...10:49, Cornelia Huck wrote: > > > On Wed, 17 Aug 2016 15:15:06 +0800 > > > Fam Zheng <famz at redhat.com> wrote: > > > > > > > @@ -613,10 +614,8 @@ void device_add_disk(struct device *parent, struct gendisk *disk) > > > > disk->flags |= GENHD_FL_UP; > > > > > > > > retval = blk_alloc_devt(&disk->part0, &devt); > > > > - if (retval) { > > > > - WARN_ON(1); > > > > - return; > > > > - } > > > > + if (retval) > > > > + goto fail...

...s entries after that. The fix here is to pass attr_groups from callers to device_add_disk, so it can be added before KOBJ_ADD. Also add basic error handling around device_add_disk code, (or add FIXME comment where work is left). Fam Zheng (15): disk: Drop add_disk in favor of device_add_disk genhd: Return error from register_disk() genhd: Return error from blk_register_region block: Return error from blk_integrity_add genhd: Return error from disk_{add,alloc}_events genhd: Add return code to device_add_disk genhd: Add attribute group parameter to device_add_disk nvme: Pass attrib...

...s entries after that. The fix here is to pass attr_groups from callers to device_add_disk, so it can be added before KOBJ_ADD. Also add basic error handling around device_add_disk code, (or add FIXME comment where work is left). Fam Zheng (15): disk: Drop add_disk in favor of device_add_disk genhd: Return error from register_disk() genhd: Return error from blk_register_region block: Return error from blk_integrity_add genhd: Return error from disk_{add,alloc}_events genhd: Add return code to device_add_disk genhd: Add attribute group parameter to device_add_disk nvme: Pass attrib...

...thout touching the offending callers. The approach I'm proposing here is adding a flag to suppress uevent in add_disk(), which is patch 1, then in later patches, convert any caller to only trigger the uevent when attributes are added. [1] https://lkml.org/lkml/2016/6/28/550 Fam Zheng (12): genhd: Add "gen_uevent" parameter to add_disk genhd: Honor gen_uevent and add disk_gen_uevents virtio-blk: Generate uevent after attribute available axonrom: Generate uevent after attribute available aoeblk: Generate uevent after attribute available mtip32xx: Generate uevent after att...

...thout touching the offending callers. The approach I'm proposing here is adding a flag to suppress uevent in add_disk(), which is patch 1, then in later patches, convert any caller to only trigger the uevent when attributes are added. [1] https://lkml.org/lkml/2016/6/28/550 Fam Zheng (12): genhd: Add "gen_uevent" parameter to add_disk genhd: Honor gen_uevent and add disk_gen_uevents virtio-blk: Generate uevent after attribute available axonrom: Generate uevent after attribute available aoeblk: Generate uevent after attribute available mtip32xx: Generate uevent after att...

...ote: > On Wed, 08/17 10:49, Cornelia Huck wrote: > > On Wed, 17 Aug 2016 15:15:06 +0800 > > Fam Zheng <famz at redhat.com> wrote: > > > > > @@ -613,10 +614,8 @@ void device_add_disk(struct device *parent, struct gendisk *disk) > > > disk->flags |= GENHD_FL_UP; > > > > > > retval = blk_alloc_devt(&disk->part0, &devt); > > > - if (retval) { > > > - WARN_ON(1); > > > - return; > > > - } > > > + if (retval) > > > + goto fail; > > > disk_to_dev(disk)-&gt...

...ote: > On Wed, 08/17 10:49, Cornelia Huck wrote: > > On Wed, 17 Aug 2016 15:15:06 +0800 > > Fam Zheng <famz at redhat.com> wrote: > > > > > @@ -613,10 +614,8 @@ void device_add_disk(struct device *parent, struct gendisk *disk) > > > disk->flags |= GENHD_FL_UP; > > > > > > retval = blk_alloc_devt(&disk->part0, &devt); > > > - if (retval) { > > > - WARN_ON(1); > > > - return; > > > - } > > > + if (retval) > > > + goto fail; > > > disk_to_dev(disk)-&gt...

On Wed, 17 Aug 2016 15:15:06 +0800 Fam Zheng <famz at redhat.com> wrote: > @@ -613,10 +614,8 @@ void device_add_disk(struct device *parent, struct gendisk *disk) > disk->flags |= GENHD_FL_UP; > > retval = blk_alloc_devt(&disk->part0, &devt); > - if (retval) { > - WARN_ON(1); > - return; > - } > + if (retval) > + goto fail; > disk_to_dev(disk)->devt = devt; > > /* ->major and ->first_minor aren't supposed to be &g...

On Wed, 17 Aug 2016 15:15:06 +0800 Fam Zheng <famz at redhat.com> wrote: > @@ -613,10 +614,8 @@ void device_add_disk(struct device *parent, struct gendisk *disk) > disk->flags |= GENHD_FL_UP; > > retval = blk_alloc_devt(&disk->part0, &devt); > - if (retval) { > - WARN_ON(1); > - return; > - } > + if (retval) > + goto fail; > disk_to_dev(disk)->devt = devt; > > /* ->major and ->first_minor aren't supposed to be &g...

Do not unregister the major at device remove, since there might be another device instances around. (qemu) pci_del 0 11 (qemu) ACPI: PCI interrupt for device 0000:00:0b.0 disabled (qemu) pci_del 0 10 (qemu) ------------[ cut here ]------------ WARNING: at block/genhd.c:126 unregister_blkdev+0x74/0x9e() ACPI: PCI interrupt for device 0000:00:0a.0 disabled Signed-off-by: Marcelo Tosatti <mtosatti at redhat.com> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 0cfbe8c..6231097 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers...

On Wed, Mar 28, 2012 at 02:54:43PM +0800, Ren Mingxin wrote: > Hi, > > The current virtblk's naming algorithm just supports 26^3 > disks. If there are mass of virtblks(exceeding 26^3), there > will be disks with the same name. > > According to "sd_format_disk_name()", I add function > "virtblk_name_format()" for virtblk to support mass of >

On Wed, Mar 28, 2012 at 02:54:43PM +0800, Ren Mingxin wrote: > Hi, > > The current virtblk's naming algorithm just supports 26^3 > disks. If there are mass of virtblks(exceeding 26^3), there > will be disks with the same name. > > According to "sd_format_disk_name()", I add function > "virtblk_name_format()" for virtblk to support mass of >

...oe at perches.com> --- block/blk-integrity.c | 12 +++---- block/blk-mq-sysfs.c | 6 ++-- block/blk-sysfs.c | 68 ++++++++++++++++++------------------- block/cfq-iosched.c | 2 +- block/deadline-iosched.c | 3 +- block/genhd.c | 37 ++++++++++---------- block/mq-deadline.c | 3 +- block/partition-generic.c | 22 ++++++------ drivers/block/DAC960.c | 3 +- drivers/block/aoe/aoeblk.c | 10 +++--- drivers/block/brd.c | 6 ++-- drivers...

...oe at perches.com> --- block/blk-integrity.c | 12 +++---- block/blk-mq-sysfs.c | 6 ++-- block/blk-sysfs.c | 68 ++++++++++++++++++------------------- block/cfq-iosched.c | 2 +- block/deadline-iosched.c | 3 +- block/genhd.c | 37 ++++++++++---------- block/mq-deadline.c | 3 +- block/partition-generic.c | 22 ++++++------ drivers/block/DAC960.c | 3 +- drivers/block/aoe/aoeblk.c | 10 +++--- drivers/block/brd.c | 6 ++-- drivers...