search for: generate_linker_script

Hi, when pushing libguestfs 1.27.53 (1:1.27.53-1) through my build setup befor uploading it to Debian, I noticed that "guestfs_internal_lstatlist@Base", a symbol that has been there since 1.20, is now missing. This causes dpkg-gensymbols(1) whose job it is to compare the symbols from the newly-built libraries to the known state to fail. If the guestfs_internal_* functions are not

...te_client_structs_print_c : unit -> unit val generate_event_string_c : unit -> unit val generate_guestfs_h : unit -> unit +val generate_guestfs_private_h : unit -> unit val generate_internal_actions_h : unit -> unit val generate_internal_frontend_cleanups_h : unit -> unit val generate_linker_script : unit -> unit diff --git a/generator/main.ml b/generator/main.ml index 8d385d1..9016063 100644 --- a/generator/main.ml +++ b/generator/main.ml @@ -96,6 +96,7 @@ Run it from the top source directory using the command output_to "src/guestfs_protocol.x" generate_xdr; output_to &q...

Move the generate_all_structs and generate_all_headers functions, previously internal within the implementation of generate_guestfs_h, to be usable by other functions in the same "C" module (but not public). Only code motion. --- generator/c.ml | 163 +++++++++++++++++++++++++++++---------------------------- 1 file changed, 82 insertions(+), 81 deletions(-) diff --git a/generator/c.ml

John, This was my attempt to add symbol versioning to the library, letting us break ABI without breaking any existing callers. Unfortunately it doesn't work: - the new versioned symbols are marked local in libguestfs.so - the existing symbols should now have @GUESTFS_0.0 versions, but don't The documentation for this stuff is extremely thin, and I've got a bad case of

...o "src/errnostring.c" generate_errnostring_c; - output_to "src/errnostring.h" generate_errnostring_h; output_to "src/event-string.c" generate_event_string_c; output_to "src/MAX_PROC_NR" generate_max_proc_nr; output_to "src/libguestfs.syms" generate_linker_script; diff --git a/m4/guestfs_ocaml.m4 b/m4/guestfs_ocaml.m4 index 0deff61..0479e70 100644 --- a/m4/guestfs_ocaml.m4 +++ b/m4/guestfs_ocaml.m4 @@ -50,7 +50,7 @@ AM_CONDITIONAL([HAVE_OCAMLDOC], dnl OCaml is required if we need to run the generator. AS_IF([test "x$OCAMLC" = "xno" |...

This is a simpler patch series to add symbol versioning. I have pushed patches 1-3 upstream. Rich.

This rather more complex patch series adds symbol versioning (7/7 shows it in action). This works for me, tested by running old and new virt-inspector binaries against the new library. Rich.

The safe_malloc (etc) functions call g->abort_fn on failure. That's not appropriate for language bindings, and we never intended that these internal functions be used from language bindings, that was just a historical accident. This patch series removes any external use of the safe_* functions. Rich.

This is an updated and extended version of the original patch: https://www.redhat.com/archives/libguestfs/2010-August/msg00163.html This adds OCaml and Perl bindings (both tested), support for progress bars in virt-resize, and adds progress notifications to a number of the simpler commands. Still to do is to add progress messages to more commands. There are still a few commands which would be

This is only lightly tested at the moment. For context see: https://bugzilla.redhat.com/show_bug.cgi?id=1138203#c40 https://bugzilla.redhat.com/show_bug.cgi?id=1075143 https://bugzilla.redhat.com/show_bug.cgi?id=1075164 Note this is not a complete fix. At least one more libguestfs patch is required (to implement virDomainPtr in the python bindings). Plus a virt-manager patch. Rich.

This completes the implementation on the libguestfs side, allowing python-libvirt dom pointers to be passed to guestfs_add_libvirt_dom. For context see: https://bugzilla.redhat.com/show_bug.cgi?id=1138203#c40 https://bugzilla.redhat.com/show_bug.cgi?id=1075143 https://bugzilla.redhat.com/show_bug.cgi?id=1075164 Rich.

...ree : unit -> unit @@ -35,7 +36,6 @@ val generate_client_structs_print_c : unit -> unit val generate_event_string_c : unit -> unit val generate_guestfs_h : unit -> unit val generate_internal_actions_h : unit -> unit -val generate_internal_frontend_cleanups_h : unit -> unit val generate_linker_script : unit -> unit val generate_max_proc_nr : unit -> unit val generate_structs_pod : unit -> unit diff --git a/generator/java.ml b/generator/java.ml index 7c3212a49..a7d0ed359 100644 --- a/generator/java.ml +++ b/generator/java.ml @@ -586,6 +586,7 @@ and generate_java_c actions () = #inclu...

A hopefully cleaner implementation this time. It doesn't require any special insights into how libvirt-python is implemented. Instead, it requires a change to libvirt-python to add a .c_pointer() method: https://www.redhat.com/archives/libvir-list/2014-December/msg00615.html Rich.

Since v3: - Fix labelling over overlays (see 6/6) - Tested it with a test program which simulates what virt-manager will do. See the attachment here: https://bugzilla.redhat.com/show_bug.cgi?id=1075164#c7 Rich.

...ate_client_structs_copy : unit -> unit +val generate_client_structs_free : unit -> unit +val generate_event_string_c : unit -> unit +val generate_guestfs_h : unit -> unit +val generate_internal_actions_h : unit -> unit +val generate_internal_frontend_cleanups_h : unit -> unit +val generate_linker_script : unit -> unit +val generate_max_proc_nr : unit -> unit +val generate_structs_pod : unit -> unit diff --git a/generator/checks.mli b/generator/checks.mli new file mode 100644 index 0000000..4bbbda5 --- /dev/null +++ b/generator/checks.mli @@ -0,0 +1,18 @@ +(* libguestfs + * Copyright (C) 2...

Use interfaces files (*.mli files) instead of exporting all symbols randomly. Change the 'file is generated' warnings at the top of generated files so they accurately describe which source file generates each output file. Rich.

By splitting up large C files we can make parallel compiles a bit faster. Rich.

...ompat_wrapper { name = name; + and generate_back_compat_wrapper { name; style = ret, args, _ as style } = generate_prototype ~extern:false ~semicolon:false ~newline:true ~handle:"g" ~prefix:"guestfs_" @@ -2305,13 +2305,13 @@ and generate_linker_script () = List.flatten ( List.map ( function - | { c_name = c_name; style = _, _, [] } -> ["guestfs_" ^ c_name] - | { c_name = c_name; style = _, _, (_::_); + | { c_name; style = _, _, [] } -> ["guestfs_" ^ c_name] + | { c_name;...

This patch series moves some files and directories around but is only code motion (or supposed to be). A new directory, common/, is created for all of the common code which is currently shared in random ways between parts of the project. And src/ becomes lib/ (the largest change, but mostly mechanical). In full this series makes the following changes: src/libprotocol -> common/protocol

Previous patch series was posted here: https://www.redhat.com/archives/libguestfs/2017-January/msg00059.html v2 simply extends this patch series to cover the extra directories common/edit, common/progress, common/windows and common/parallel. The only remaining item is to consider whether we should rename mllib to something else, mlcommon was my suggestion. Rich.