search for: generate_daemon_structs_cleanups_h

...o a different library. > --- I checked it again, and the daemon does use structs cleanups: $ cat generator/main.ml [...] output_to "daemon/structs-cleanups.c" Daemon.generate_daemon_structs_cleanups_c; output_to "daemon/structs-cleanups.h" Daemon.generate_daemon_structs_cleanups_h; See commits 32f0f9b032db592b50c4a4b0da29ef0de0478633 and 31fb6e20418e8f1b0647c92af0464f2009e9a997. So structs cleanups could stay in libutils -- OTOH, structs printing is only used in the library, and by guestfish. Thanks, -- Pino Toscano

...x) {\n"; + pr " xdr_free ((xdrproc_t) xdr_guestfs_int_%s_list, (char *) x);\n" + typ; + pr " free (x);\n"; + pr " }\n"; + pr "}\n"; + pr "\n"; + + ) structs + +(* Generate structs-cleanups.h file. *) +and generate_daemon_structs_cleanups_h () = + generate_header CStyle GPLv2plus; + + pr "\ +/* These CLEANUP_* macros automatically free the struct or struct list + * pointed to by the local variable at the end of the current scope. + */ + +#ifndef GUESTFS_DAEMON_STRUCTS_CLEANUPS_H_ +#define GUESTFS_DAEMON_STRUCTS_CLEANUPS_H_ + +#...

...checked it again, and the daemon does use structs cleanups: > > $ cat generator/main.ml > [...] > output_to "daemon/structs-cleanups.c" > Daemon.generate_daemon_structs_cleanups_c; > output_to "daemon/structs-cleanups.h" > Daemon.generate_daemon_structs_cleanups_h; Those are different from common/structs/structs-cleanups.[ch] though (hence why they use different generator functions to generate them). Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.co...

Hi, as a followup for the signature fix for mount_vfs [1], here it is a patch series to generate automatically most of the OCaml interfaces of daemon actions. Only the Lvm and Mount modules are left with hand-written interfaces. [1] https://www.redhat.com/archives/libguestfs/2018-April/msg00059.html Thanks, Pino Toscano (3): daemon: directly use Optgroups daemon: use the structs from the

...n) + (Daemon.generate_daemon_caml_interface modname) (* Main program. *) let () = @@ -155,6 +160,11 @@ Run it from the top source directory using the command Daemon.generate_daemon_structs_cleanups_c; output_to "daemon/structs-cleanups.h" Daemon.generate_daemon_structs_cleanups_h; + let daemon_ocaml_interfaces = [ + "Blkid"; "Btrfs"; "Devsparts"; "File"; "Filearch"; "Findfs"; "Inspect"; + "Is"; "Ldm"; "Link"; "Listfs"; "Md"; "Parted"; &quo...

...erator/main.ml index 34bca68d9..e51313779 100644 --- a/generator/main.ml +++ b/generator/main.ml @@ -155,6 +155,23 @@ Run it from the top source directory using the command Daemon.generate_daemon_structs_cleanups_c; output_to "daemon/structs-cleanups.h" Daemon.generate_daemon_structs_cleanups_h; + let daemon_ocaml_interfaces = + List.fold_left ( + fun set { impl } -> + let ocaml_function = + match impl with + | OCaml f -> fst (String.split "." f) + | C -> assert false in + + StringSet.add ocaml_function set + ) String...

Hi, as a followup for the signature fix for mount_vfs [1], here it is a patch series to generate automatically all the OCaml interfaces of daemon actions. [1] https://www.redhat.com/archives/libguestfs/2018-April/msg00059.html Thanks, Pino Toscano (5): daemon: directly use Optgroups daemon: use the structs from the Structs module daemon: move Lvm.lv_canonical to new Lvm_utils module

I think this fixes everything mentioned: - Added the Optgroups module as suggested. - Remove command temporary files. - Replace command ~flags with ?fold_stdout_on_stderr. - Nest _with_mounted function. - Rebase & retest. Rich.

v1 -> v2: - Fixed everything mentioned in patch review. - Libdir module is removed as a separate commit. Rich.

...aemon_names : unit -> unit val generate_daemon_optgroups_c : unit -> unit val generate_daemon_optgroups_h : unit -> unit val generate_daemon_optgroups_ml : unit -> unit +val generate_daemon_optgroups_mli : unit -> unit val generate_daemon_structs_cleanups_c : unit -> unit val generate_daemon_structs_cleanups_h : unit -> unit diff --git a/generator/main.ml b/generator/main.ml index 22add59b3..f4fed4f8b 100644 --- a/generator/main.ml +++ b/generator/main.ml @@ -147,6 +147,8 @@ Run it from the top source directory using the command Daemon.generate_daemon_optgroups_h; output_to "daemo...

This works reliably for me ... Rich.

This is just the utilities part of the patch series from: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html I believe this addresses everything raised in comments on that patch series. Rich.