search for: gcc_warn

...bd, but this change prevents them from being added in future. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6ea3197..0332d77 100644 --- a/configure.ac +++ b/configure.ac @@ -66,7 +66,7 @@ AC_ARG_ENABLE([gcc-warnings], [gcc_warnings=no] ) if test "x$gcc_warnings" = "xyes"; then - WARNINGS_CFLAGS="-Wall -Werror" + WARNINGS_CFLAGS="-Wall -Wvla -Werror" AC_SUBST([WARNINGS_CFLAGS]) fi -- 2.23.0

...nfigure.ac | 2 +- plugins/sh/sh.c | 7 +++---- server/sockets.c | 8 +++++++- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index 5842c6f..d326377 100644 --- a/configure.ac +++ b/configure.ac @@ -90,7 +90,7 @@ AC_ARG_ENABLE([gcc-warnings], [gcc_warnings=no] ) if test "x$gcc_warnings" = "xyes"; then - WARNINGS_CFLAGS="-Wall -Wshadow -Werror" + WARNINGS_CFLAGS="-Wall -Wshadow -Wvla -Werror" AC_SUBST([WARNINGS_CFLAGS]) fi diff --git a/plugins/sh/sh.c b/plugins/sh/sh.c index c73b08b..acb50c4...

...es. Signed-off-by: Eric Blake <eblake at redhat.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 4c92e2b1..5842c6f9 100644 --- a/configure.ac +++ b/configure.ac @@ -90,7 +90,7 @@ AC_ARG_ENABLE([gcc-warnings], [gcc_warnings=no] ) if test "x$gcc_warnings" = "xyes"; then - WARNINGS_CFLAGS="-Wall -Werror" + WARNINGS_CFLAGS="-Wall -Wshadow -Werror" AC_SUBST([WARNINGS_CFLAGS]) fi -- 2.21.0

...see: > https://lwn.net/Articles/763253/ > --- > configure.ac | 2 +- > plugins/sh/sh.c | 7 +++---- > server/sockets.c | 8 +++++++- > 3 files changed, 11 insertions(+), 6 deletions(-) > +++ b/configure.ac > @@ -90,7 +90,7 @@ AC_ARG_ENABLE([gcc-warnings], > [gcc_warnings=no] > ) > if test "x$gcc_warnings" = "xyes"; then > - WARNINGS_CFLAGS="-Wall -Wshadow -Werror" > + WARNINGS_CFLAGS="-Wall -Wshadow -Wvla -Werror" I'm guessing that both gcc and clang are okay with our current list; we may reach th...

.... Name: dovecot-imap_bodystructure_write_const.patch Type: text/x-diff Size: 1806 bytes Desc: not available URL: <http://dovecot.org/pipermail/dovecot/attachments/20070315/53f1ec71/attachment-0008.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: dovecot-gcc_warnings.patch Type: text/x-diff Size: 1133 bytes Desc: not available URL: <http://dovecot.org/pipermail/dovecot/attachments/20070315/53f1ec71/attachment-0009.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: dovecot-noreturn.patch Type: text/x-diff Size: 223...

While working on can_FOO caching, at one point I got confused by whether 'readonly' meant the global set by -r or a local passed to .open(). A quick attempt to compile with -Wshadow found several other confusing points; this series gets us to the point that we can add -Wshadow to builds with --enable-gcc-warnings. Eric Blake (10): server: Avoid -Wshadow warnings guestfs: Avoid

Two simple patches which make libnbd compile on FreeBSD. Are we OK to copy common/include/byte-swapping.h from nbdkit? There is no license issue that I know of. Should we put it in lib/ or create a common/ directory? The header file is actually also needed by the tests (follow up patch for that) so putting it in common/ might make more sense. Some notes if you want to compile on FreeBSD: -

This is an incomplete port to Windows. Currently the server compiles and starts up successfully, but goes into an infinite loop when you connect to it. Nevertheless I think the approach is ready for feedback. This being Windows the changes go quite deep. Rich.