search for: fuse_new

...ed this: libguestfs fails with an error, but the error code is "success": $ sudo guestmount -m /dev/sda1 --ro \ -o allow_others \ -a data.qcow2 \ /media/foo fuse: unknown option `allow_others' libguestfs: error: fuse_new: /media/foo/: Success Other fuse errors also cause the same behavior, e.g. mounting to an already-mounted directory: $ sudo guestmount -m /dev/sda1 --ro -a data2.qcow2 /media/foo /media/foo mountpoint is not empty fuse: mountpoint is not empty fuse: if you are sure this is safe, use...

...nt_local(g,"/mnt/libg")==-1) exit(EXIT_FAILURE); else guestfs_mount_local_run(g); ?? Below is a part of the debug dump information, ?? version = 1.17.40.Root device: /dev/vda1 (this is test output) libguestfs: guestfs__mount_local: fuse_mount /mnt/libg libguestfs: guestfs__mount_local: fuse_new libguestfs: guestfs__mount_local: leaving fuse_mount_local libguestfs: guestfs__mount_local_run: entering fuse_loop libguestfs: send_to_daemon: 56 bytes: 00 00 00 34 | 20 00 f5 f5 | 00 00 00 04 | 00 00 00 35 | 00 00 00 00 | ... guestfsd: main_loop: proc 11 (lvs) took 0.04 seconds guestfsd: main_lo...

...; + fd = fuse_chan_fd (ch); > + if (fd >= 0) { > + int flags = fcntl (fd, F_GETFD, 0); > + if (flags >= 0) > + fcntl (fd, F_SETFD, flags & ~FD_CLOEXEC); Doesn't check for (unlikely) error. > + } > + > + /* Create the FUSE handle. */ > + fuse = fuse_new (ch, &fuse_args, > + &fuse_operations, sizeof fuse_operations, NULL); > + if (!fuse) { > + perror ("fuse_new"); > + exit (EXIT_FAILURE); > + } > + fuse_opt_free_args (&fuse_args); > + > + /* Catch signals since they can leave...

...F_CLOEXEC on the channel. Some versions of libfuse don't do + * this. + */ + fd = fuse_chan_fd (ch); + if (fd >= 0) { + int flags = fcntl (fd, F_GETFD, 0); + if (flags >= 0) + fcntl (fd, F_SETFD, flags & ~FD_CLOEXEC); + } + + /* Create the FUSE handle. */ + fuse = fuse_new (ch, &fuse_args, + &fuse_operations, sizeof fuse_operations, NULL); + if (!fuse) { + perror ("fuse_new"); + exit (EXIT_FAILURE); + } + fuse_opt_free_args (&fuse_args); + + /* Catch signals since they can leave the mountpoint in a funny + * state....

This version doesn't crash or cause hung processes or stuck mountpoints, so that's an improvement. Rich.

This patch is just for review. It enables FUSE support in the API via two new calls, 'guestfs_mount_local' and 'guestfs_umount_local'. FUSE turns out to be very easy to deadlock (necessitating that the machine be rebooted). Running the test from the third patch is usually an effective way to demonstrate this. However I have not yet managed to produce a simple reproducer that

This changes the proposed API slightly. Previously 'mount-local' generating a 'mounted' event when the filesystem was ready, and from the 'mounted' event you had to effectively do a fork. Now, 'mount-local' just initializes the mountpoint and you have to call 'mount-local-run' to enter the FUSE main loop. Between these calls you can do a fork or whatever

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.