search for: functionv

...ion opcode, so there are more than just these values possible here 00139 /// (and Instruction must be last). 00140 /// 00141 enum ValueTy { 00142 ArgumentVal, // This is an instance of Argument 00143 BasicBlockVal, // This is an instance of BasicBlock 00144 FunctionVal, // This is an instance of Function 00145 GlobalVariableVal, // This is an instance of GlobalVariable 00146 UndefValueVal, // This is an instance of UndefValue 00147 ConstantExprVal, // This is an instance of ConstantExpr 00148 ConstantAggre...

...return -1; > > if (int Res = cmpNumbers(L->getValueID(), R->getValueID())) > return Res; > > switch (L->getValueID()) { > > ? In particular I'm not a fan of how LType/RType are equal to valueID+1, > even with the comment. > > + case Value::FunctionVal: > + case Value::GlobalVariableVal: > + case Value::GlobalAliasVal: > + default: // Unknown constant > + return cmpNumbers((uint64_t)L, (uint64_t)R); > > Please assert on unknown constant. > > How are function, global variable and alias reachable here? > > 0004...

Hi Nick, I tried to rework changes as you requested. One of patches (0004 with extra assertions) has been removed. > + bool isEquivalentType(Type *Ty1, Type *Ty2) const { > + return cmpType(Ty1, Ty2) == 0; > + } > > Why do we still need isEquivalentType? Can we nuke this? Yup. After applying all the patches isEquivalentType will be totally replaced with cmpType. All