Displaying 6 results from an estimated 6 matches for "functionprologueworklist".
2015 Oct 12
2
[RFC] Clean up the way we store optional Function data
...makes sense to me, but only if we never need to add
> prefix/prologue data after functions are created. Are there any places
> where we need/want to add them after the fact?
I think so. I see:
LinkModules.cpp: Dst.setPrefixData(MapValue(Src.getPrefixData(), ValueMap,
BitcodeReader.cpp: FunctionPrologueWorklist.back().first->setPrologueData(C);
InlineFunction.cpp: Caller->setPersonalityFn(CalledPersonality);
Some of these sites could be refactored so that the Functions are created with the prefix/prologue data they need. I don't think that's possible for personality functions (see my third...
2015 Oct 12
3
[RFC] Clean up the way we store optional Function data
...gt; prefix/prologue data after functions are created. Are there any places
>>> where we need/want to add them after the fact?
>>
>> I think so. I see:
>>
>> LinkModules.cpp: Dst.setPrefixData(MapValue(Src.getPrefixData(), ValueMap,
>> BitcodeReader.cpp: FunctionPrologueWorklist.back().first->setPrologueData(C);
>> InlineFunction.cpp: Caller->setPersonalityFn(CalledPersonality);
>>
>> Some of these sites could be refactored so that the Functions are created with the prefix/prologue data they need. I don't think that's possible for personali...
2015 Oct 12
2
[RFC] Clean up the way we store optional Function data
...ces
> > >> where we need/want to add them after the fact?
> > >
> > > I think so. I see:
> > >
> > > LinkModules.cpp:
> Dst.setPrefixData(MapValue(Src.getPrefixData(), ValueMap,
> > > BitcodeReader.cpp:
> FunctionPrologueWorklist.back().first->setPrologueData(C);
> > > InlineFunction.cpp: Caller->setPersonalityFn(CalledPersonality);
> > >
> > > Some of these sites could be refactored so that the Functions are
> created with the prefix/prologue data they need. I don't t...
2015 Oct 16
2
[RFC] Clean up the way we store optional Function data
...t; where we need/want to add them after the fact?
>>>>>
>>>>> I think so. I see:
>>>>>
>>>>> LinkModules.cpp:
>>> Dst.setPrefixData(MapValue(Src.getPrefixData(), ValueMap,
>>>>> BitcodeReader.cpp:
>>> FunctionPrologueWorklist.back().first->setPrologueData(C);
>>>>> InlineFunction.cpp: Caller->setPersonalityFn(CalledPersonality);
>>>>>
>>>>> Some of these sites could be refactored so that the Functions are
>>> created with the prefix/prologue data they need....
2015 Oct 21
2
[RFC] Clean up the way we store optional Function data
...t;>>>>>>
>>>>>>> I think so. I see:
>>>>>>>
>>>>>>> LinkModules.cpp:
>>>>> Dst.setPrefixData(MapValue(Src.getPrefixData(), ValueMap,
>>>>>>> BitcodeReader.cpp:
>>>>> FunctionPrologueWorklist.back().first->setPrologueData(C);
>>>>>>> InlineFunction.cpp: Caller->setPersonalityFn(CalledPersonality);
>>>>>>>
>>>>>>> Some of these sites could be refactored so that the Functions are
>>>>> created with the pr...
2015 Oct 12
2
[RFC] Clean up the way we store optional Function data
Hi Sanjoy,
> I don't know how prologue and prefix data is used -- is it correct to
> say that you're basically trying to give `llvm::Function` s some
> "optional" operands, and that you know during construction of an
> `llvm::Function` how many optional operands the `llvm::Function` will
> need[1]?
Yep. Though not operands exactly, since they wouldn't be in