search for: ftentry_t

Displaying 3 results from an estimated 3 matches for "ftentry_t".

2010 Dec 08
0
[LLVMdev] Reviewer for our Path Profiling Implementation
...ite(outFile, &PTy, sizeof( Profile)); Some builds may warn of the unused result. If you're not checking the result, you probably shouldn't retrieve it. +++ runtime/libprofile/PathProfiling.c + inline uint32_t* getPathCounter(uint32_t functionNumber, uint32_t pathNumber) { ... + if( ((ftEntry_t*)ft)[functionNumber-1].array == 0) + ((ftEntry_t*)ft)[functionNumber-1].array = calloc(sizeof(pathHashTable_t), 1); It's not immediately obvious to me why you always cast "ft". Since this is a runtime lib, it may be wise to add array bounds checks. In getPathCounter can you check...
2010 Dec 08
1
[LLVMdev] Reviewer for our Path Profiling Implementation
...; > Some builds may warn of the unused result. If you're not checking the > result, you probably shouldn't retrieve it. > > +++ runtime/libprofile/PathProfiling.c > > + inline uint32_t* getPathCounter(uint32_t functionNumber, uint32_t pathNumber) { > ... > + if( ((ftEntry_t*)ft)[functionNumber-1].array == 0) > + ((ftEntry_t*)ft)[functionNumber-1].array = > calloc(sizeof(pathHashTable_t), 1); > > It's not immediately obvious to me why you always cast "ft". I think there used to be a reason, but I don't see a reason to any more. > &...
2010 Dec 03
4
[LLVMdev] Reviewer for our Path Profiling Implementation
I am a student at the University of Alberta under the supervision of José Nelson Amaral, and I have been working on implementing path profiling into LLVM. I have completed my project and would like to submit it. We are looking for a reviewer for the path profiling implementation. We have sent previous requests to the llvmdev list but have so far been unsuccessful. Please see the attached