search for: fstring

This is a simpler patch series to add symbol versioning. I have pushed patches 1-3 upstream. Rich.

This rather more complex patch series adds symbol versioning (7/7 shows it in action). This works for me, tested by running old and new virt-inspector binaries against the new library. Rich.

Here's the new API method and update to virt-inspector. I still need to implement app_arch for debian and windows (if applicable), for now they just return empty strings.

...-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/generator/structs.ml b/generator/structs.ml > index 6017ba6..d986fd9 100644 > --- a/generator/structs.ml > +++ b/generator/structs.ml > @@ -442,8 +442,20 @@ let structs = [ > "im_device", FString; > "im_volume", FString; > ]; > - s_camel_name = "InternalMountable"; > - }; > + s_camel_name = "InternalMountable" }; Unneeded change. > + (* The Sleuth Kit directory entry information. *) > + { defaults with > + s_name...

John, This was my attempt to add symbol versioning to the library, letting us break ABI without breaking any existing callers. Unfortunately it doesn't work: - the new versioned symbols are marked local in libguestfs.so - the existing symbols should now have @GUESTFS_0.0 versions, but don't The documentation for this stuff is extremely thin, and I've got a bad case of

Here's the new API method and update to virt-inspector. I still need to implement app_arch for debian and windows (if applicable), for now they just return empty strings. New in v2: incorporated feedback from v1, also added patch #3 which updates the documentation where it references the deprecated API. Take it or leave it.

Here's a partially implemented fix for RHBZ#859949. Seeing as this is my first libguestfs patch, I'd like some other eyeballs on it to make sure I've not done anything completely crazy. If the rpm case looks ok, I'll update the deb and windows cases if/where applicable.

...******************** + Update primary group SID in passdb with <string_sid> + for users whose Unix primary group is <gid>. Useful + after a net_groupmap add/modify/delete. +******************************************************/ +static BOOL update_users_primgroup_sid(const gid_t gid, fstring string_sid) +{ + SAM_ACCOUNT *sam_pwent=NULL; + struct passwd *pass=NULL; + fstring usrname = ""; + + /* Initialize static context */ + if(!initialize_password_db(True)) { + DEBUG(0,("update_users_primgroup_sid: Cannot initialize password...

...ply duplicating the string, so strdup can be a better (and faster) alternative. OTOH, why do you need to duplicate fsfile->meta->link at all, given that the copy will be free'd at the end of the function? > + > + dirent.tsk_link = flink; > + } Also note that NULL values for FString in structs cannot be returned in daemon calls, you need to have empty strings for the unset values. > > ret = send_dirent_info (&dirent); > - ret = (ret == 0) ? TSK_WALK_CONT : TSK_WALK_ERROR; > > - return ret; > + return (ret == 0) ? TSK_WALK_CONT : TSK_WALK_ERROR;...

...generator/structs.ml | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/generator/structs.ml b/generator/structs.ml index 6017ba6..d986fd9 100644 --- a/generator/structs.ml +++ b/generator/structs.ml @@ -442,8 +442,20 @@ let structs = [ "im_device", FString; "im_volume", FString; ]; - s_camel_name = "InternalMountable"; - }; + s_camel_name = "InternalMountable" }; + + (* The Sleuth Kit directory entry information. *) + { defaults with + s_name = "tsk_dirent"; + s_cols = [ + "tsk_...

...generator/structs.ml | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/generator/structs.ml b/generator/structs.ml index 6017ba6..4abb576 100644 --- a/generator/structs.ml +++ b/generator/structs.ml @@ -442,8 +442,21 @@ let structs = [ "im_device", FString; "im_volume", FString; ]; s_camel_name = "InternalMountable"; }; + + (* The Sleuth Kit directory entry information. *) + { defaults with + s_name = "tsk_dirent"; + s_cols = [ + "tsk_inode", FUInt64; + "tsk_type", FCha...

...h: diff -urN nut-2.2.1-dist/drivers/bestfcom.c nut-2.2.1/drivers/bestfcom.c --- nut-2.2.1-dist/drivers/bestfcom.c 2008-06-13 14:04:07.000000000 -0500 +++ nut-2.2.1/drivers/bestfcom.c 2008-06-13 14:05:00.000000000 -0500 @@ -277,8 +277,8 @@ /* AC line frequency */ acfreq = ((double)bcd2i(&fstring[54], 4) / 100.0); - /* Runtime remaining */ - btimeleft = bcd2i(&fstring[58], 4); + /* Runtime remaining (UPS reports minutes) */ + btimeleft = bcd2i(&fstring[58], 4) * 60; if (fc.model != FDxxxx) { /* Iout. int times 10 */ -- Chris Adams <cmadams at hiwaay.net> Sys...

Hi Jerry et al, the parsing of the 'username map' file seems to be broken in 3.0.5pre1 and a few earlier releases. The '!' at the beginning of a line is ignored. Something like !lp = lp !chbeyer = chbeyer !guest = guest nobody = * doesn't work anymore :-( from the man page: [ snip ] If any line begins with an '!' then the processing will stop

...44 --- a/generator/structs.ml +++ b/generator/structs.ml @@ -374,6 +374,19 @@ let structs = [ ]; s_camel_name = "BTRFSScrub" }; + (* btrfs filesystem show output *) + { defaults with + s_name = "btrfsfsshow"; + s_cols = [ + "btrfsfsshow_label", FString; + "btrfsfsshow_uuid", FString; + "btrfsfsshow_devid", FUInt32; + "btrfsfsshow_total_bytes", FUUID; + "btrfsfsshow_bytes_used", FUUID; + "btrfsfsshow_device", FString; + ]; + s_camel_name = "BTRFSFilesystemShowAll...

...+ } } - " +"; + List.iter ( + fun { s_camel_name = name; s_name = c_name; s_cols = cols } -> + pr "\n"; + pr "pub struct %s {\n" name; + List.iter ( + function + | n, FChar -> pr " %s: i8,\n" n + | n, FString -> pr " %s: String,\n" n + | n, FBuffer -> pr " %s: Vec<u8>,\n" n + | n, FUInt32 -> pr " %s: u32,\n" n + | n, FInt32 -> pr " %s: i32,\n" n + | n, (FUInt64 | FBytes) -> pr " %s: u64,\n"...

...let structs = [ > > ]; > > s_camel_name = "BTRFSScrub" }; > > > > + (* btrfs filesystem show output *) > > + { defaults with > > + s_name = "btrfsfsshow"; > > + s_cols = [ > > + "btrfsfsshow_label", FString; > > + "btrfsfsshow_uuid", FString; > > + "btrfsfsshow_devid", FUInt32; > > + "btrfsfsshow_total_bytes", FUUID; > > + "btrfsfsshow_bytes_used", FUUID; > > Surely bytes are not an UUID? There's FBytes, so...

...can find deleted files." }; + ] (* Non-API meta-commands available only in guestfish. diff --git a/generator/structs.ml b/generator/structs.ml index 6017ba6..9d2f309 100644 --- a/generator/structs.ml +++ b/generator/structs.ml @@ -442,8 +442,18 @@ let structs = [ "im_device", FString; "im_volume", FString; ]; - s_camel_name = "InternalMountable"; - }; + s_camel_name = "InternalMountable" }; + + (* The Sleuth Kit node info struct. *) + { defaults with + s_name = "tsk_node"; + s_cols = [ + "tsk_name", F...

The ffind API allows to retrieve a file name from a device given its inode. The function returns a struct "tsknode" which contains the file name, its inode and it's allocation status. The struct will be employed by other APIs as well (fls, ifind etc..). $ ./run guestfish --ro -a /home/noxdafox/disks/ubuntu.qcow2 ><fs> run ><fs> ffind /dev/sda1 2 tsk_name: /

Report access, modification, status update and creation time in Unix format. Report number of links pointing to a given entry. If the entry is a symbolic link, report the path of its target. If the filesystem supports native/transparent compression, report compressed files with dedicated flag (DIRENT_COMPRESSED 0x04). Matteo Cafasso (2): filesystem_walk: more information into tsk_dirent

...nerator_structs.ml index 024bb3c..3dded35 100644 --- a/generator/generator_structs.ml +++ b/generator/generator_structs.ml @@ -213,6 +213,35 @@ let structs = [ "iso_volume_effective_t", FInt64; ]; + (* XFS info descriptor. *) + "xfsinfo", [ + "mntpoint", FString; + "inodesize", FUInt32; + "agcount", FUInt32; + "agsize", FUInt32; + "sectsize", FUInt32; + "attr", FUInt32; + "blocksize", FUInt32; + "datablocks", FUInt64; + "imaxpct", FUInt32; + "sun...