search for: fstrim

Here's a fun one: + guestfish -N test-virt-sparsify-in-place-fstrim-unsupported.img=fs:vfat exit + virt-sparsify --in-place test-virt-sparsify-in-place-fstrim-unsupported.img + tee test-virt-sparsify-in-place-fstrim-unsupported.log [ 2.4] Trimming /dev/sda1 [ 7.5] Sparsify in-place operation completed with no errors + grep 'warning:.*fstrim' test-virt-s...

I think I found a bug affecting btrfs filesystems and users invoking fstrim to discard unused blocks: if I execute a `fstrim -v /` twice, the amount trimmed does not change on the 2nd invocation AND it takes just as long as the first.  Why do I think this is a bug?  When I do the same on an ext4 partition I get different behavior: the output shows 0 B trimmed and it does i...

Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1364347

On Wed, Sep 05, 2018 at 04:41:01PM +0100, Daniel P. Berrangé wrote: > On Wed, Sep 05, 2018 at 04:37:05PM +0100, Richard W.M. Jones wrote: > > > > Here's a fun one: > > > > + guestfish -N test-virt-sparsify-in-place-fstrim-unsupported.img=fs:vfat exit > > + virt-sparsify --in-place test-virt-sparsify-in-place-fstrim-unsupported.img > > + tee test-virt-sparsify-in-place-fstrim-unsupported.log > > [ 2.4] Trimming /dev/sda1 > > [ 7.5] Sparsify in-place operation completed with no errors >...

Since Linux commit f663b5b38fff trimming vfat is now supported by Linux. This broke the test which assumed it was not supported. Use another filesystem (minix) which does not support trimming instead. Thanks: Daniel P. Berrangé and Pino Toscano. --- ...virt-sparsify-in-place-fstrim-unsupported.sh | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/sparsify/test-virt-sparsify-in-place-fstrim-unsupported.sh b/sparsify/test-virt-sparsify-in-place-fstrim-unsupported.sh index ff7dab3fa..e2b2e9c20 100755 --- a/sparsify/test-virt-sparsify-in-place-...

This reverts the change made for RHBZ#1168144. The warning is now always displayed. It would be nice to make the warning actionable, but there is not a lot that end users can do since fstrim is such a complex topic interacting with all filesystem and storage layers. --- v2v/v2v.ml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/v2v/v2v.ml b/v2v/v2v.ml index e221f29..8365aae 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -397,11 +397,7 @@ and do_fstrim g inspect =...

...trim. It is my understanding that all thin pools should support trim even if the underlying device doesn't. (please correct me if I'm wrong here) I have one centos server that does support trim and everything is working correctly but any new servers and thin pools throw the error below. # fstrim -v /mnt/data00 fstrim: /mnt/data00: the discard operation is not supported I can't find any differences in the LVM configuration between the two servers, they both have the lv discards set to passthough. Can anyone tell me if I'm missing something when creating the thin pool that would al...

I still get the "the discard operation is not supported" fstrim error when the LVs are set to "nopassdown" Seems that when I use ext4 the fstrim reports that it worked but the LVs Data% does not decrease after the fstrim. xfs just throws the error. I've also been looking at the output of lsblk -D # lsblk -D NAME DISC-ALN DISC-G...

Since Linux commit f663b5b38fff trimming vfat is now supported by Linux. This broke the test which assumed it was not supported. Use another filesystem (minix) which does not support trimming instead. Thanks: Daniel P. Berrangé and Pino Toscano. --- ...est-virt-sparsify-in-place-fstrim-unsupported.sh | 13 ++++++------- tests/test-functions.sh | 10 ++++++++++ 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/sparsify/test-virt-sparsify-in-place-fstrim-unsupported.sh b/sparsify/test-virt-sparsify-in-place-fstrim-unsupported.sh index ff7da...

This addresses the feedback on v1 here: https://www.redhat.com/archives/libguestfs/2018-September/msg00023.html Rich.

Hi! With 3.2-rc4 (probably earlier), Ext4 seems to remember what areas it trimmed: merkaba:~> fstrim -v /boot /boot: 224657408 bytes were trimmed merkaba:~> fstrim -v /boot /boot: 0 bytes were trimmed But BTRFS does not: merkaba:~> fstrim -v / /: 4431613952 bytes were trimmed merkaba:~> fstrim -v / /: 4341846016 bytes were trimmed Is it planned to add this feature to BTRFS as wel...

...Friday, 12 August 2016 10:37:29 CEST Richard W.M. Jones wrote: > > This reverts the change made for RHBZ#1168144. The warning is now > > always displayed. > > > > It would be nice to make the warning actionable, but there is not a > > lot that end users can do since fstrim is such a complex topic > > interacting with all filesystem and storage layers. > > --- > > v2v/v2v.ml | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/v2v/v2v.ml b/v2v/v2v.ml > > index e221f29..8365aae 100644 > >...

Because we run the external fstrim command we don't have access to the kernel errno when it fails. However in the case where it prints this specific error message, turn that into errno ENOTSUP. --- daemon/fstrim.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/daemon/fstrim.c b/daemon/fstrim.c index...

Hi, I'm trying to find out how to enable fstrim support for libvirt/qemu guests. Specifically I'm trying to enable this on a CentOS 7 host (qemu 1.5). I searched the web but only found very vague information and no clear documentation on the requirements or how to modify the guest xml to enable discard/fstrim support. Can someone point me i...

On Mon, Nov 3, 2014 at 4:24 PM, Michal Privoznik <mprivozn@redhat.com> wrote: > On 01.11.2014 05:30, Dennis Jacobfeuerborn wrote: >> >> Hi, >> I'm trying to find out how to enable fstrim support for libvirt/qemu >> guests. Specifically I'm trying to enable this on a CentOS 7 host (qemu >> 1.5). I searched the web but only found very vague information and no >> clear documentation on the requirements or how to modify the guest xml >> to enable discard/fst...

As the minimum block size to discard in qcow2 is 64K, any point in fstrimming smaller contiguous blocks? TIA, Y.

On Friday, 5 August 2016 12:22:45 CEST Richard W.M. Jones wrote: > Because we run the external fstrim command we don't have access to the > kernel errno when it fails. However in the case where it prints this > specific error message, turn that into errno ENOTSUP. > --- Can you please note this behaviour in the documentation of the fstrim API? Thanks, -- Pino Toscano

On Friday, 12 August 2016 10:37:29 CEST Richard W.M. Jones wrote: > This reverts the change made for RHBZ#1168144. The warning is now > always displayed. > > It would be nice to make the warning actionable, but there is not a > lot that end users can do since fstrim is such a complex topic > interacting with all filesystem and storage layers. > --- > v2v/v2v.ml | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/v2v/v2v.ml b/v2v/v2v.ml > index e221f29..8365aae 100644 > --- a/v2v/v2v.ml > +++ b/v2v/v2v.ml &...

...0:37:29 CEST Richard W.M. Jones wrote: > > > This reverts the change made for RHBZ#1168144. The warning is now > > > always displayed. > > > > > > It would be nice to make the warning actionable, but there is not a > > > lot that end users can do since fstrim is such a complex topic > > > interacting with all filesystem and storage layers. > > > --- > > > v2v/v2v.ml | 6 +----- > > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > > > diff --git a/v2v/v2v.ml b/v2v/v2v.ml > > > index...

On Wed, Sep 05, 2018 at 04:37:05PM +0100, Richard W.M. Jones wrote: > > Here's a fun one: > > + guestfish -N test-virt-sparsify-in-place-fstrim-unsupported.img=fs:vfat exit > + virt-sparsify --in-place test-virt-sparsify-in-place-fstrim-unsupported.img > + tee test-virt-sparsify-in-place-fstrim-unsupported.log > [ 2.4] Trimming /dev/sda1 > [ 7.5] Sparsify in-place operation completed with no errors > + grep 'warning:...