search for: fsp_name

...*really* carefully :-). The open code can be really tricky (as you've already found). Thanks ! Jeremy. > The issue appears to be in this call: > > 3638 /* Ensure there was no race condition. */ > 3639 if (!check_same_stat(&smb_dname->st, &fsp->fsp_name->st)) { > 3640 samba_start_debugger(); > 3641 DEBUG(5,("open_directory: stat struct differs for " > 3642 "directory %s.\n", > 3643 smb_fname_str_dbg(smb_dname))); > 3644...

...wrote the attached patch. > > We got the logs by forcing smbd to run with -d10 by patching > file_server/fileserver.c. The issue appears to be in this call: 3638 /* Ensure there was no race condition. */ 3639 if (!check_same_stat(&smb_dname->st, &fsp->fsp_name->st)) { 3640 samba_start_debugger(); 3641 DEBUG(5,("open_directory: stat struct differs for " 3642 "directory %s.\n", 3643 smb_fname_str_dbg(smb_dname))); 3644 fd_cl...

Whenever I try to read or modify ACLs from my Windows 2000 PDC, my Samba Domain Member Server (Security = ADS) does not allow setting ACLs, nor does it display the existing ACLs. - I have setup ACLs in my Kernel - I have translated and installed libacl and libattr - I can see and modify ACLs with getfacl and setfacl. - I have translated Samba 3.0.23d with --with-acl-support=yes - I have enabled

..._afsacl.c samba/source/modules/vfs_afsacl.c --- samba-3.0.23d/source/modules/vfs_afsacl.c 2006-06-23 08:16:50.000000000 -0500 +++ samba/source/modules/vfs_afsacl.c 2007-01-29 20:11:07.000000000 -0600 @@ -901,7 +901,7 @@ ZERO_STRUCT(dir_acl); ZERO_STRUCT(file_acl); - pstr_sprintf(name, fsp->fsp_name); + pstrcpy(name, fsp->fsp_name); if (!fsp->is_directory) { /* We need to get the name of the directory containing the -------------- next part -------------- -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (GNU/Linux) iD8DBQBFvrtvIR7qMdg1EfYRAqGvAJ4onsF4xrEJRULF8wELiui9g...

..._afsacl.c samba/source/modules/vfs_afsacl.c --- samba-3.0.23d/source/modules/vfs_afsacl.c 2006-06-23 08:16:50.000000000 -0500 +++ samba/source/modules/vfs_afsacl.c 2007-01-29 20:11:07.000000000 -0600 @@ -901,7 +901,7 @@ ZERO_STRUCT(dir_acl); ZERO_STRUCT(file_acl); - pstr_sprintf(name, fsp->fsp_name); + pstrcpy(name, fsp->fsp_name); if (!fsp->is_directory) { /* We need to get the name of the directory containing the -------------- next part -------------- -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (GNU/Linux) iD8DBQBFvrtvIR7qMdg1EfYRAqGvAJ4onsF4xrEJRULF8wELiui9...

...close(files_struct *fsp, BOOL delete_on_close) { DEBUG(10,("set_delete_on_close: %s delete on close flag for " "fnum = %d, file %s\n", delete_on_close ? "Adding" : "Removing", fsp->fnum, fsp->fsp_name )); if (fsp->is_directory || fsp->is_stat) return NT_STATUS_OK; if (lock_share_entry_fsp(fsp) == False) return NT_STATUS_ACCESS_DENIED; -- Axel.Thimm at ATrpms.net -------------- next part -------------- A non-text attachment was scrubbed.....

...show up in the security dialog. I did notice when perusing the source code (posix_acl's.x) that it is running a check here: ~ if (ace_count != 3) { ~ DEBUG(3,("convert_canon_ace_to_posix_perms: Too many ACE entries for file %s to convert to \ posix perms.\n", fsp->fsp_name )); ~ return False; ~ } I did attempt to bump it up but it just stopped erroring out :) ( Duh liz!) still didnt work.. Any ideas? - ----------Data---- # file: testfile # owner: xxx if (ace_count != 3) { # group: domain\040users user::rwx user:bin:rwx user:lisa:r-- group::r-...

...<scabrero at samba.org> ?? * BUG 14979: Problem when winbind renews Kerberos. ?? * BUG 15095: Samba with new lorikeet-heimdal fails to build on gcc 12.1 in ???? developer mode. o? Volker Lendecke <vl at samba.org> ?? * BUG 15105: Crash in streams_xattr because fsp->base_fsp->fsp_name is NULL. ?? * BUG 15118: Crash in rpcd_classic - NULL pointer deference in ???? mangle_is_mangled(). o? Noel Power <noel.power at suse.com> ?? * BUG 15100: smbclient commands del & deltree fail with ???? NT_STATUS_OBJECT_PATH_NOT_FOUND with DFS. o? Christof Schmitt <cs at samba....

...<scabrero at samba.org> ?? * BUG 14979: Problem when winbind renews Kerberos. ?? * BUG 15095: Samba with new lorikeet-heimdal fails to build on gcc 12.1 in ???? developer mode. o? Volker Lendecke <vl at samba.org> ?? * BUG 15105: Crash in streams_xattr because fsp->base_fsp->fsp_name is NULL. ?? * BUG 15118: Crash in rpcd_classic - NULL pointer deference in ???? mangle_is_mangled(). o? Noel Power <noel.power at suse.com> ?? * BUG 15100: smbclient commands del & deltree fail with ???? NT_STATUS_OBJECT_PATH_NOT_FOUND with DFS. o? Christof Schmitt <cs at samba....

Hello, Back when 2.2.2 was the current samba release I came across the following problem when deleting folders in Windows 2000 which I'll repost again below. After I finally got his attention with a few very wordy messages to the samba mailing list, Jeremy fixed it blazingly fast and wrote me back: "I just found the problem and fixed it in 2.2 CVS and HEAD CVS. It was to do with the

...------------- call_trans2qfilepathinfo: ---------------------------------------------------------------------- /* * Original code - this is an open file. */ CHECK_FSP(fsp,conn); fname = fsp->fsp_name; if (vfs_fstat(fsp,fsp->fd,&sbuf) != 0) { DEBUG(3,("fstat of fnum %d failed (%s)\n",fsp->fnum, strerror(errno))); return(UNIXERROR(ERRDOS,ERRbadfid)); }...

...ignore system acls", > false); > - TALLOC_CTX *frame = talloc_stackframe(); > + char *sys_acl_blob_description = NULL; > + DATA_BLOB sys_acl_blob = { 0 }; > + bool psd_is_from_fs = false; > > if (fsp && smb_fname_in == NULL) { > smb_fname = fsp->fsp_name; > @@ -505,11 +508,10 @@ static NTSTATUS get_nt_acl_internal(vfs_handle_struct *handle, > > DEBUG(10, ("get_nt_acl_internal: name=%s\n", smb_fname->base_name)); > > - status = get_acl_blob(frame, handle, fsp, smb_fname, &blob); > + status = get_acl_blob(mem_...

On Fri, Aug 26, 2016 at 06:33:26PM +0200, Ralph Böhme via samba wrote: > On Thu, Aug 25, 2016 at 12:14:00PM -0700, Jeremy Allison wrote: > > On Wed, Aug 24, 2016 at 04:06:42PM +0200, Ralph Böhme via samba wrote: > > > > > > Yeah, as much as I'd like to avoid adding a new option, I guess we > > > have to do something about it, my latest take on this is >

...over the STRICT_ALLOCATE_PARTIAL_LIMIT. */ + + if ((sa_options == STRICT_ALLOCATE_PARTIAL) && + (len - st.st_size > STRICT_ALLOCATE_PARTIAL_LIMIT)) { + return 0; + } + DEBUG(10,("vfs_fill_sparse: write zeros in file %s from len %.0f to len %.0f (%.0f bytes)\n", fsp->fsp_name, (double)st.st_size, (double)len, (double)(len - st.st_size))); ----- End forwarded message ----- -------------- next part -------------- diff --git a/source/include/local.h b/source/include/local.h index c125ded..b0fd7cb 100644 --- a/source/include/local.h +++ b/source/include/local.h @@ -253,...

...vfs_fruit: Validation of writes on AFP_AfpInfo stream. * BUG 13688: vfs_shadow_copy2: Nicely deal with attempts to open previous version for writing. * BUG 13455: Restoring previous version of stream with vfs_shadow_copy2 fails with NT_STATUS_OBJECT_NAME_INVALID fsp->base_fsp->fsp_name. o Isaac Boukris <iboukris at gmail.com> * BUG 13571: CVE-2018-16853: Fix S4U2Self crash with MIT KDC build. o Günther Deschner <gd at samba.org> * BUG 13708: s3-vfs: Prevent NULL pointer dereference in vfs_glusterfs. o Joe Guo <joeg at catalyst.net.nz> * PEP8: fix...

...vfs_fruit: Validation of writes on AFP_AfpInfo stream. * BUG 13688: vfs_shadow_copy2: Nicely deal with attempts to open previous version for writing. * BUG 13455: Restoring previous version of stream with vfs_shadow_copy2 fails with NT_STATUS_OBJECT_NAME_INVALID fsp->base_fsp->fsp_name. o Isaac Boukris <iboukris at gmail.com> * BUG 13571: CVE-2018-16853: Fix S4U2Self crash with MIT KDC build. o Günther Deschner <gd at samba.org> * BUG 13708: s3-vfs: Prevent NULL pointer dereference in vfs_glusterfs. o Joe Guo <joeg at catalyst.net.nz> * PEP8: fix...

...ignore system acls", > false); > - TALLOC_CTX *frame = talloc_stackframe(); > + char *sys_acl_blob_description = NULL; > + DATA_BLOB sys_acl_blob = { 0 }; > + bool psd_is_from_fs = false; > > if (fsp && smb_fname_in == NULL) { > smb_fname = fsp->fsp_name; > @@ -505,11 +508,10 @@ static NTSTATUS get_nt_acl_internal(vfs_handle_struct *handle, > > DEBUG(10, ("get_nt_acl_internal: name=%s\n", smb_fname->base_name)); > > - status = get_acl_blob(frame, handle, fsp, smb_fname, &blob); > + status = get_acl_blob(mem_...

On Fri, Aug 26, 2016 at 04:03:49PM -0700, Jeremy Allison wrote: > On Fri, Aug 26, 2016 at 02:46:19PM -0700, Jeremy Allison via samba wrote: > > On Fri, Aug 26, 2016 at 06:44:05PM +0200, Ralph Böhme wrote: > > > > > > Cheerio! > > > -slow > > > > Still reviewing this - but a few things that will need changing: > > > > When adding the

...fail here if it's access denied, as that's the only error we care about for "can we delete this ?" questions. */ if (!NT_STATUS_IS_OK(status) && (NT_STATUS_EQUAL(status,NT_STATUS_ACCESS_DENIED) || @@ -1888,8 +1888,14 @@ status = rename_internals(conn, fsp->fsp_name, new_name, 0, replace_if_exists, path_contains_wcard); - if (!NT_STATUS_IS_OK(status)) + + if (!NT_STATUS_IS_OK(status)) { + if (open_was_deferred(SVAL(inbuf,smb_mid))) { + /* We have re-scheduled this call. */ + return -1; + } return ERROR_NT(status); + } /* * Rename was suc...

...fail here if it's access denied, as that's the only error we care about for "can we delete this ?" questions. */ if (!NT_STATUS_IS_OK(status) && (NT_STATUS_EQUAL(status,NT_STATUS_ACCESS_DENIED) || @@ -1888,8 +1888,14 @@ status = rename_internals(conn, fsp->fsp_name, new_name, 0, replace_if_exists, path_contains_wcard); - if (!NT_STATUS_IS_OK(status)) + + if (!NT_STATUS_IS_OK(status)) { + if (open_was_deferred(SVAL(inbuf,smb_mid))) { + /* We have re-scheduled this call. */ + return -1; + } return ERROR_NT(status); + } /* * Rename was suc...