search for: free_page_report_s_don

...00, David Hildenbrand wrote: >> > What do you call "hinting ends" though? The fact we put >>> a page in the VQ is not a guarantee that it's been consumed >>> by the hypervisor. >>> >> >> I'd say hinting ends once the hypervisor sets FREE_PAGE_REPORT_S_DONE. > > Can't find that one anywhere. what did I miss? Sorry, the QEMU implementation is confusing. FREE_PAGE_REPORT_S_DONE is translated to VIRTIO_BALLOON_CMD_ID_DONE QEMU: hw/virtio/virtio-balloon.c:virtio_balloon_free_page_report_notify() -> virtio_balloon_free_page_done(dev) -&gt...

...gt; What do you call "hinting ends" though? The fact we put >>>>> a page in the VQ is not a guarantee that it's been consumed >>>>> by the hypervisor. >>>>> >>>> >>>> I'd say hinting ends once the hypervisor sets FREE_PAGE_REPORT_S_DONE. >>> >>> Can't find that one anywhere. what did I miss? >> >> Sorry, the QEMU implementation is confusing. FREE_PAGE_REPORT_S_DONE is >> translated to VIRTIO_BALLOON_CMD_ID_DONE > > Well VIRTIO_BALLOON_CMD_ID_DONE just means "don't give me an...

...gt; >> > What do you call "hinting ends" though? The fact we put > >>> a page in the VQ is not a guarantee that it's been consumed > >>> by the hypervisor. > >>> > >> > >> I'd say hinting ends once the hypervisor sets FREE_PAGE_REPORT_S_DONE. > > > > Can't find that one anywhere. what did I miss? > > Sorry, the QEMU implementation is confusing. FREE_PAGE_REPORT_S_DONE is > translated to VIRTIO_BALLOON_CMD_ID_DONE Well VIRTIO_BALLOON_CMD_ID_DONE just means "don't give me any more hints, I finished m...

> What do you call "hinting ends" though? The fact we put > a page in the VQ is not a guarantee that it's been consumed > by the hypervisor. > I'd say hinting ends once the hypervisor sets FREE_PAGE_REPORT_S_DONE. > > I think a strict definition is this: > - hint includes a command ID > - hint implies "page was unused at some point after guest reading command ID" > > > Hypervisor can use dirty tracking tricks to get from that to > "page is unused at the moment&quo...

...t;hinting ends" though? The fact we put > >>>>> a page in the VQ is not a guarantee that it's been consumed > >>>>> by the hypervisor. > >>>>> > >>>> > >>>> I'd say hinting ends once the hypervisor sets FREE_PAGE_REPORT_S_DONE. > >>> > >>> Can't find that one anywhere. what did I miss? > >> > >> Sorry, the QEMU implementation is confusing. FREE_PAGE_REPORT_S_DONE is > >> translated to VIRTIO_BALLOON_CMD_ID_DONE > > > > Well VIRTIO_BALLOON_CMD_ID_DONE ju...

...ldenbrand <david at redhat.com> wrote: > > > What do you call "hinting ends" though? The fact we put > > a page in the VQ is not a guarantee that it's been consumed > > by the hypervisor. > > > > I'd say hinting ends once the hypervisor sets FREE_PAGE_REPORT_S_DONE. The key bit to this is that there are 4 states, and quasi unlimited command IDs, although I believe the first 2 are matched up to the states. So the VIRTIO_BALLOON_CMD_ID_DONE is matched up with FREE_PAGE_REPORT_S_DONE, and CMD_ID_STOP with S_STOP, but really all it means is that we are done wit...

...0 at 12:09:38PM +0200, David Hildenbrand wrote: > > What do you call "hinting ends" though? The fact we put > > a page in the VQ is not a guarantee that it's been consumed > > by the hypervisor. > > > > I'd say hinting ends once the hypervisor sets FREE_PAGE_REPORT_S_DONE. Can't find that one anywhere. what did I miss? > > > > I think a strict definition is this: > > - hint includes a command ID > > - hint implies "page was unused at some point after guest reading command ID" > > > > > > Hypervisor can...

>>> I'll need to think about this. >>> We need to remember that the whole HINT thing is not a mandate for host to >>> corrupt memory. It's just some info about page use guest >>> gives host. If host corrupts memory it's broken ... >> >> I don't think that's true, > > Do you refer to "If host corrupts memory it's