search for: free_bind

...status = uefi_call_wrapper(BS->OpenProtocol, 6, sb_handle, bguid, (void **)&sbp, image_handle, sb_handle, EFI_OPEN_PROTOCOL_GET_PROTOCOL); if (status == EFI_SUCCESS) { mnpsb_handle = sb_handle; break; } } } } if (status != EFI_SUCCESS) goto free_binding; child = NULL; status = uefi_call_wrapper(sbp->CreateChild, 2, sbp, (EFI_HANDLE *)&child); <<<< Potential crash here ! ... I think these changes would solve the thing. ... -EFI_SERVICE_BINDING *sbp; +EFI_SERVICE_BINDING *sbp =NULL; ... - if (status != EFI_SU...

>>> > I think these changes would solve the thing. > > ... > -EFI_SERVICE_BINDING *sbp; > +EFI_SERVICE_BINDING *sbp =NULL; > ... > > -? ? if (status != EFI_SUCCESS) > +? ? if (status != EFI_SUCCESS || sbp == NULL) >? ? ? ? goto free_binding; > ... The presumption was that we'd see an error rather than non-error from LibLocateHandle() when nr_handles is 0 and be guaranteed to find a matching handle.? Your additional measures seem the best choice. -- -Gene <<< OK I have adopted this code approach; testing it...

...> > >> > ... >> > -EFI_SERVICE_BINDING *sbp; >> > +EFI_SERVICE_BINDING *sbp =NULL; >> > ... >> > >> > - if (status != EFI_SUCCESS) >> > + if (status != EFI_SUCCESS || sbp == >> NULL) >> > goto free_binding; >> > ... >> >> The presumption was that we'd see an error rather than >> non-error from LibLocateHandle() when nr_handles is 0 and be guaranteed >> to find a >> matching handle. Your additional measures seem the best choice. >> -- >>...

...EFI_OPEN_PROTOCOL_GET_PROTOCOL); > if (status == EFI_SUCCESS) { > mnpsb_handle = sb_handle; > break; > } > } > > } > > } > if (status != EFI_SUCCESS) > goto free_binding; > > child = NULL; > > status = uefi_call_wrapper(sbp->CreateChild, 2, sbp, (EFI_HANDLE *)&child); <<<< Potential crash here ! > > ... > > > I think these changes would solve the thing. > > ... > -EFI_SERVICE_BINDING *sbp; > +EFI...

From: Sylvain Gault <sylvain.gault at gmail.com> I don't know if I should merge those trivial warning fix into one commit. I can reformat it as requested. Those are a few warning fixes for the efi part. The code involved has mainly been introduced in recent commits. Sylvain Gault (3): efi: fix warnings about argument types efi: fix pointer-type mismatch assigment warning efi: fix

...fi_call_wrapper(BS->OpenProtocol, 6, pxe_handle, > + bguid, (void **)&sbp, > + image_handle, pxe_handle, > + EFI_OPEN_PROTOCOL_GET_PROTOCOL); > if (status != EFI_SUCCESS) > goto free_binding; > > - for (i = 0; i < nr_handles; i++) { > - status = uefi_call_wrapper(BS->OpenProtocol, 6, handles[i], > - bguid, (void **)&sbp, > - image_handle, handles[i], > -...

On Wed, Jul 8, 2015 at 7:34 PM, Gene Cumm <gene.cumm at gmail.com> wrote: > What about the observed symptoms? Have you performed an inline packet Jeff, there's specific code that creates specific responses that if you had mentioned what you saw, I'd expect we could have seen something sooner. -- -Gene

...hese changes would solve the thing. > > > > ... > > -EFI_SERVICE_BINDING *sbp; > > +EFI_SERVICE_BINDING *sbp =NULL; > > ... > > > > - if (status != EFI_SUCCESS) > > + if (status != EFI_SUCCESS || sbp == > NULL) > > goto free_binding; > > ... > > The presumption was that we'd see an error rather than > non-error from LibLocateHandle() when nr_handles is 0 and be guaranteed to find a > matching handle. Your additional measures seem the best choice. > -- > -Gene > <<< > > OK...

...t;>> > -EFI_SERVICE_BINDING *sbp; >>> > +EFI_SERVICE_BINDING *sbp =NULL; >>> > ... >>> > >>> > - if (status != EFI_SUCCESS) >>> > + if (status != EFI_SUCCESS || sbp == >>> NULL) >>> > goto free_binding; >>> > ... >>> >>> The presumption was that we'd see an error rather than >>> non-error from LibLocateHandle() when nr_handles is 0 and be guaranteed >>> to find a >>> matching handle. Your additional measures seem the best choic...