search for: found_extended

.../ > + > + /* Find the extended partition in the primary partition table. */ > + for (i = 0; i < 4; ++i) { > + get_mbr_partition (mbr, i, &partition); > + if (partition.nr_sectors > 0 && > + is_extended (partition.part_type_byte)) { > + goto found_extended; > + } > + } > + nbdkit_error ("MBR logical partition selected, " > + "but there is no extended partition in the partition table"); > + return -1; ...this code, which returns the wrong error message (partition 3 is not logical, but the real p...

...} } + /* Logical partition. */ + + /* Find the extended partition in the primary partition table. */ + for (i = 0; i < 4; ++i) { + get_mbr_partition (mbr, i, &partition); + if (partition.nr_sectors > 0 && + is_extended (partition.part_type_byte)) { + goto found_extended; + } + } + nbdkit_error ("MBR logical partition selected, " + "but there is no extended partition in the partition table"); + return -1; + + found_extended: + ep_start_sector = partition.start_sector; + ep_nr_sectors = partition.nr_sectors; + ebr = ep_sta...

This is a revised version of the two series previously posted here: https://www.redhat.com/archives/libguestfs/2019-January/msg00137.html https://www.redhat.com/archives/libguestfs/2019-January/msg00139.html There have been many smaller changes but the highlights are: - Using SECTOR_SIZE instead of hard-coding 512 everywhere. - Additional safety checks that the EBR chain doesn't jump

I think this addresses everything in Eric's v2 review. Note that the first patch is best viewed using ‘-w’ to ignore whitespaces changes. Rich.

This implements support for MBR logical partitions in nbdkit-partition-filter, complementing existing support in the partitioning plugin. Rich.