search for: folio

On Thu, Jul 07, 2022 at 07:50:17PM -0700, Hugh Dickins wrote: > On Wed, 8 Jun 2022, Matthew Wilcox (Oracle) wrote: > > > Now that both callers have a folio, convert this function to > > take a folio & rename it. > > > > Signed-off-by: Matthew Wilcox (Oracle) <willy at infradead.org> > > Reviewed-by: Christoph Hellwig <hch at lst.de> > > --- > > mm/migrate.c | 19 ++++++++++++------- > > 1 fil...

On Thu, Jul 07, 2022 at 07:50:17PM -0700, Hugh Dickins wrote: > On Wed, 8 Jun 2022, Matthew Wilcox (Oracle) wrote: > > > Now that both callers have a folio, convert this function to > > take a folio & rename it. > > > > Signed-off-by: Matthew Wilcox (Oracle) <willy at infradead.org> > > Reviewed-by: Christoph Hellwig <hch at lst.de> > > --- > > mm/migrate.c | 19 ++++++++++++------- > > 1 fil...

Hi all, this series removes most users of the write_one_page API. These helpers internally call ->writepage which we are gradually removing from the kernel. Changes since v3: - drop all patches merged in v6.3-rc1 - re-add the jfs patch Changes since v2: - more minix error handling fixes Changes since v1: - drop the btrfs changes (queue up in the btrfs tree) - drop the finaly move to

...ndling code does not hold the PTL when taking the page lock. This means if there are multiple threads faulting concurrently on the device exclusive entry one will remove the entry whilst others will wait on the page lock without holding a reference. This can lead to threads locking or waiting on a folio with a zero refcount. Whilst mmap_lock prevents the pages getting freed via munmap() they may still be freed by a migration. This leads to warnings such as PAGE_FLAGS_CHECK_AT_FREE due to the page being locked when the refcount drops to zero. Fix this by trying to take a reference on the folio bef...

...+++------ 1 file changed, 4 insertions(+), 6 deletions(-) --- a/fs/buffer.c~fs-buffer-clean-up-block_commit_write +++ a/fs/buffer.c @@ -2180,8 +2180,7 @@ int __block_write_begin(struct page *pag } EXPORT_SYMBOL(__block_write_begin); -static int __block_commit_write(struct inode *inode, struct folio *folio, - size_t from, size_t to) +static int __block_commit_write(struct folio *folio, size_t from, size_t to) { size_t block_start, block_end; bool partial = false; @@ -2277,7 +2276,7 @@ int block_write_end(struct file *file, s flush_dcache_folio(folio); /* This could be a short (even...

...fer_head.h | 2 +- 5 files changed, 13 insertions(+), 23 deletions(-) --- a/fs/buffer.c~fs-convert-block_commit_write-to-return-void +++ a/fs/buffer.c @@ -2180,7 +2180,7 @@ int __block_write_begin(struct page *pag } EXPORT_SYMBOL(__block_write_begin); -static int __block_commit_write(struct folio *folio, size_t from, size_t to) +static void __block_commit_write(struct folio *folio, size_t from, size_t to) { size_t block_start, block_end; bool partial = false; @@ -2215,7 +2215,6 @@ static int __block_commit_write(struct f */ if (!partial) folio_mark_uptodate(folio); - return 0;...

On Tue, Mar 28, 2023 at 01:14:34PM +1100, Alistair Popple wrote: > +++ b/mm/memory.c > @@ -3623,8 +3623,19 @@ static vm_fault_t remove_device_exclusive_entry(struct vm_fault *vmf) > struct vm_area_struct *vma = vmf->vma; > struct mmu_notifier_range range; > > - if (!folio_lock_or_retry(folio, vma->vm_mm, vmf->flags)) > + /* > + * We need a page reference to lock the page because we don't > + * hold the PTL so a racing thread can remove the > + * device-exclusive entry and unmap the page. If the page is > + * free the entry must have been...

*** BLURB HERE *** Bean Huo (5): fs/buffer: clean up block_commit_write fs/buffer.c: convert block_commit_write to return void ext4: No need to check return value of block_commit_write() fs/ocfs2: No need to check return value of block_commit_write() udf: No need to check return value of block_commit_write() fs/buffer.c | 24 +++++++-----------------

...-) diff --git a/mm/memory.c b/mm/memory.c index 8c8420934d60..b499bd283d8e 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -3623,8 +3623,19 @@ static vm_fault_t remove_device_exclusive_entry(struct vm_fault *vmf) struct vm_area_struct *vma = vmf->vma; struct mmu_notifier_range range; - if (!folio_lock_or_retry(folio, vma->vm_mm, vmf->flags)) + /* + * We need a page reference to lock the page because we don't + * hold the PTL so a racing thread can remove the + * device-exclusive entry and unmap the page. If the page is + * free the entry must have been removed already. + */ +...

John Hubbard <jhubbard at nvidia.com> writes: > On 3/28/23 20:16, Matthew Wilcox wrote: > ... >>> + if (!get_page_unless_zero(vmf->page)) >>> + return 0; >> From a folio point of view: what the hell are you doing here? Tail >> pages don't have individual refcounts; all the refcounts are actually I had stuck with using the page because none of this stuff (yet) supports compound pages anyway so we shouldn't see a tail page anyway. But point taken, I a...

On 3/28/23 20:16, Matthew Wilcox wrote: ... >> + if (!get_page_unless_zero(vmf->page)) >> + return 0; > > From a folio point of view: what the hell are you doing here? Tail > pages don't have individual refcounts; all the refcounts are actually ohh, and I really should have caught that too. I plead spending too much time recently in a somewhat more driver-centric mindset, and failing to mentally shift gear...

...ies/clients/62/_thumbs/F11ADMIN01.GIF" style="position: relative;"> </div> </td> </tr> </tbody> </table> </div> Alternatively you can see the site here: http://www.folio11.co.uk/index.php?option=com_folio_dev&Itemid=23# (user demo, pw demo) Press login, then "your folio pages" - the problem occurs with the "my folio images" and "My folio pages" sections Does anyone know a work around for this? Many thanks in advance! Rob C

...Andrew Morton <akpm at linux-foundation.org> --- fs/buffer.c | 1 - 1 file changed, 1 deletion(-) --- a/fs/buffer.c~fs-buffer-clean-up-block_commit_write-fix +++ a/fs/buffer.c @@ -2252,7 +2252,6 @@ int block_write_end(struct file *file, s struct page *page, void *fsdata) { struct folio *folio = page_folio(page); - struct inode *inode = mapping->host; size_t start = pos - folio_pos(folio); if (unlikely(copied < len)) { _ Patches currently in -mm which might be from akpm at linux-foundation.org are mm-shmem-fix-race-in-shmem_undo_range-w-thp-fix.patch swap-stop-add-to...

...the rsync command completes without error messages. The process is repeatable, always choking on the bradley folder. After rsync completed without error messages, I compared the sizes of source and copy: matt$ du -k -d1 /Installers/Licensed\ Fonts/ 245196 /Installers/Licensed Fonts//Adobe Font Folio - OpenType Edition 51800 /Installers/Licensed Fonts//OpenType 256756 /Installers/Licensed Fonts//Postscript 43308 /Installers/Licensed Fonts//TrueType 598692 /Installers/Licensed Fonts/ matt$ du -k -d1 /Volumes/Storage/Licensed\ Fonts/ 245196 /Volumes/Storage/Licensed Fonts//Adobe Fo...

The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. ---------------------------------------------------------------------- Introduce i_blockmask() to simplify code, which replace (i_blocksize(node) - 1). Like done in commit 93407472a21b("fs: add i_blocksize()").

Introduce i_blockmask() to simplify code, which replace (i_blocksize(node) - 1). Like done in commit 93407472a21b("fs: add i_blocksize()"). Signed-off-by: Yangtao Li <frank.li at vivo.com> --- v4: -drop ext4 patch -erofs patch based on mainline -a bit change in ocfs2 patch include/linux/fs.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/linux/fs.h

....c > index 8c8420934d60..b499bd283d8e 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -3623,8 +3623,19 @@ static vm_fault_t remove_device_exclusive_entry(struct vm_fault *vmf) > struct vm_area_struct *vma = vmf->vma; > struct mmu_notifier_range range; > > - if (!folio_lock_or_retry(folio, vma->vm_mm, vmf->flags)) > + /* > + * We need a page reference to lock the page because we don't > + * hold the PTL so a racing thread can remove the > + * device-exclusive entry and unmap the page. If the page is > + * free the entry must have been...

...the rsync command completes without error messages. The process is repeatable, always choking on the bradley folder. After rsync completed without error messages, I compared the sizes of source and copy: matt$ du -k -d1 /Installers/Licensed\ Fonts/ 245196 /Installers/Licensed Fonts//Adobe Font Folio - OpenType Edition 51800 /Installers/Licensed Fonts//OpenType 256756 /Installers/Licensed Fonts//Postscript 43308 /Installers/Licensed Fonts//TrueType 598692 /Installers/Licensed Fonts/ matt$ du -k -d1 /Volumes/Storage/Licensed\ Fonts/ 245196 /Volumes/Storage/Licensed Fonts//Adobe Fo...

Hi, all. I'm intending to install CentOS 7 on a HP Elitebook 8460p. Does anybody have any experience of this? Many thanks for any help. Cheers, Phil...

...node, > for (i = 0; i < block_len_in_page; i++) { > *err = ext4_get_block(orig_inode, orig_blk_offset + i, bh, 0); > if (*err < 0) > - break; > + goto repair_branches; > bh = bh->b_this_page; > } > - if (!*err) > - *err = block_commit_write(&folio[0]->page, from, from + replaced_size); > > - if (unlikely(*err < 0)) > - goto repair_branches; > + block_commit_write(&folio[0]->page, from, from + replaced_size); > > /* Even in case of data=writeback it is reasonable to pin > * inode to transaction, to...