Displaying 3 results from an estimated 3 matches for "foldphi".
Did you mean:
fold_i
2017 Jan 31
0
Folding zext from i1 into PHI nodes with only zwo incoming values.
...tion in ShouldChangeType
>> because i1 is special. I tried the patch below, and it works on the
>> example...and nothing in 'make check' failed. :)
>>
>
> Yeah, that would work for me as well, I just wasn't sure about the
> implications that has. Simply making FoldPHIArgOpIntoPHI act like
> FoldPHIArgZextsIntoPHI seemed like the safer option to me, but I wanted
> feedback on it before creating a PR. Do you want to go ahead with that
> minimal approach and create a PR yourself?
>
Your idea probably has the minimal impact while still fixing your probl...
2017 Jan 31
1
Folding zext from i1 into PHI nodes with only zwo incoming values.
...>>> because i1 is special. I tried the patch below, and it works on the
>>> example...and nothing in 'make check' failed. :)
>>>
>>
>> Yeah, that would work for me as well, I just wasn't sure about the
>> implications that has. Simply making FoldPHIArgOpIntoPHI act like
>> FoldPHIArgZextsIntoPHI seemed like the safer option to me, but I wanted
>> feedback on it before creating a PR. Do you want to go ahead with that
>> minimal approach and create a PR yourself?
>>
>
> Your idea probably has the minimal impact whil...
2017 Jan 31
2
Folding zext from i1 into PHI nodes with only zwo incoming values.
...dea is to ease the restriction in ShouldChangeType
> because i1 is special. I tried the patch below, and it works on the
> example...and nothing in 'make check' failed. :)
>
Yeah, that would work for me as well, I just wasn't sure about the
implications that has. Simply making FoldPHIArgOpIntoPHI act like
FoldPHIArgZextsIntoPHI seemed like the safer option to me, but I wanted
feedback on it before creating a PR. Do you want to go ahead with that
minimal approach and create a PR yourself?
Björn
> Index: lib/Transforms/InstCombine/InstructionCombining.cpp
> ==============...