search for: foldopintophi

...wanted > feedback on it before creating a PR. Do you want to go ahead with that > minimal approach and create a PR yourself? > Your idea probably has the minimal impact while still fixing your problem case...although the relationships between FoldPHIArgOpIntoPHI / FoldPHIArgZextsIntoPHI / FoldOpIntoPhi are confusing. I think a patch for ShouldChangeType makes sense on its own (and makes any direct changes to the FoldPHI* functions unnecessary for your example). I'll try some more experiments with that patch to look for unintended consequences. When you say "PR", do you mean a bugz...

...before creating a PR. Do you want to go ahead with that >> minimal approach and create a PR yourself? >> > > Your idea probably has the minimal impact while still fixing your problem > case...although the relationships between FoldPHIArgOpIntoPHI / > FoldPHIArgZextsIntoPHI / FoldOpIntoPhi are confusing. > > I think a patch for ShouldChangeType makes sense on its own (and makes any > direct changes to the FoldPHI* functions unnecessary for your example). > I'll try some more experiments with that patch to look for unintended > consequences. > OK, I'll wait...

Hi Sanjay, 2017-01-30 22:22 GMT+01:00 Sanjay Patel <spatel at rotateright.com>: > My minimal patch idea is to ease the restriction in ShouldChangeType > because i1 is special. I tried the patch below, and it works on the > example...and nothing in 'make check' failed. :) > Yeah, that would work for me as well, I just wasn't sure about the implications that has.