search for: flush_write_file

...$ echo foo > in $ strace -f -o log rsync in /full/tmp $ grep 'write.*ENOSP' log 4787 write(1, "foo\n", 4) = -1 ENOSPC (No space left on device) $ rsync --version|head -n1 rsync version 2.6.3 protocol version 28 The cause seems to be this unchecked flush_write_file call: Index: receiver.c =================================================================== RCS file: /cvsroot/rsync/receiver.c,v retrieving revision 1.110 diff -u -p -r1.110 receiver.c --- receiver.c 27 Nov 2004 17:56:58 -0000 1.110 +++ receiver.c 2 Dec 2004 16:40:23 -0000 @@ -289,7 +289,8 @@ sta...

...$ echo foo > in $ strace -f -o log rsync in /full/tmp $ grep 'write.*ENOSP' log 4787 write(1, "foo\n", 4) = -1 ENOSPC (No space left on device) $ rsync --version|head -n1 rsync version 2.6.3 protocol version 28 The cause seems to be this unchecked flush_write_file call: Index: receiver.c =================================================================== RCS file: /cvsroot/rsync/receiver.c,v retrieving revision 1.110 diff -u -p -r1.110 receiver.c --- receiver.c 27 Nov 2004 17:56:58 -0000 1.110 +++ receiver.c 2 Dec 2004 16:40:23 -0000 @@ -289,7 +289,8 @@ sta...

...; write_file(fd,map,len) != (int) len) { + rprintf(FERROR, "write failed on %s: %s\n", + full_fname(fname), strerror(errno)); + exit_cleanup(RERR_FILEIO); + } + } else { + flush_write_file(fd); + if (do_lseek(fd,(OFF_T)len,SEEK_CUR) != (offset+len)) { + rprintf(FERROR, "lseek failed on %s: %s, %lli, %lli, %i\n", + full_fname(fname), strerror(errno), do_lseek(fd,0,SEEK_CUR), (offset+len), i); +...

...ets the timestamp to 0 when a file transfer is interrupted, which was suggested by the bug reporter and sounds sensible to me. Any possible hidden gotcha's? Paul --- a/cleanup.c 2012-04-15 14:14:02.913993934 +0200 +++ b/cleanup.c 2012-04-15 14:13:58.834033097 +0200 @@ -157,8 +157,9 @@ flush_write_file(cleanup_fd_w); close(cleanup_fd_w); } + cleanup_file->modtime = 0; /* solves problem with --partial --update */ finish_transfer(cleanup_new_fname, fname, NULL, NULL, - cleanup_file, 0, !partial_dir); + cleanup_file, 1, !partial_dir); } /* FALLTHROUGH */ On Sun 01...

https://bugzilla.samba.org/show_bug.cgi?id=5695 Summary: rsync local timeout Product: rsync Version: 3.0.3 Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P3 Component: core AssignedTo: wayned@samba.org ReportedBy: gabriele.tozzi@gmail.com QAContact: