Displaying 19 results from an estimated 19 matches for "float_dst".
Did you mean:
float_data
2017 Nov 20
2
[PATCH] Fix memory issue in Projection API
Hello,
Attached is a patch to resolve a memory issue using the Projection API when
compiling using a psuedo-stack / limited memory.
Please let me any ?s you might have.
Cheers,
Drew
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.xiph.org/pipermail/opus/attachments/20171120/84e36e1b/attachment-0001.html>
-------------- next part --------------
2017 Nov 22
2
[PATCH] Fix memory issue in Projection API
...same mistake elsewhere.
>
> 3) In opus_projection_copy_channel_out_float() and
> opus_projection_copy_channel_out_short(), you're zeroing the values with
> this loop:
> for (i=0;i<frame_size;i++)
> {
> for (j=0;j<dst_stride;j++)
> {
> float_dst[i*dst_stride+j] = 0;
> }
> }
> That looks wrong, since you'll be overwriting all channels instead of
> just the one you're copying. That should have come up in testing, no?
>
> 4) You might want to have a look at
> mapping_matrix_multiply_channel_out_short()....
2017 Nov 23
2
[PATCH] Fix memory issue in Projection API
..._out_float() and
> > opus_projection_copy_channel_out_short(), you're zeroing the values
> with
> > this loop:
> > for (i=0;i<frame_size;i++)
> > {
> > for (j=0;j<dst_stride;j++)
> > {
> > float_dst[i*dst_stride+j] = 0;
> > }
> > }
> > That looks wrong, since you'll be overwriting all channels instead of
> > just the one you're copying. That should have come up in testing, no?
> >
> > 4) You might want to have a look at...
2017 Nov 23
2
[PATCH] Fix memory issue in Projection API
..._short(), you're zeroing the
> > values with
> > > this loop:
> > > for (i=0;i<frame_size;i++)
> > > {
> > > for (j=0;j<dst_stride;j++)
> > > {
> > > float_dst[i*dst_stride+j] = 0;
> > > }
> > > }
> > > That looks wrong, since you'll be overwriting all channels
> > instead of
> > > just the one you're copying. That should have come up in
> > testing,...
2017 Nov 24
3
[PATCH] Fix memory issue in Projection API
...with
> > > > this loop:
> > > > for (i=0;i<frame_size;i++)
> > > > {
> > > > for (j=0;j<dst_stride;j++)
> > > > {
> > > > float_dst[i*dst_stride+j] = 0;
> > > > }
> > > > }
> > > > That looks wrong, since you'll be overwriting all
> channels
> > > instead of
> > > > just the one you're copying. T...
2017 Nov 22
0
[PATCH] Fix memory issue in Projection API
...1).
Please check you haven't made that same mistake elsewhere.
3) In opus_projection_copy_channel_out_float() and
opus_projection_copy_channel_out_short(), you're zeroing the values with
this loop:
for (i=0;i<frame_size;i++)
{
for (j=0;j<dst_stride;j++)
{
float_dst[i*dst_stride+j] = 0;
}
}
That looks wrong, since you'll be overwriting all channels instead of
just the one you're copying. That should have come up in testing, no?
4) You might want to have a look at
mapping_matrix_multiply_channel_out_short(). I can't quite follow what
it...
2017 Nov 23
0
[PATCH] Fix memory issue in Projection API
...; 3) In opus_projection_copy_channel_out_float() and
> opus_projection_copy_channel_out_short(), you're zeroing the values with
> this loop:
> for (i=0;i<frame_size;i++)
> {
> for (j=0;j<dst_stride;j++)
> {
> float_dst[i*dst_stride+j] = 0;
> }
> }
> That looks wrong, since you'll be overwriting all channels instead of
> just the one you're copying. That should have come up in testing, no?
>
> 4) You might want to have a look at
> mapping_matrix_multi...
2017 Dec 04
3
[PATCH] Fix memory issue in Projection API
...p:
> > > > > for (i=0;i<frame_size;i++)
> > > > > {
> > > > > for (j=0;j<dst_stride;j++)
> > > > > {
> > > > > float_dst[i*dst_stride+j] = 0;
> > > > > }
> > > > > }
> > > > > That looks wrong, since you'll be overwriting all
> > channels
> > > > instead of
> > >...
2017 Nov 24
2
[PATCH] Fix memory issue in Projection API
...p:
> > > > > for (i=0;i<frame_size;i++)
> > > > > {
> > > > > for (j=0;j<dst_stride;j++)
> > > > > {
> > > > > float_dst[i*dst_stride+j] = 0;
> > > > > }
> > > > > }
> > > > > That looks wrong, since you'll be overwriting all
> > channels
> > > > instead of
> > >...
2017 Nov 23
0
[PATCH] Fix memory issue in Projection API
... opus_projection_copy_channel_out_short(), you're zeroing the
> values with
> > this loop:
> > for (i=0;i<frame_size;i++)
> > {
> > for (j=0;j<dst_stride;j++)
> > {
> > float_dst[i*dst_stride+j] = 0;
> > }
> > }
> > That looks wrong, since you'll be overwriting all channels
> instead of
> > just the one you're copying. That should have come up in
> testing, no?
> >
> >...
2017 Nov 23
0
[PATCH] Fix memory issue in Projection API
...the
> > values with
> > > this loop:
> > > for (i=0;i<frame_size;i++)
> > > {
> > > for (j=0;j<dst_stride;j++)
> > > {
> > > float_dst[i*dst_stride+j] = 0;
> > > }
> > > }
> > > That looks wrong, since you'll be overwriting all channels
> > instead of
> > > just the one you're copying. That should have come up in
>...
2017 Nov 24
0
[PATCH] Fix memory issue in Projection API
...gt; > this loop:
> > > > for (i=0;i<frame_size;i++)
> > > > {
> > > > for (j=0;j<dst_stride;j++)
> > > > {
> > > > float_dst[i*dst_stride+j] = 0;
> > > > }
> > > > }
> > > > That looks wrong, since you'll be overwriting all
> channels
> > > instead of
> > > > just the o...
2017 Nov 28
2
[PATCH] Fix memory issue in Projection API
... > for (i=0;i<frame_size;i++)
> > > > > {
> > > > > for (j=0;j<dst_stride;j++)
> > > > > {
> > > > > float_dst[i*dst_stride+j] = 0;
> > > > > }
> > > > > }
> > > > > That looks wrong, since you'll be
> overwriting all
> > channels
> > ...
2017 Nov 27
0
[PATCH] Fix memory issue in Projection API
...> > > for (i=0;i<frame_size;i++)
>> > > > > {
>> > > > > for (j=0;j<dst_stride;j++)
>> > > > > {
>> > > > > float_dst[i*dst_stride+j] = 0;
>> > > > > }
>> > > > > }
>> > > > > That looks wrong, since you'll be overwriting all
>> > channels
>> > > > instead of
&...
2017 Dec 07
0
[PATCH] Fix memory issue in Projection API
... > > > for (i=0;i<frame_size;i++)
> > > > > {
> > > > > for (j=0;j<dst_stride;j++)
> > > > > {
> > > > > float_dst[i*dst_stride+j] = 0;
> > > > > }
> > > > > }
> > > > > That looks wrong, since you'll be
> overwriting all
> > channels
> > > > ins...
2017 Nov 28
0
[PATCH] Fix memory issue in Projection API
...(i=0;i<frame_size;i++)
> > > > > > {
> > > > > > for (j=0;j<dst_stride;j++)
> > > > > > {
> > > > > > float_dst[i*dst_stride+j] = 0;
> > > > > > }
> > > > > > }
> > > > > > That looks wrong, since you'll be
> > overwriting all
> > > cha...
2017 Nov 28
3
[PATCH] Fix memory issue in Projection API
...size;i++)
> > > > > > {
> > > > > > for (j=0;j<dst_stride;j++)
> > > > > > {
> > > > > > float_dst[i*dst_stride+j] = 0;
> > > > > > }
> > > > > > }
> > > > > > That looks wrong, since you'll be
> > overwriting all
> > ...
2017 Nov 29
0
Antw: Re: [PATCH] Fix memory issue in Projection API
...t; > > > > > {
>> > > > > > for (j=0;j<dst_stride;j++)
>> > > > > > {
>> > > > > > float_dst[i*dst_stride+j] = 0;
>> > > > > > }
>> > > > > > }
>> > > > > > That looks wrong, since you'll be
>> > overwriting al...
2017 Nov 30
0
Antw: Re: [PATCH] Fix memory issue in Projection API
... {
> >>> > > > > > for
> (j=0;j<dst_stride;j++)
> >>> > > > > > {
> >>> > > > > >
> float_dst[i*dst_stride+j] = 0;
> >>> > > > > > }
> >>> > > > > > }
> >>> > > > > > That looks wrong, since
> you...