search for: float_cast

--- celt/float_cast.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/celt/float_cast.h b/celt/float_cast.h index ede6574..4892e2c 100644 --- a/celt/float_cast.h +++ b/celt/float_cast.h @@ -90,14 +90,14 @@ #include <math.h> #define float2int(x) lrint(x) -#elif (defined(_MSC_VER) &...

...to this ML that fixed these a few months ago but it was forgotten/ignored. Hopefully the issue gets addressed this time. Cameron On Nov 6, 2014 9:53 AM, "Martin Storsj?" <martin at martin.st> wrote: > On Thu, 6 Nov 2014, Hugo Beauz?e-Luyssen wrote: > > --- >> celt/float_cast.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/celt/float_cast.h b/celt/float_cast.h >> index ede6574..4892e2c 100644 >> --- a/celt/float_cast.h >> +++ b/celt/float_cast.h >> @@ -90,14 +90,14 @@ >> #include <math.h...

...; > Best, > Tristan > > > > > Cameron > > > > On Nov 6, 2014 9:53 AM, "Martin Storsj?" <martin at martin.st> wrote: > >> > >> On Thu, 6 Nov 2014, Hugo Beauz?e-Luyssen wrote: > >> > >>> --- > >>> celt/float_cast.h | 4 ++-- > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/celt/float_cast.h b/celt/float_cast.h > >>> index ede6574..4892e2c 100644 > >>> --- a/celt/float_cast.h > >>> +++ b/celt/float_cast.h &gt...

On Thu, 6 Nov 2014, Hugo Beauz?e-Luyssen wrote: > --- > celt/float_cast.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/celt/float_cast.h b/celt/float_cast.h > index ede6574..4892e2c 100644 > --- a/celt/float_cast.h > +++ b/celt/float_cast.h > @@ -90,14 +90,14 @@ > #include <math.h> > #define float2int(x) l...

...pipermail/opus/attachments/20140406/e19d33cd/attachment.obj Best, Tristan > > Cameron > > On Nov 6, 2014 9:53 AM, "Martin Storsj?" <martin at martin.st> wrote: >> >> On Thu, 6 Nov 2014, Hugo Beauz?e-Luyssen wrote: >> >>> --- >>> celt/float_cast.h | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/celt/float_cast.h b/celt/float_cast.h >>> index ede6574..4892e2c 100644 >>> --- a/celt/float_cast.h >>> +++ b/celt/float_cast.h >>> @@ -90,14 +90,14 @@...

...> > On Nov 6, 2014 9:53 AM, "Martin Storsj?" <martin at martin.st > <mailto:martin at martin.st>> wrote: > >> > >> On Thu, 6 Nov 2014, Hugo Beauz?e-Luyssen wrote: > >> > >>> --- > >>> celt/float_cast.h | 4 ++-- > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/celt/float_cast.h b/celt/float_cast.h > >>> index ede6574..4892e2c 100644 > >>> --- a/celt/float_cast.h > >>> +++...

...opus-request at xiph.org You can reach the person managing the list at opus-owner at xiph.org When replying, please edit your Subject line so it is more specific than "Re: Contents of opus digest..." Today's Topics: 1. Re: opus Digest, Vol 70, Issue 1 (Heng Lou) 2. [PATCH] float_cast: Fix MSVC ARM build (Hugo Beauz?e-Luyssen) 3. Re: [PATCH] float_cast: Fix MSVC ARM build (Martin Storsj?) ---------------------------------------------------------------------- Message: 1 Date: Wed, 5 Nov 2014 20:19:04 +0000 From: Heng Lou <Heng_Lou at starkey.com> Subject: Re: [opus] o...

Hi Jean-Marc, I've been compiling CELT for 64-bit Windows and it all seems to work fine (with the occasional benign warning message) except for one place, and that is in "float_cast.h" where there is some inline assembly language that gets complied for Windows. Since the Microsoft 64-bit compiler won't allow inline assembly language (and *still* doesn't have "lrintf"), I suggest the following change to use intrinsics for the 64-bit compiler: --- f...

On Thu, 6 Nov 2014, Jean-Marc Valin wrote: > Is there any consensus on what's the correct fix here? Cameron's fix looks correct to me (I didn't read the code closely enough in my first comment). // Martin

On 11/06/2014 10:55 PM, Martin Storsj? wrote: > On Thu, 6 Nov 2014, Jean-Marc Valin wrote: > >> Is there any consensus on what's the correct fix here? > > Cameron's fix looks correct to me (I didn't read the code closely enough > in my first comment). > > // Martin > _______________________________________________ > opus mailing list > opus at

On Mon, 10 Nov 2014, Hugo Beauzee-Luyssen wrote: > On 11/06/2014 10:55 PM, Martin Storsj? wrote: >> On Thu, 6 Nov 2014, Jean-Marc Valin wrote: >> >>> Is there any consensus on what's the correct fix here? >> >> Cameron's fix looks correct to me (I didn't read the code closely enough >> in my first comment). >> > > That looks good

The following tiny patches make opus and opusfile to use xmm intrinsics for lrintf() with mingw-w64 builds when targetting x64 instead of their default x87 asm. Regards. -- O.S. diff --git a/celt/float_cast.h b/celt/float_cast.h index ed5a39b..b9b8484 100644 --- a/celt/float_cast.h +++ b/celt/float_cast.h @@ -61,7 +61,14 @@ ** the config.h file. */ -#if (HAVE_LRINTF) +#if (defined(__GNUC__) && defined(_WIN64)) + #include <xmmintrin.h> + static __inline long int floa...

...ble-asm, --disable-intrinsics, --with-NE10, and rare options like --disable-rfc8251, --disable-hardening, --enable-fixed-point-debug, --enable-float-approx, --enable-fuzzing, and --enable-check-asm. I tried a cmake build on a non-x86 Linux host but encountered numerous warnings of the form: celt/float_cast.h:129:10: warning: #warning "Don't have the functions lrint() and lrintf ()." [-Wcpp] celt/float_cast.h:130:10: warning: #warning "Replacing these functions with a standard C cast." [-Wcpp] The host does have both the lrint and lrintf functions; the problem is that cmake...

...@CELT_LT_CURRENT@:@CELT_LT_REVISION@:@CELT_LT_AGE@ +libcelt at LIBCELT_SUFFIX@_la_LDFLAGS = -version-info @CELT_LT_CURRENT@:@CELT_LT_REVISION@:@CELT_LT_AGE@ noinst_HEADERS = _kiss_fft_guts.h arch.h bands.h fixed_c5x.h fixed_c6x.h \ cwrs.h ecintrin.h entcode.h entdec.h entenc.h fixed_generic.h float_cast.h \ @@ -31,9 +31,9 @@ noinst_HEADERS = _kiss_fft_guts.h arch.h bands.h fixed_c5x.h fixed_c6x.h \ noinst_PROGRAMS = testcelt dump_modes testcelt_SOURCES = testcelt.c -testcelt_LDADD = libcelt.la +testcelt_LDADD = libcelt at LIBCELT_SUFFIX@.la INCLUDES = -#libcelt_la_LIBADD = +#libcelt at LIBC...

On Wed, Apr 10, 2019 at 5:30 PM Marcus Asteborg <xnorpx at outlook.com> wrote: > Hi Mark, > > Thanks for the feedback. > > By default CMake is building the static library in debug, to get other > things one has to explicit turn it on. > > Hi, By default CMake uses the "empty" build, which is used in combination with the environment variables CFLAGS and

...hing I found was ntohl() which appears to be a > function call Avoid that like the plague. > 2nd, I need an equivalent for lround() (or round() is ok), which > is not in MSVC6's math.h or anywhere else I could find. The operation of lround() is basically the same as lrint(). In src/float_cast.h I have: __inline long int lrint (double flt) { int intgr ; _asm { fld flt fistp intgr } ; return intgr ; } __inline long int lrintf (float flt) { int intgr ; _asm { fld flt fistp intgr } ; return intgr ; } Hope this helps, Erik -- +-----------------------...

I?ve been working on a Windows Phone 8 app that uses libopus for audio decoding. I used the included MSVC project files by switching the toolchain to WP8?s. I ran into a compilation issue in float_cast.h where it was trying to use the MSVC x86 code path (with x86 assembly). This was because WIN32 and _WIN32 are defined in ARM projects for WP8 libraries (for source compatibility reasons I assume). I?ve attached a patch which changes WIN32/_WIN32 and WIN64/_WIN64 to the proper architecture-specific...

for recent code changes I find myself needing some workarounds for MSVC6: 1st, I need a fast way to swap bytes (for endianness) of a 32-bit int. I could not find a builtin like bswap; the closest thing I found was ntohl() which appears to be a function call and also requires linking with winsock2 (ws2_32.lib) to get it. 2nd, I need an equivalent for lround() (or round() is ok), which is not in

.../* O index of best codebook vector */ diff -Naupr opus-1.3.1-vanilla/src/analysis.c opus-1.3.1/src/analysis.c --- opus-1.3.1-vanilla/src/analysis.c 2019-02-26 06:04:23 +0800 +++ opus-1.3.1/src/analysis.c 2019-05-27 17:19:28 +0800 @@ -45,7 +45,7 @@ #include "float_cast.h" #ifndef M_PI -#define M_PI 3.141592653 +#define M_PI 3.14159265358979f #endif #ifndef DISABLE_FLOAT_API @@ -675,7 +675,7 @@ static void tonality_analysis(TonalityAn tonal->logE[tonal->E_count][b] = logE[b]; if (tonal->count==0) tonal->highE[b] =...

...c rangedec.c rangeenc.c rate.c \ vq.c #noinst_HEADERS = @@ -26,8 +26,8 @@ libcelt_la_LDFLAGS = -version-info @CELT_LT_CURRENT@:@CELT_LT_REVISION@:@CELT_LT noinst_HEADERS = _kiss_fft_guts.h arch.h bands.h fixed_c5x.h fixed_c6x.h \ cwrs.h ecintrin.h entcode.h entdec.h entenc.h fixed_generic.h float_cast.h \ kfft_double.h kfft_single.h kiss_fft.h kiss_fftr.h laplace.h mdct.h mfrngcod.h \ - mathops.h modes.h os_support.h pgain_table.h pitch.h psy.h \ - quant_bands.h quant_pitch.h rate.h stack_alloc.h vq.h + mathops.h modes.h os_support.h pitch.h psy.h \ + quant_bands.h rate.h stack_alloc.h vq.h...