search for: flac_xmms__init

There are problems in the configure option handling code for http streaming that was added to the XMMS plugin for 1.1.2. In configure.c, flac_cfg.stream.proxy_host and other pointers to strings are initialized with pointers to an empty string "". Subsequent code in FLAC_XMMS__init() and flac_configurewin_ok() passes these pointers to g_free(). Since they don't point to memory that was ever allocated through malloc(), what happens next is undefined. I guess on the author's system free() silently copes. With some malloc debugging (malloc.conf -> A on BSD systems)...

...show_version(void) { printf("metaflac %s\n", FLAC__VERSION_STRING); } --- src/plugin_xmms/plugin.c-dist 2005-05-25 16:25:03.000000000 +0200 +++ src/plugin_xmms/plugin.c 2005-05-25 16:25:34.000000000 +0200 @@ -109,14 +109,14 @@ typedef enum { DECODER_HTTP } decoder_t; -static void FLAC_XMMS__init(); +static void FLAC_XMMS__init(void); static int FLAC_XMMS__is_our_file(char *filename); static void FLAC_XMMS__play_file(char *filename); -static void FLAC_XMMS__stop(); +static void FLAC_XMMS__stop(void); static void FLAC_XMMS__pause(short p); static void FLAC_XMMS__seek(int time); -static...

...decoder); + FLAC__bool (*process_until_end_of_metadata) (void *decoder); + FLAC__bool (*process_single) (void *decoder); + FLAC__bool (*is_eof) (void *decoder); + } decoder_funcs_t; + + #define NUM_DECODER_TYPES 2 + typedef enum { + DECODER_FILE, + DECODER_HTTP + } decoder_t; + static void FLAC_XMMS__init(); static int FLAC_XMMS__is_our_file(char *filename); static void FLAC_XMMS__play_file(char *filename); *************** *** 79,90 **** static void FLAC_XMMS__get_song_info(char *filename, char **title, int *length); static void *play_loop_(void *arg); ! static FLAC__bool safe_decoder_in...