search for: flac_utime

Some libcs like uClibc-ng can optionally disable deprecated functions. utime is one of them. When done so, both the header and the function go missing. This fixes flac_utime to work in such a situation. --- include/share/compat.h | 10 +++++++++- src/libFLAC/metadata_iterators.c | 9 +++++++-- src/share/grabbag/file.c | 9 +++++++-- 3 files changed, 23 insertions(+), 5 deletions(-) diff --git a/include/share/compat.h b/include/share/compat.h index...

On 18.3.2013 12:25, Erik de Castro Lopo wrote: > JonY wrote: > >> Before anyone does anything, see __wgetmainargs >> <http://msdn.microsoft.com/en-us/library/ff770599.aspx>. >> >> It can expand wildcards. Since it already provides argc/argv/env, it is >> more a less a drop-in replacement for the main() arguments. > +1 > > Erik Alright, here's

...printf_utf8 +#define flac_fopen fopen_utf8 +#define flac_stat _stat64_utf8 ... I leave this up for Erik to decide, though I would have preferred not using rename macros at all. Not sure if these were intended: +#include <sys/stat.h> /* for flac_stat() */ +#include <sys/utime.h> /* for flac_utime() */ +#include <io.h> /* for flac_chmod() */ As for calling __wgetmainargs, I have some concerns about the security implications: LoadLibrary("msvcrt.dll") <- Which msvcrt? Theoretical security exploit. I think it is best to link it directly, please use the following prototype...

...ction `init_file_internal_': flac/src/libFLAC/stream_decoder.c:609: undefined reference to `fopen_utf8' flac/src/libFLAC/stream_decoder.c:609: undefined reference to `fopen_utf8' include/share/compat.h, #ifdef _WIN32: #define flac_fopen fopen_utf8 #define flac_chmod chmod_utf8 #define flac_utime utime_utf8 #define flac_unlink unlink_utf8 #define flac_rename rename_utf8 #define flac_stat _stat64_utf8 The members of the libFLAC API that result in calls to these functions include FLAC__stream_decoder_init_file, FLAC__stream_decoder_init_ogg_file, and a variety of metadata functions. These fu...

...g rename macros at all. I think this is the sanest way. Only few #ifdefs instead of wrapper functions filled with them that do essentially nothing on *nix. > > Not sure if these were intended: > +#include <sys/stat.h> /* for flac_stat() */ > +#include <sys/utime.h> /* for flac_utime() */ > +#include <io.h> /* for flac_chmod() */ Nope. Bug from mass replace. > > As for calling __wgetmainargs, I have some concerns about the security > implications: > LoadLibrary("msvcrt.dll") <- Which msvcrt? Theoretical security exploit. There is msvcrt.dll...

lvqcl wrote: >>> Win_utf8 stuff should not be included in libflac since it's only to be >>> used by the flac.exe frontend. It is not needed by other programs nor >>> would they benefit from it without doing the extra work of converting >>> their ansi filenames and functions to utf-8. >>> >>>> Version 2 of my patch attached, which fixes