search for: flac_configurewin_ok

There are problems in the configure option handling code for http streaming that was added to the XMMS plugin for 1.1.2. In configure.c, flac_cfg.stream.proxy_host and other pointers to strings are initialized with pointers to an empty string "". Subsequent code in FLAC_XMMS__init() and flac_configurewin_ok() passes these pointers to g_free(). Since they don't point to memory that was ever allocated through malloc(), what happens next is undefined. I guess on the author's system free() silently copes. With some malloc debugging (malloc.conf -> A on BSD systems), free() will abort(). I t...

...FLAC_ICECAST + static GtkWidget *streaming_cast_title, *streaming_udp_title; + #endif + static GtkWidget *streaming_proxy_hbox, *streaming_proxy_auth_hbox, *streaming_save_dirbrowser; + static GtkWidget *streaming_save_hbox; + static gchar *gtk_entry_get_text_1 (GtkWidget *widget); static void flac_configurewin_ok(GtkWidget * widget, gpointer data); static void configure_destroy(GtkWidget * w, gpointer data); *************** *** 129,134 **** --- 156,216 ---- xmms_cfg_write_boolean(cfg, "flac", "output.resolution.replaygain.dither", flac_cfg.output.resolution.replaygain.dither); xm...