search for: flac__utils_printf

Hi Josh, Here are all the patches that are currently applied to the Debian packages for flac. You may disagree with some of them but as the current maintainer, I'm submitting them all for your consideration. (I should've submitted them earlier, but I've been quite busy. Sorry!) Here is a listing of the patches that I'll be sending: Patch 1 fixes a simple typo in metaflac

...alt="Valid XHTML 1.0!" height="31" width="88" border="0" hspace="0" /></a> diff --git a/src/flac/main.c b/src/flac/main.c index d7f11dc..3cddc70 100644 --- a/src/flac/main.c +++ b/src/flac/main.c @@ -479,7 +479,7 @@ int do_it(void) } flac__utils_printf(stderr, 2, "\n"); - flac__utils_printf(stderr, 2, "flac %s, Copyright (C) 2000-2009, 2011-2013 Josh Coalson & Xiph.Org Foundation\n", FLAC__VERSION_STRING); + flac__utils_printf(stderr, 2, "flac %s, Copyright (C) 2000-2009, 2011-2014 Josh Coalson & Xiph.Org Founda...

...ced a wrong warning trying to encode a 24 bits WAV file if(wFormatTag == 1) { if(bps != 8 && bps != 16) { if(bps == 24 || bps == 32) { /* let these slide with a warning since they're unambiguous */ flac__utils_printf(stderr, 1, "%s: WARNING: legacy WAVE file has format type %u but bits-per-sample=%u\n", e->inbasefilename, (unsigned)wFormatTag, bps); AFAIK only 32bits file require a format of 3 while it's fine for 8, 16 and 24bits Thanks ! -- Olivier TRISTAN uvi.net

On Mar 17, 2013, at 03:57, LRN wrote: > /me looks at chmod and utime wrappers: > Ah, i knew i've missed something! :) > Also, i didn't consider wildcards (i thought shell was supposed to > handle them...). I believe that shell does handle wildcards on all Unix variants, including OSX. Since Windows does not handle them, I suggest that the main flac code not be littered

...> replacements of existing fopen() calls with flac_fopen() (similarly > for chmod and utime) and the main function for the flac and metaflac > executables will have an additional: > > #ifdef _WIN32 > if (!convert_argv_to_utf8(&argc, &argv)) > flac__utils_printf(stderr, 1, "ERROR: yada yada\n"); > #endif > > This is a small un-obtrusive change that I fully support. > > I would however like to see it sooner rather than later so we can get > this damn thing released :-). > > Erik > -- > ----------------------------...

...derSession_init_decoder(DecoderSession *decoder_session, const ch return true; } -FLAC__bool DecoderSession_process(DecoderSession *d) +FLAC__bool DecoderSession_process(DecoderSession *d, const char *outfilename) { if(!FLAC__stream_decoder_process_until_end_of_metadata(d->decoder)) { flac__utils_printf(stderr, 2, "\n"); @@ -366,6 +367,29 @@ FLAC__bool DecoderSession_process(DecoderSession *d) /* write the WAVE/AIFF headers if necessary */ if(!d->analysis_mode && !d->test_only && d->format != FORMAT_RAW) { +#ifdef _WIN32 + if(strcmp(outfilename, "-&qu...

...16:00:05 2007 @@ -413,7 +413,10 @@ * tags that we will set later, to avoid rewriting the * whole file. */ - if(option_values.padding <= 0) { + if(option_values.padding == -1) { + /* Leave it alone; use the default. */ + } + else if(option_values.padding <= 0) { flac__utils_printf(stderr, 1, "NOTE: --replay-gain may leave a small PADDING block even with --no-padding\n"); option_values.padding = GRABBAG__REPLAYGAIN_MAX_TAG_SPACE_REQUIRED; }

am a NEW user to flac.installed flac on eac.tried to rip a cd using eac with flac as external compression.tried the 'wav' icontried the 'mp3' iconboth options saves the file as 'wav'thought eac will rip the cd in the 'flac' file format.is this a 2-step procedure?wherein eac to 'wav' and re-ripped on flac frontend?or is there a ripper with flac in it that

...eed to be cleared. This way, those of us with long filenames or narrow terminals avoid getting the screen totally swamped. As far as I could tell from a five minute scan of the code, the encode function is used for checking also, so I think that the change only needs to be made once here?possibly flac__utils_printf might need a little change too? Thank you for the great programme. Nicholas PS. What exactly is the mechanism for removing lines of text already printed from stderr/stdout, using the printf-type functions?

Can you please wrap the setvbuf in _WIN32 IFDEFs too? Currently memory usage of FLAC decoding is about 1MB, so this patch is increasing memory usage tenfold, also for platforms that do not need this. It is a non-problem on my system anyway. Op 26-09-14 om 10:36 schreef Janne Hyv?rinen: > I made some changes to the previous patch. I don't know why I > originally didn't put the

Decoding flac files is also prone to producing fragmented files. NTFS has the ability to completely avoid fragmentation if it is told the file size before hand, but that would require using special Windows-only functions. Increasing the write buffer from the default 512 bytes to 10 MB already reduces the problem tremendously. -------------- next part -------------- diff --git

...derSession_init_decoder(DecoderSession *decoder_session, const ch return true; } -FLAC__bool DecoderSession_process(DecoderSession *d) +FLAC__bool DecoderSession_process(DecoderSession *d, const char *outfilename) { if(!FLAC__stream_decoder_process_until_end_of_metadata(d->decoder)) { flac__utils_printf(stderr, 2, "\n"); @@ -366,6 +366,28 @@ FLAC__bool DecoderSession_process(DecoderSession *d) /* write the WAVE/AIFF headers if necessary */ if(!d->analysis_mode && !d->test_only && d->format != FORMAT_RAW) { +#ifdef _WIN32 + if(strcmp(outfilename, "-&qu...

...ew file, a bunch of > replacements of existing fopen() calls with flac_fopen() (similarly > for chmod and utime) and the main function for the flac and metaflac > executables will have an additional: > > #ifdef _WIN32 > if (!convert_argv_to_utf8(&argc, &argv)) > flac__utils_printf(stderr, 1, "ERROR: yada yada\n"); > #endif > > This is a small un-obtrusive change that I fully support. > > I would however like to see it sooner rather than later so we can get > this damn thing released :-). > Before anyone does anything, see __wgetmainargs...