search for: flac__streamdecoderstate

...I am not sure of all your procedures for submitting patches/pull requests. The attached patch fixes all Clang compilation warnings. Note, some of these warnings were real problems. There is the potential for API users to misinterpret the state being returned since the return variable was of type FLAC__StreamDecoderState, but the value being returned was FLAC__StreamDecoderInitStatus. When FLAC__STREAM_DECODER_INIT_STATUS_ALREADY_INITIALIZED was returned in this case it was indistinguishable from FLAC__STREAM_DECODER_OGG_ERROR. Is there somewhere that I can push the patch so that it can easily be pulled into the r...

...>> The attached patch fixes all Clang compilation warnings. > > I'll check this out. > >> Note, some of these warnings were real problems. There is the >> potential for API users to misinterpret the state being returned >> since the return variable was of type FLAC__StreamDecoderState, >> but the value being returned was FLAC__StreamDecoderInitStatus. >> When FLAC__STREAM_DECODER_INIT_STATUS_ALREADY_INITIALIZED was >> returned in this case it was indistinguishable from >> FLAC__STREAM_DECODER_OGG_ERROR. > > Problem is this patch changes the ABI bec...

...email and sent to the list. > The attached patch fixes all Clang compilation warnings. I'll check this out. > Note, some of these warnings were real problems. There is the > potential for API users to misinterpret the state being returned > since the return variable was of type FLAC__StreamDecoderState, > but the value being returned was FLAC__StreamDecoderInitStatus. > When FLAC__STREAM_DECODER_INIT_STATUS_ALREADY_INITIALIZED was > returned in this case it was indistinguishable from > FLAC__STREAM_DECODER_OGG_ERROR. Problem is this patch changes the ABI because FLAC__StreamDecodeIni...

brianw wrote: > On Sep 1, 2024, at 12:44 PM, Martijn van Beurden wrote: >> Everything works, but as is with any change to the API, I don't know >> whether it is convenient for API users other than the flac command >> line tool. So, I'd like some feedback. I only looked briefly, but I had a few questions. How does FLAC__stream_decoder_get_total_samples() work for

...ata_ignore - FLAC__stream_decoder_set_metadata_ignore_all That means the metadata filters can now be changed after initialization, which wasn't possible before. Additionally, two structs were changed. To FLAC__StreamDecoderReadStatus, FLAC__STREAM_DECODER_READ_STATUS_END_OF_LINK was added. To FLAC__StreamDecoderState, FLAC__STREAM_DECODER_END_OF_LINK was added. These two additions break the ABI compatibility. Op zo 1 sep 2024 om 23:55 schreef Timothy B. Terriberry <tterribe at xiph.org>: > > brianw wrote: > > On Sep 1, 2024, at 12:44 PM, Martijn van Beurden wrote: > >> Everything wor...