search for: flac__stream_encoder_set_metadata

I've found what looks like a bug in FLAC++ inside the Stream::set_metadata() method. It appears that the contained calls to FLAC__stream_encoder_set_metadata() are being passed arguments that point to local stack data (specifically the 'm' parameter which is a table that points to metadata objects). The code inside FLAC__stream_encoder_set_metadata() does nothing but store the given args ('m' and 'num_blocks'). When Stream::s...

...en the total number of samples is unknown? Or does the seektable override the info from METADATA_BLOCK_STREAMINFO? I used this functions now to add seekpoints, but all remain placeholders according to metaflac: FLAC__metadata_object_new FLAC__metadata_object_seektable_template_append_placeholders FLAC__stream_encoder_set_metadata (encoder init & loop) FLAC__metadata_object_seektable_template_sort Best regards Stefan Am 13.10.24 um 22:33 schrieb Stefan Oltmanns: > Hi Martijn, > > Am 13.10.24 um 21:00 schrieb Martijn van Beurden: >> >> There's actually quite a lot of documentation for this. &gt...

...suitable seektable is found, it overrides the information from streaminfo, yes. > > I used this functions now to add seekpoints, but all remain placeholders > according to metaflac: > > FLAC__metadata_object_new > FLAC__metadata_object_seektable_template_append_placeholders > FLAC__stream_encoder_set_metadata > (encoder init & loop) > FLAC__metadata_object_seektable_template_sort > Yes, that is correct, because you asked for placeholder points. You should ask for spaced points. I just tested what happens if you make a seek table template with a total_samples that is bigger than the eventua...

...g something. I changed the section where the meta data is added to the encoder to add a seek table block. (metadata[2] = FLAC__metadata_object_new(FLAC__METADATA_TYPE_SEEKTABLE)) == NULL || !FLAC__metadata_object_seektable_template_append_placeholders(metadata[2],16) || ... ok = FLAC__stream_encoder_set_metadata(encoder, metadata, 3); I don't really understand the details of the seek table but my thinking here is that I am giving the encoder a template to populate up to 16 seek points. The documentation says the encoder will modify the seek table block during encoding but the passed meta block (which...

Hi, I'm sorry to say that I've found the libFLAC++ interface and documentation pretty slim and baffling. What I need to do is add some application-specific metadata to a FLAC file (i'm using the FLAC++ fileencoder). It is currently just a string of characters, which doesn't need to be null-terminated. I've looked through the docs, i've looked through the tests, and

Hi Martijn, Am 13.10.24 um 21:00 schrieb Martijn van Beurden: > > There's actually quite a lot of documentation for this. > > Please review https://xiph.org/flac/api/group__flac__stream__encoder.html#ga80d57f9069e354cbf1a15a3e3ad9ca78 > > I quote: >> SEEKTABLE blocks are handled specially. Since you will not know the >> values for the seek point stream offsets,

...t; entry, /*copy=*/true); > ok &= > FLAC__metadata_object_vorbiscomment_entry_from_name_value_pair(&entry, > "DATE", FLAC_tagYear); > ok &= FLAC__metadata_object_vorbiscomment_append_comment(metadata[1], > entry, /*copy=*/true); > #endif > if (!FLAC__stream_encoder_set_metadata(encoder, metadata, 2)) > return FLAC__STREAM_ENCODER_CLIENT_ERROR; > > /* initialize encoder */ > if(ok) { > init_status = FLAC__stream_encoder_init_file(encoder, argv[2], > progress_callback, /*client_data=*/NULL); > if(init_status != FLAC__STRE...

...ay the wrong length. Seems to be a bug in flac. > >> >> I used this functions now to add seekpoints, but all remain placeholders >> according to metaflac: >> >> FLAC__metadata_object_new >> FLAC__metadata_object_seektable_template_append_placeholders >> FLAC__stream_encoder_set_metadata >> (encoder init & loop) >> FLAC__metadata_object_seektable_template_sort >> > > Yes, that is correct, because you asked for placeholder points. You > should ask for spaced points. I just tested what happens if you make a > seek table template with a total_samples...

I refer to a problem that appeared on the flac list last August that was either solved off-list or abandoned. (http://lists.xiph.org/pipermail/flac/2005-August/000468.html) The problem is with using the C++ encoder classes, particularly the FLAC::Encoder::File:set_metadata function. JC said that the developers version of how to add a simple metadata block looked right, but it did not work for