search for: flac__stream_encoder_finish

Hi, I am working on an application which records directly into a FLAC file. For this purpose I'm using the FLAC stream encoder interface. It works fine, but if my application is killed during encoding, the metadata is not being updated since the file isn't closed properly by calling FLAC__stream_encoder_finish(). Thus when opening the file afterwards for playback, it is possible to decode audio data but the FLAC__StreamMetadata.data.stream_info.total_samples field is equals to zero. This is a true problem because it looks like data loss to the user, especially if he/she's been recording for hours.....

...l: 00003039): type unknown Warning: EOS not set on stream 1 erikd@mingus > ogginfo seekable.ogg Processing file "seekable.ogg"... New logical stream (#1, serial: 00003039): type unknown Warning: EOS not set on stream 1 I have looked into this and suspect that the FLAC__stream_encoder_finish() function needs to finish off the stream using a call to ogg_stream_flush() instead of the standard function ogg_stream_pageout(). Josh (or anyone), I'd appreciate it if you could take a look at this. Cheers, Erik -- +-----------------------------------------------------------+ Erik de Ca...

.../* audio buffer is an int16_t buffer that paranoia dumps interleaved audio into */ FLAC__stream_encoder_process_interleaved( encoder, audio_buffer, CD_FRAMESIZE_RAW / 4); } FLAC__stream_encoder_finish(encoder); FLAC__stream_encoder_delete(encoder); write_callback simply writes the encoded data out to a file stream, and metadata_callback isn't doing anything at the moment (one thing at a time :-) ). Now one thing that I see which may be causing my issue is the fact that paranoia is ex...

Erik de Castro Lopo wrote: > Josh et al, > > I've been tracking down a problem with generating OggFlac files. <snip> > I have looked into this and suspect that the FLAC__stream_encoder_finish() > function needs to finish off the stream using a call to ogg_stream_flush() > instead of the standard function ogg_stream_pageout(). I bashed on this a bit further and came up with the following patch: http://www.mega-nerd.com/tmp/flac-end_of_stream.diff There's probably a more...

On Tue, Nov 07, 2006 at 06:31:04AM +1100, Erik de Castro Lopo wrote: > I haven't tested it, but I don't think just setting packet.e_o_s > is sufficient to close the stream. The forced ogg_stream_flush() > is required. libogg checks the e_o_s flag (and has always done so, according to svn) so you shouldn't have to call ogg_stream_flush() except when you want to force a page

...t paranoia dumps interleaved >audio into */ > FLAC__stream_encoder_process_interleaved( encoder, > audio_buffer, > CD_FRAMESIZE_RAW / >4); > >} > > FLAC__stream_encoder_finish(encoder); > FLAC__stream_encoder_delete(encoder); > >write_callback simply writes the encoded data out to a file stream, and >metadata_callback isn't doing anything at the moment (one thing at a >time :-) ). > >Now one thing that I see which may be causing my issue is...

...Erik de Castro Lopo <erikd-flac@mega-nerd.com> wrote: > Erik de Castro Lopo wrote: > > > Josh et al, > > > > I've been tracking down a problem with generating OggFlac files. > > <snip> > > > I have looked into this and suspect that the > FLAC__stream_encoder_finish() > > function needs to finish off the stream using a call to > ogg_stream_flush() > > instead of the standard function ogg_stream_pageout(). > > I bashed on this a bit further and came up with the following patch: > > http://www.mega-nerd.com/tmp/flac-end_of_stream...

...3a bytes C Test.exe!write_bitbuffer_(FLAC__StreamEncoder * encoder=0x003571f8, unsigned int samples=1128, int is_last_block=1) Line 2622 + 0x19 bytes C Test.exe!process_frame_(FLAC__StreamEncoder * encoder=0x003571f8, int is_fractional_block=1, int is_last_block=1) Line 3119 + 0x16 bytes C Test.exe!FLAC__stream_encoder_finish(FLAC__StreamEncoder * encoder=0x003571f8) Line 1334 + 0xf bytes C Test.exe!FLAC::Encoder::Stream::~Stream() Line 57 + 0xc bytes C++ Test.exe!FLAC::Encoder::File::~File() Line 448 + 0x8 bytes C++ Test.exe!MyFile::~MyFile() + 0x2e bytes C++ Test.exe!main() Line 188 + 0xf bytes C++ Test.exe!__tmainCRT...

I'm using libflac on Windows to compress some audio samples. I'm building the library locally, using Visual Studio 2010. Each set of data is 2-5 MB and well formed PCM encoded data. I'm finding some very odd behavior. If I enable verify on the encode stream, I get a verify mismatch on most of my sample sets. Each set of samples returns this error at a different location in the stream,

...> (FLAC__int16)buffer[2*i]); > } > /* feed samples to encoder */ > ok = FLAC__stream_encoder_process_interleaved(encoder, pcm, > need); > } > left -= need; > } > } > > ok &= FLAC__stream_encoder_finish(encoder); > > fprintf(stderr, "encoding: %s\n", ok? "succeeded" : "FAILED"); > fprintf(stderr, " state: %s\n", > FLAC__StreamEncoderStateString[FLAC__stream_encoder_get_state(encoder)]); > > /* now that encoding is finished, th...

...; +#endif + } if(!FLAC__add_metadata_block(&encoder->private_->streaminfo, encoder->private_->frame)) { encoder->protected_->state = FLAC__STREAM_ENCODER_FRAMING_ERROR; return FLAC__STREAM_ENCODER_INIT_STATUS_ENCODER_ERROR; @@ -1305,9 +1319,13 @@ FLAC_API FLAC__bool FLAC__stream_encoder_finish(FLAC__StreamEncoder *encoder) } } - if(encoder->protected_->do_md5) - FLAC__MD5Final(encoder->private_->streaminfo.data.stream_info.md5sum, &encoder->private_->md5context); - + if(encoder->protected_->do_md5) { +#if defined(HAVE_OPENSSL) + error = (EVP_Dig...