search for: flac__public_needs_underscor

I'm trying to port flac 1.2.1 to OS X (I'm taking over maintainership of the Fink package), and I'm running into some problems with bitreader_asm.nasm. After adding the following to nasm.h: +%elifdef OBJ_FORMAT_macho + %define FLAC__PUBLIC_NEEDS_UNDERSCORE + %idefine code_section section .text + %idefine data_section section .data + %idefine bss_section section .bss I can get it compiling, but when it tries to link the libFLAC dylib, it complains: ld: warning codegen in FLAC__bitreader_read_rice_signed_block_asm_ia32_bswap.c1_loop (offset 0...

...ly care about 64bit so I just did what was necessary to force it to 32bit. The final issue ended up being the assembly routines, which don't understand OSX's "macho" format. In src/libFLAC/ia32/nasm.h, I replaced "%error unsupported object format!" with "%define FLAC__PUBLIC_NEEDS_UNDERSCORE" and everything worked beautifully. Obviously in a real situation you'd want to create an %elifdef OBJ_FORMAT_macho block. Unless I've completely botched my test program, which is always possible, both builds now work flawlessly. Hope this helps someone :) -Ben

They are not needed since the section is defined in nasm.h. --- src/libFLAC/ia32/bitreader_asm.nasm | 4 ---- src/libFLAC/ia32/cpu_asm.nasm | 4 ---- src/libFLAC/ia32/fixed_asm.nasm | 4 ---- src/libFLAC/ia32/lpc_asm.nasm | 4 ---- src/libFLAC/ia32/stream_encoder_asm.nasm | 4 ---- 5 files changed, 20 deletions(-) diff --git