search for: flac__metadata_type_vorbis_com

...6.000000000 +0200 @@ -1754,20 +1754,24 @@ found_vc_block = true; } while(!found_vc_block && FLAC__metadata_iterator_next(iterator)); - /* create a new block if necessary */ - if(!found_vc_block && operation->type == OP__SET_VC_FIELD) { - block = FLAC__metadata_object_new(FLAC__METADATA_TYPE_VORBIS_COMMENT); - if(0 == block) - die("out of memory allocating VORBIS_COMMENT block"); - while(FLAC__metadata_iterator_next(iterator)) - ; - if(!FLAC__metadata_iterator_insert_block_after(iterator, block)) { - fprintf(stderr, "%s: ERROR: adding new VORBIS_COMMENT block to metadata,...

..._StreamMetadata_Picture *block); @@ -2091,7 +2091,7 @@ FLAC__Metadata_SimpleIteratorStatus read_metadata_block_data_cb_(FLAC__IOHandle case FLAC__METADATA_TYPE_SEEKTABLE: return read_metadata_block_data_seektable_cb_(handle, read_cb, &block->data.seek_table, block->length); case FLAC__METADATA_TYPE_VORBIS_COMMENT: - return read_metadata_block_data_vorbis_comment_cb_(handle, read_cb, &block->data.vorbis_comment); + return read_metadata_block_data_vorbis_comment_cb_(handle, read_cb, seek_cb, &block->data.vorbis_comment, block->length); case FLAC__METADATA_TYPE_CUESHEET: return...

...pretty much as the flac documentation suggests: result = FLAC__metadata_simple_iterator_init(iterator, fileName, FALSE, FALSE); /** * Zip through the file for the vorbis comment section. */ while (FLAC__metadata_simple_iterator_get_block_type(iterator) != FLAC__METADATA_TYPE_VORBIS_COMMENT) { result = FLAC__metadata_simple_iterator_next(iterator); } /** * Get the current block and write out the new values for it. */ metaData = FLAC__metadata_simple_iterator_get_block(iterator); /** * Save the strings...

severity 200435 normal thanks I received this bug report from a Debian user. I can't think of any reason offhand why the command line tool would work while the xmms plugin would fail. ----- Forwarded message from Stephan Niemz <st.n@gmx.net> ----- Date: Tue, 8 Jul 2003 10:24:57 +0200 From: Stephan Niemz <st.n@gmx.net> Resent-From: Stephan Niemz <st.n@gmx.net> To: Debian

..._StreamMetadata_Picture *block); @@ -2091,7 +2091,7 @@ FLAC__Metadata_SimpleIteratorStatus read_metadata_block_data_cb_(FLAC__IOHandle case FLAC__METADATA_TYPE_SEEKTABLE: return read_metadata_block_data_seektable_cb_(handle, read_cb, &block->data.seek_table, block->length); case FLAC__METADATA_TYPE_VORBIS_COMMENT: - return read_metadata_block_data_vorbis_comment_cb_(handle, read_cb, &block->data.vorbis_comment); + return read_metadata_block_data_vorbis_comment_cb_(handle, read_cb, seek_cb, &block->data.vorbis_comment, block->length); case FLAC__METADATA_TYPE_CUESHEET: return...

...run metaflac, but that you examine its source to see how it creates new FLAC files without the Vorbis comment. As far as I know, metaflac uses the standard libFLAC and creates files without the Vorbis overhead. My quick review of the source seemed to indicate that calling FLAC__metadata_object_new(FLAC__METADATA_TYPE_VORBIS_COMMENT) will create the comment, but I assumed that you could pass in NULL. I mistakenly thought that was FLAC__stream_encoder_new(). There is a comment saying that the Ogg FLAC mapping requires a VORBIS_COMMENT, but that doesn’t necessarily mean that standard FLAC also requires the Vorbis comment....

...flac.sourceforge.net/api/group__flac__metadata__level1.html#_details The C++ interface is a little simpler: FLAC::Metadata::SimpleIterator it; if (it.is_valid()) { if (it.init(filename, true, true)) { FLAC::Metadata::VorbisComment *vc = 0; do { if (it.get_block_type() == ::FLAC__METADATA_TYPE_VORBIS_COMMENT) { vc = dynamic_cast<FLAC::Metadata::VorbisComment*>(it.get_block()); assert(0 != vc); } } while (!vc && it.next()); //use vc delete vc; } } maybe I should add a shorthand function similar to flac__metadata_get_streaminfo() J...

...ream_info.sample_rate; > - file_info->length_in_msec = file_info->total_samples * 10 / (file_info->sample_rate / 100); > + file_info->length_in_msec = (FLAC__uint64)file_info->total_samples * 10 / (file_info->sample_rate / 100); > } > else if(metadata->type == FLAC__METADATA_TYPE_VORBIS_COMMENT) { > double gain, peak; It seems like would be simpler to do something like: (file_info->total_samples / file_info->sample_rate) * 1000; -- - mdz

..._StreamMetadata_Picture *block); @@ -2091,7 +2091,7 @@ FLAC__Metadata_SimpleIteratorStatus read_metadata_block_data_cb_(FLAC__IOHandle case FLAC__METADATA_TYPE_SEEKTABLE: return read_metadata_block_data_seektable_cb_(handle, read_cb, &block->data.seek_table, block->length); case FLAC__METADATA_TYPE_VORBIS_COMMENT: - return read_metadata_block_data_vorbis_comment_cb_(handle, read_cb, &block->data.vorbis_comment); + return read_metadata_block_data_vorbis_comment_cb_(handle, read_cb, seek_cb, &block->data.vorbis_comment, block->length); case FLAC__METADATA_TYPE_CUESHEET: return...

Well, I'm quite frankly stumped. I'm writing a program that recurses into directories and reads (among others) FLAC files and should be able to read the vorbis comments ARTIST and TITLE from the file. A while back, I was popen()ing to metaflac, because I didn't want to mess with libFLAC. But now, it's the weekend, so I can mess around with this. Here's the code in question:

Janne Hyv?rinen wrote: > Patch v2, now handles more malformed cases. Original patch was for a > file for which I had a sample from a user but this allows handling some > manually broken test cases. Err, I'm getting warning messages on that patch: CC metadata_iterators.lo metadata_iterators.c: In function ?read_metadata_block_data_vorbis_comment_cb_?:

...LAC__file_decoder_set_md5_checking(decoder, false); ! FLAC__file_decoder_set_filename(decoder, filename); ! FLAC__file_decoder_set_metadata_ignore_all(decoder); ! FLAC__file_decoder_set_metadata_respond(decoder, FLAC__METADATA_TYPE_STREAMINFO); ! FLAC__file_decoder_set_metadata_respond(decoder, FLAC__METADATA_TYPE_VORBIS_COMMENT); ! FLAC__file_decoder_set_write_callback(decoder, write_callback_); ! FLAC__file_decoder_set_metadata_callback(decoder, metadata_callback_); ! FLAC__file_decoder_set_error_callback(decoder, error_callback_); ! FLAC__file_decoder_set_client_data(decoder, &file_info_); ! if(FLAC__file_d...

...t_sample_rate(encoder, sample_rate); > ok &= FLAC__stream_encoder_set_total_samples_estimate(encoder, > total_samples); > > if( (metadata[0] = > FLAC__metadata_object_new(FLAC__METADATA_TYPE_PADDING)) == NULL || > (metadata[1] = > FLAC__metadata_object_new(FLAC__METADATA_TYPE_VORBIS_COMMENT)) == NULL) > ok = false; > > metadata[0]->length = 512; /* set the padding length */ > #if BUGGY > ok &= > FLAC__metadata_object_vorbiscomment_entry_from_name_value_pair(&entry, > "TITLE", FLAC_tagTitle); > ok &= FLAC__metada...

Correction, the flac command-line does create a 40-byte Vorbis comment by default. I just never noticed it before. I’ve been using —no-padding all these years for minimal file sizes without realizing that I could save another 40 bytes. Anyway, since metaflac can remove the Vorbis comment using the standard library, then you should be able to create a solution without modifying libFLAC. Brian