search for: flac__lpc_restore_signal_asm_ia32

Erik de Castro Lopo wrote: >> There's the following code in stream_decoder.c: > > Like you, I don't see a lot of value in these. I think I'll decline > these. FLAC__lpc_restore_signal_asm_ia32_mmx compares 'order' argument with 4 and if it's greater then it jumps to FLAC__lpc_restore_signal_asm_ia32. I wonder why the same wasn't done for PPC/Altivec: why libFLAC compares 'order' and 8 in C code and not in asm.

As I wrote earlier, GCC generates slow ia32 code for FLAC__lpc_compute_residual_from_qlp_coefficients_wide() and FLAC__lpc_restore_signal_wide(). So 24-bit encoding/decoding is slower for GCC compile than for MSVS or ICC compile. I took FLAC__lpc_compute_residual_from_qlp_coefficients_asm_ia32 and FLAC__lpc_restore_signal_asm_ia32 asm functions and wrote their _wide versions. -------------- next part -------------- A non-text attachment was scrubbed... Name: wide_asm.patch Type: application/octet-stream Size: 15653 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20140103/45594e52/attachme...

I think I've gotten FLAC__lpc_restore_signal() about as good as I'm going to get it. Here's what I have: -a new file, lpc_asm.s, which has the assembly routines -changes to cpu.h, cpu.c, and stream_decoder.c to enable them -changes to configure.in to support the new cpu stuff -a preliminary Makefile.am -maybe something else I'm forgetting Now automake complains that configure.in

...store_signal; /* now override with asm where appropriate */ #ifndef FLAC__NO_ASM if(decoder->private_->cpuinfo.use_asm) { *************** *** 290,301 **** --- 292,311 ---- if(decoder->private_->cpuinfo.data.ia32.mmx) { decoder->private_->local_lpc_restore_signal = FLAC__lpc_restore_signal_asm_ia32; decoder->private_->local_lpc_restore_signal_16bit = FLAC__lpc_restore_signal_asm_ia32_mmx; + decoder->private_->local_lpc_restore_signal_16bit_order8 = FLAC__lpc_restore_signal_asm_ia32_mmx; } else { decoder->private_->local_lpc_restore_signal = FLAC__lpc_res...

...a32' > ../../src/libFLAC/.libs/libFLAC.so: undefined reference to `FLAC__lpc_compute_residual_from_qlp_coefficients_asm_ia32_mmx' > ../../src/libFLAC/.libs/libFLAC.so: undefined reference to `FLAC__cpu_info_asm_ia32' > ../../src/libFLAC/.libs/libFLAC.so: undefined reference to `FLAC__lpc_restore_signal_asm_ia32_mmx' > ../../src/libFLAC/.libs/libFLAC.so: undefined reference to `FLAC__lpc_restore_signal_asm_ia32' > ../../src/libFLAC/.libs/libFLAC.so: undefined reference to `FLAC__cpu_info_extended_amd_asm_ia32' > ../../src/libFLAC/.libs/libFLAC.so: undefined reference to `FLAC__lpc_comp...

...not shared library expert, i don't know whether it is bug or feature of ld, or some misunderstanding with nasm produced objects or something totally different. In lpc_asm.nasm are functions: FLAC__lpc_compute_autocorrelation_asm_ia32 FLAC__lpc_compute_residual_from_qlp_coefficients_asm_ia32 FLAC__lpc_restore_signal_asm_ia32 containing instructions like "lea edx, [.. + blah]", we want there to blah be replaced by absolute address of label blah and this is the problem. Solution is simple, just delete these functions. I will look more at the problem later. -- Miroslav Lichvar lichvarm@phoenix.inf.upol.cz

...void FLAC__lpc_restore_signal_wide(const FLAC__int32 residual[], unsigned data_len, const FLAC__int32 qlp_coeff[], unsigned order, int lp_quantization, FLAC__int32 data[]); #ifndef FLAC__NO_ASM -#ifdef FLAC__CPU_IA32 -#ifdef FLAC__HAS_NASM +# ifdef FLAC__CPU_IA32 +# ifdef FLAC__HAS_NASM void FLAC__lpc_restore_signal_asm_ia32(const FLAC__int32 residual[], unsigned data_len, const FLAC__int32 qlp_coeff[], unsigned order, int lp_quantization, FLAC__int32 data[]); void FLAC__lpc_restore_signal_asm_ia32_mmx(const FLAC__int32 residual[], unsigned data_len, const FLAC__int32 qlp_coeff[], unsigned order, int lp_quantization,...

1) lpc.c, FLAC__lpc_quantize_coefficients(): This function declares "const int nshift = -(*shift)" variable when *shift is less than 0. Then nshift is used in the loop: for(i = 0; i < order; i++) { error += lp_coeff[i] / (1 << nshift); This patch adds "const int pshift = *shift" variable. Pros: * more symmetry for two branches * compiler doesn't

lvqcl wrote: > FLAC__lpc_restore_signal_asm_ia32_mmx compares 'order' argument with 4 > and if it's greater then it jumps to FLAC__lpc_restore_signal_asm_ia32. > > I wonder why the same wasn't done for PPC/Altivec: why libFLAC compares > 'order' and 8 in C code and not in asm. ...more about PPC ASM: http://gi...

--- Miroslav Lichvar <lichvarm@phoenix.inf.upol.cz> wrote: > On Wed, Nov 14, 2001 at 09:37:47AM -0800, Josh Coalson wrote: > > cpu support for 3dnow and sse can be easily detected at > > runtime. I turned off 3dnow by default because it is > > implicated in some crashes. > > Hmm, i never have any crash. Can i get more informations about these > crases? Or you

...fo_sse_os_asm_ia32' ../../src/libFLAC/.libs/libFLAC.so: undefined reference to `FLAC__lpc_compute_residual_from_qlp_coefficients_asm_ia32_mmx' ../../src/libFLAC/.libs/libFLAC.so: undefined reference to `FLAC__cpu_info_asm_ia32' ../../src/libFLAC/.libs/libFLAC.so: undefined reference to `FLAC__lpc_restore_signal_asm_ia32_mmx' ../../src/libFLAC/.libs/libFLAC.so: undefined reference to `FLAC__lpc_restore_signal_asm_ia32' ../../src/libFLAC/.libs/libFLAC.so: undefined reference to `FLAC__cpu_info_extended_amd_asm_ia32' ../../src/libFLAC/.libs/libFLAC.so: undefined reference to `FLAC__lpc_compute_autocorrela...

On Fri, Jul 20, 2001 at 03:01:54PM -0700, Josh Coalson wrote: > --- Matt Zimmerman <mdz@debian.org> wrote: > > > > automake will include ltmain.sh in the source distribution, so it > > should be > > used even if it isn't installed on the build system. In fact, it > > seems to > > always use the distributed version, and not the installed one