search for: flac__has_nasm

The #endifs are mismatched, and my builds were failing because lpc_restore_signal* weren't getting declared. I've also commented the endifs to make them easier to match. Also, is there any reason #ifdefs for FLAC__HAS_NASM and FLAC__CPU_IA32 are separate and nested the way they are and not combined like this?: #if defined(FLAC__CPU_IA32) && defined(FLAC__HAS_NASM) I'm not sure if there are portability issues with the above, though. --- orig/src/libFLAC/include/private/lpc.h +++ mod/src/libFLAC/include...

...with the message: "Remove `FLAC__cpu_have_cpuid_x86` altogether as it wasn't actually being used but that was difficult to tell because of all the #ifdef nonsense." But FLAC__cpu_have_cpuid_x86() actually WAS used in the code #if !defined FLAC__NO_ASM && (defined FLAC__HAS_NASM || FLAC__HAS_X86INTRIN) info->use_asm = true; /* we assume a minimum of 80386 with FLAC__CPU_IA32 */ #if FLAC__HAS_X86INTRIN if(!FLAC__cpu_have_cpuid_x86()) return; #else if(!FLAC__cpu_have_cpuid_asm_ia32())...

> Oliver St?neberg wrote: > > > This is simply fixed by putting those unused constants into the > > proper defines. I attached a patch against git 70b078c. > > Unfortunately it breaks x86_64 build (where FLAC__CPU_X86_64 is defined, and > FLAC__CPU_IA32 isn't). Maybe it's simpler to turn them into #defines such as > > #define

...d with an old compiler (GCC 4.2.1) that doesn't have x86intrin.h. Specifically, the definition of FLAC__CPUINFO_IA32_CPUID_SSE3 etc. is guarded by #if FLAC__HAS_X86INTRIN || FLAC__AVX_SUPPORTED However, the later use in ia32_cpu_info is guarded by #if !defined FLAC__NO_ASM && (defined FLAC__HAS_NASM || FLAC__HAS_X86INTRIN) In our case, we have FLAC__HAS_NASM 1 FLAC__HAS_X86INTRIN 0 FLAC__AVX_SUPPORTED 0 -- Christian "naddy" Weisgerber naddy at mips.inka.de

...Studio 2010 and Visual Studio 2005. I am trying to build only the static library for C but it always end up having some error. Could anyone can help me how to built the library using VS 2010 or 2005? I do some research, And try to change: On PreProcessor Definitions: FLAC__HAS_OGG to FLAC__NO_OGG FLAC__HAS_NASM to FLAC__NO_ASM Set Runtime Library to Multi-Threaded Set Language wchar_t to Yes But these doesn't solve the problem. -Denver- -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20130104/bec54164/attachment.ht...

...ked that code since it didn't exist in 1.2.1 and 1.3.0 and > we never set the CPU defines before for MAME/MESS (will look into > that). Another possible solution is to dumplicate the definitions like this: #if defined FLAC__CPU_IA32 && !defined FLAC__NO_ASM && (defined FLAC__HAS_NASM || defined FLAC__HAS_X86INTRIN) /* these are flags in EDX of CPUID AX=00000001 */ static const unsigned FLAC__CPUINFO_IA32_CPUID_CMOV = 0x00008000; static const unsigned FLAC__CPUINFO_IA32_CPUID_MMX = 0x00800000; static const unsigned FLAC__CPUINFO_IA32_CPUID_FXSR = 0x01000000; static const unsigne...

...uniformity it's better to revert this commit http://git.xiph.org/?p=flac.git;a=commit;h=151739921b74fbf31420358a5fbeb094efa017ed because before it there was only one place of non-uniformity: line 140 in configure.ac, now there are several .c and .h files with all-caps FLAC__*** (FLAC__CPU_IA32, FLAC__HAS_NASM, FLaC__HAS_OGG) and suddenly FLaC__CPU_X86_64.

...over a decade. Forunately the > need for complexity is decreasing. > > I propose that we release FLAC with cpu.c as it is now and deal with > the consequences as they arise. Makes sense. But still... IMHO it makes sense to change "if !FLAC__HAS_X86INTRIN" to "if defined FLAC__HAS_NASM". It covers more cases, and it's logical: FLAC__cpu_have_cpuid_asm_ia32() can be called if (and only if) NASM is available. (the patch is attached just in case). -------------- next part -------------- A non-text attachment was scrubbed... Name: have_cpuid.patch Type: application/octet-s...

...and Input-> "Additional Dependencies" appropriately. Both the main app and the flac libs are build using the "runtime library" Multi-Threaded /MT (or /MTd for debug mode) The flac project is using the preprocessor definitions: WIN32 NDEBUG _LIB FLAC__HAS_OGG FLAC__CPU_IA32 FLAC__HAS_NASM FLAC__USE_3DNOW VERSION="1.2.0" FLAC__NO_DLL I'm not sure what else to try at this stage. I've reached the point where I start going in circles and accessing the same internet search results. Has anyone got any suggestions? Thanks Glenn

...le: /cvsroot/flac/flac/src/libFLAC/cpu.c,v retrieving revision 1.8 diff -u -r1.8 cpu.c --- src/libFLAC/cpu.c 2001/07/18 00:24:46 1.8 +++ src/libFLAC/cpu.c 2001/07/27 08:57:04 @@ -21,6 +21,20 @@ #include<stdlib.h> #include<stdio.h> +#ifndef FLAC__NO_ASM +#ifdef FLAC__CPU_IA32 +#ifdef FLAC__HAS_NASM +#ifndef FLAC__SSE_OS +#ifndef NO_VFORK +#include <unistd.h> +#include <sys/types.h> +#include <sys/wait.h> +#endif +#endif +#endif +#endif +#endif + const unsigned FLAC__CPUINFO_IA32_CPUID_CMOV = 0x00008000; const unsigned FLAC__CPUINFO_IA32_CPUID_MMX = 0x00800000; const unsig...

...S_DOXYGEN) fi + AC_CHECK_PROGS(DOCBOOK_TO_MAN, docbook-to-man docbook2man) + AM_CONDITIONAL(FLaC__HAS_DOCBOOK_TO_MAN, test -n "$DOCBOOK_TO_MAN") + if test -n "$DOCBOOK_TO_MAN" ; then + AC_DEFINE(FLAC__HAS_DOCBOOK_TO_MAN) + fi + AC_CHECK_PROGS(NASM, nasm) AM_CONDITIONAL(FLaC__HAS_NASM, test -n "$NASM") if test -n "$NASM" ; then *************** *** 337,342 **** --- 343,349 ---- AH_TEMPLATE(FLAC__EXHAUSTIVE_TESTS, [define to run even more tests]) AH_TEMPLATE(FLAC__VALGRIND_TESTING, [define to enable use of Valgrind in testers]) AH_TEMPLATE(FLAC__HAS_D...

...e ia32/*.nasm code in 64-bit compiles. There's still no 64-bit asm code in FLAC. I'm not familiar with asm too, so I wrote SSE-accelerated code using intrinsics. This code uses two new preprocessor macros: FLAC__CPU_X86_64 (analogous to FLAC__CPU_IA32) and FLAC__HAS_X86INTRIN (analogous to FLAC__HAS_NASM) Patch for cpu.c/cpu.h adds CPU features (sse3, ssse3) detection code for x86-64 architecture. Another patch adds SSE-accelerated functions: FLAC__lpc_compute_autocorrelation_intrin_sse_lag_4() FLAC__lpc_compute_autocorrelation_intrin_sse_lag_8() FLAC__lpc_compute_autocorrelation_...

With these versions: ii autoconf 2.54-2 automatic configure script builder ii automake1.6 1.6.3-2 A tool for generating GNU Standards-complian I am unable to build the autoconfiscations. autoheader gives: autoheader2.50: error: AC_CONFIG_HEADERS not found in configure.in What versions are you using? (btw, I do think it would be a very good idea to start using

finished hooking up the altivec stuff so it works in ProjectBuilder. I ran a test, doing a 'flac -t' on 400MB of files compresses at level 5. the runtime dropped from from 180 sec to 105 sec! once I get the latest autotools on my ibook I'll try and get asm compilation to work that way. Josh --- Josh Coalson <xflac@yahoo.com> wrote: > OK, checked it all in (only minor

...DD BASE CPP /nologo /W3 /GX /O2 /D "WIN32" /D "NDEBUG" /D "_WINDOWS" /YX /FD /c # ADD CPP /nologo /W3 /GX /O2 /I "../../include" /I "./include" /D "WIN32" /D "NDEBUG" /D "_WINDOWS" /D "FLAC__CPU_IA32" /D "FLAC__HAS_NASM" /D "NO_VFORK" /D "STRICT" /YX /FD /c BSC32=bscmake.exe # ADD BASE BSC32 /nologo # ADD BSC32 /nologo LIB32=link.exe -lib # ADD BASE LIB32 /nologo # ADD LIB32 /nologo /out:"..\..\obj\lib\libFLAC.lib" !ELSEIF "$(CFG)" == "libFLAC - Win32 Debug"...

...the flac libs are build using the "runtime > library" Multi-Threaded /MT (or /MTd for debug mode) > That is the MSVCR* library settings. > The flac project is using the preprocessor definitions: > > WIN32 > NDEBUG > _LIB > FLAC__HAS_OGG > FLAC__CPU_IA32 > FLAC__HAS_NASM > FLAC__USE_3DNOW > VERSION="1.2.0" > FLAC__NO_DLL > > I'm not sure what else to try at this stage. I've reached the point > where I start going in circles and accessing the same internet search > results. Has anyone got any suggestions? > Did you compil...

...der.c index f987c27..37934de 100644 --- a/src/libFLAC/stream_decoder.c +++ b/src/libFLAC/stream_decoder.c @@ -400,7 +400,7 @@ static FLAC__StreamDecoderInitStatus init_stream_internal_( #ifdef FLAC__CPU_IA32 FLAC__ASSERT(decoder->private_->cpuinfo.type == FLAC__CPUINFO_TYPE_IA32); #ifdef FLAC__HAS_NASM -#if 1 /*@@@@@@ OPT: not clearly faster, needs more testing */ +#if 0 /*@@@@@@ OPT: seems to be slower than FLAC__bitreader_read_rice_signed_block */ if(decoder->private_->cpuinfo.data.ia32.bswap) decoder->private_->local_bitreader_read_rice_signed_block = FLAC__bitreader_read_ri...

...LAC. I'm not familiar with asm too, > so I wrote SSE-accelerated code using intrinsics. > > This code uses two new preprocessor macros: > FLAC__CPU_X86_64 (analogous to FLAC__CPU_IA32) Ok, I have defined FLAC__CPU_X86_64 in configure.ac. > and FLAC__HAS_X86INTRIN (analogous to FLAC__HAS_NASM) When should FLAC__HAS_X86INTRIN be defined? What header file should I be checking for? Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/

...g_NN() functions that require x86 intrinsics support. FLAC makes use of the former (if NASM is available) but doesn't try to use the latter when NASM is not found. Or does it make sence to add the following code: #ifdef FLAC__HAS_X86INTRIN #if defined FLAC__SSE_SUPPORTED && !defined FLAC__HAS_NASM if(encoder->private_->cpuinfo.ia32.sse) { encoder->private_->local_lpc_compute_autocorrelation = FLAC__lpc_compute_autocorrelation_intrin_sse_lag_NN; ... ... } #endif #endif

Hi Guys, The following code in CPU.c (line 155) won't link if you don't have NASM code built even if FLAC__HAS_X86INTRIN is true as FLAC__cpu_info_asm_ia32 don't exists and the else is compiled if there is no dead code stripping if (FLAC__HAS_X86INTRIN) { FLAC__cpu_info_x86(0, &flags_eax, &flags_ebx, &flags_ecx, &flags_edx); info->ia32.intel =