search for: flac__has_as__temporarily_disabled

...tivec: why libFLAC compares > 'order' and 8 in C code and not in asm. ...more about PPC ASM: http://git.xiph.org/?p=flac.git;a=commitdiff;h=63d489ae3140296419afdfc4cfc87cc2c7cb9faf http://git.xiph.org/?p=flac.git;a=commitdiff;h=3c8d2973cb87e318c11f3a487f2204bf0d673176 +AM_CONDITIONAL(FLaC__HAS_AS__TEMPORARILY_DISABLED, test "yes" = "no") -if FLaC__HAS_AS +#@@@@@@ +if FLaC__HAS_AS__TEMPORARILY_DISABLED -CPUCFLAGS = -maltivec -mabi=altivec -force_cpusubtype_ALL +#@@@@@@ PPC optimizations temporarily disabled +CPUCFLAGS = -maltivec -mabi=altivec -force_cpusubtype_ALL -DFLAC__NO_ASM Does...

Erik de Castro Lopo wrote: >> There's the following code in stream_decoder.c: > > Like you, I don't see a lot of value in these. I think I'll decline > these. FLAC__lpc_restore_signal_asm_ia32_mmx compares 'order' argument with 4 and if it's greater then it jumps to FLAC__lpc_restore_signal_asm_ia32. I wonder why the same wasn't done for PPC/Altivec:

...l, I am trying to compiler current CV head on a PowerPC G3 Debain system. Debian test has automake 1.9 which is a little more stringent about errors than 1.8. The following patch has the following fixes. 0) Remove AC_CANNONIAL_HOST because it has already been invoked earlier 1) Make sure FLaC__HAS_AS__TEMPORARILY_DISABLED and FLaC__HAS_GAS__TEMPORARILY_DISABLED have been defined on PPC. 2) Fix all instances of CFLAGS/CXXFLAGS being set in Makefile.am. These two variables are automaticall set in Makefile.in. If you need extra flag foo in Makefile.am, the correct way to do it is AM_CFLAGS/AM_CXXFLAGS...

...ead on a PowerPC G3 Debain > system. > > Debian test has automake 1.9 which is a little more stringent about > errors than 1.8. The following patch has the following fixes. > > 0) Remove AC_CANNONIAL_HOST because it has already been invoked > earlier > 1) Make sure FLaC__HAS_AS__TEMPORARILY_DISABLED and > FLaC__HAS_GAS__TEMPORARILY_DISABLED have been defined on PPC. > 2) Fix all instances of CFLAGS/CXXFLAGS being set in Makefile.am. > These two variables are automaticall set in Makefile.in. If you > need extra flag foo in Makefile.am, the correct way to do it is >...

--- Chris Csanady <cc@137.org> wrote: > Building the beta on the mac has one stumbling point: the ppc/as/ > libFLAC-asm.la is not currently built due to the configure define > FLaC__HAS_AS__TEMPORARILY_DISABLED, but it is expected to exist by > > libFLAC_la_LIBADD = ppc/as/libFLAC-asm.la > > in src/libFLAC/Makefile.am. After removing this line, it builds > and works as expected. I'll run the check and see how it goes. thanks... I checked in a fix to add __TEMPORARILY_DISABLED to t...

...quot;gas" ; then > # funniest. macro. ever. > AC_DEFINE(FLAC__HAS_GAS) > fi > > --- src.orig/libFLAC/Makefile.am 2005-02-03 05:58:13.000000000 +0100 > +++ src/libFLAC/Makefile.am 2005-02-19 14:35:39.397097392 +0100 > @@ -59,12 +59,13 @@ > ARCH_SUBDIRS = ppc > if FLaC__HAS_AS__TEMPORARILY_DISABLED > libFLAC_la_LIBADD = ppc/as/libFLAC-asm.la > +LOCAL_EXTRA_LDFLAGS = "-Wl,-read_only_relocs,warning" > else > if FLaC__HAS_GAS__TEMPORARILY_DISABLED > libFLAC_la_LIBADD = ppc/gas/libFLAC-asm.la > +LOCAL_EXTRA_LDFLAGS = "" > endif > endif > -LOCAL...

...+ if test "$GCC_MAJOR_VERSION" -ge 4 && test "$OBJ_FORMAT" = elf; then + CPPFLAGS="$CPPFLAGS -DFLAC__USE_VISIBILITY_ATTR" + CFLAGS="$CFLAGS -fvisibility=hidden" + CXXFLAGS="$CXXFLAGS -fvisibility=hidden" + fi +fi + #@@@ AM_CONDITIONAL(FLaC__HAS_AS__TEMPORARILY_DISABLED, test "yes" = "no") diff --git a/include/FLAC++/export.h b/include/FLAC++/export.h index e3bc51f..d3bd136 100644 --- a/include/FLAC++/export.h +++ b/include/FLAC++/export.h @@ -55,17 +55,22 @@ * \{ */ -#if defined(FLAC__NO_DLL) || !defined(_MSC_VER) +#if defined(FLAC__NO_D...

I spent a bit of time trying to make the configure behave. that's the result, I didn't check if the asm output runs correctly (looks forcefully disabled) but at least builds as should. lu -- Luca Barbato Gentoo/linux Developer Gentoo/PPC Operational Manager http://dev.gentoo.org/~lu_zero -------------- next part -------------- A non-text attachment was scrubbed... Name:

They are not needed since the section is defined in nasm.h. --- src/libFLAC/ia32/bitreader_asm.nasm | 4 ---- src/libFLAC/ia32/cpu_asm.nasm | 4 ---- src/libFLAC/ia32/fixed_asm.nasm | 4 ---- src/libFLAC/ia32/lpc_asm.nasm | 4 ---- src/libFLAC/ia32/stream_encoder_asm.nasm | 4 ---- 5 files changed, 20 deletions(-) diff --git