search for: flac__cpu_x86_64

In stream_encoder.c there's the following code: #if defined FLAC__CPU_X86_64 /* and other 64-bit arch, too */ if(mean <= 0x80000000/512) { /* 512: more or less optimal for both 16- and 24-bit input */ #else if(mean <= 0x80000000/8) { /* 32-bit arch: use 32-bit math if possible */ #endif A) How to properly check for 64-bit architectures? I can check fo...

.../grabbag/snprintf.c, line 42: 'on systems with a norrmal ISO C99' 'norrmal' -> 'normal' 2) src/flac/encode.c, line 1661: '(eg, very short files, < 10000 fames)' 'fames' -> frames? samples? bytes? 3) configure.ac, line 140: 'AM_CONDITIONAL(FLAC__CPU_X86_64, test "x$cpu_x86_64" = xtrue)' Not sure about this, but other names inside AM_CONDITIONALs begin with FLaC__, not FLAC__. A quote from configure.ac: "NOTE that for many of the AM_CONDITIONALs we use the prefix FLaC__ instead of FLAC__ since autoconf triggers off 'AC_' in...

> Oliver St?neberg wrote: > > > This is simply fixed by putting those unused constants into the > > proper defines. I attached a patch against git 70b078c. > > Unfortunately it breaks x86_64 build (where FLAC__CPU_X86_64 is defined, and > FLAC__CPU_IA32 isn't). Maybe it's simpler to turn them into #defines such as > > #define FLAC__CPUINFO_IA32_CPUID_CMOV 0x00008000U > #define FLAC__CPUINFO_IA32_CPUID_EXTENDED_AMD_3DNOW 0x80000000U > > and so on? Maybe - I usually don't tr...

Erik de Castro Lopo wrote: >> 3) configure.ac, line 140: 'AM_CONDITIONAL(FLAC__CPU_X86_64, test "x$cpu_x86_64" = xtrue)' >> >> Not sure about this, but other names inside AM_CONDITIONALs begin with FLaC__, >> not FLAC__. A quote from configure.ac: "NOTE that for many of the AM_CONDITIONALs >> we use the prefix FLaC__ instead of FLAC__ since aut...

It's not possible to use ia32/*.nasm code in 64-bit compiles. There's still no 64-bit asm code in FLAC. I'm not familiar with asm too, so I wrote SSE-accelerated code using intrinsics. This code uses two new preprocessor macros: FLAC__CPU_X86_64 (analogous to FLAC__CPU_IA32) and FLAC__HAS_X86INTRIN (analogous to FLAC__HAS_NASM) Patch for cpu.c/cpu.h adds CPU features (sse3, ssse3) detection code for x86-64 architecture. Another patch adds SSE-accelerated functions: FLAC__lpc_compute_autocorrelation_intrin_sse_lag_4() FLAC__lpc...

lvqcl wrote: > It's not possible to use ia32/*.nasm code in 64-bit compiles. > There's still no 64-bit asm code in FLAC. I'm not familiar with asm too, > so I wrote SSE-accelerated code using intrinsics. > > This code uses two new preprocessor macros: > FLAC__CPU_X86_64 (analogous to FLAC__CPU_IA32) Ok, I have defined FLAC__CPU_X86_64 in configure.ac. > and FLAC__HAS_X86INTRIN (analogous to FLAC__HAS_NASM) When should FLAC__HAS_X86INTRIN be defined? What header file should I be checking for? Erik -- ---------------------------------------------------------...

Oliver St?neberg wrote: >> Unfortunately it breaks x86_64 build (where FLAC__CPU_X86_64 is defined, and >> FLAC__CPU_IA32 isn't). Maybe it's simpler to turn them into #defines such as >> >> #define FLAC__CPUINFO_IA32_CPUID_CMOV 0x00008000U >> #define FLAC__CPUINFO_IA32_CPUID_EXTENDED_AMD_3DNOW 0x80000000U >> >> and so on? > >...

On 29 December 2015 at 13:33, Rafa?l Carr? <funman at videolan.org> wrote: > On 12/28/2015 08:35 PM, lvqcl wrote: >> In stream_encoder.c there's the following code: >> >> #if defined FLAC__CPU_X86_64 /* and other 64-bit arch, too */ >> if(mean <= 0x80000000/512) { /* 512: more or less optimal for both 16- and 24-bit input */ >> #else >> if(mean <= 0x80000000/8) { /* 32-bit arch: use 32-bit math if possible */ >> #endif >> >> A) How to pr...

Hi, after having some discussion of the FPU/SSE behavior on the sf.net bug tracker as well as having some other changes we made for the MAME/MESS project sitting around I thought about joining this list to make things easier. First one is the latest modification we had to make to compile with clang 3.4 x64. Here are the warnings the 1.2.1 source will give with it:

...e/stream_encoder.h @@ -37,6 +37,12 @@ #include <config.h> #endif +/* + * This is used to avoid overflow with unusual signals in 32-bit + * accumulator in the *precompute_partition_info_sums_* functions. + */ +#define FLAC__MAX_EXTRA_RESIDUAL_BPS 4 + #if (defined FLAC__CPU_IA32 || defined FLAC__CPU_X86_64) && defined FLAC__HAS_X86INTRIN #include "private/cpu.h" #include "FLAC/format.h" diff --git a/src/libFLAC/stream_encoder.c b/src/libFLAC/stream_encoder.c index e64ece2..8928a39 100644 --- a/src/libFLAC/stream_encoder.c +++ b/src/libFLAC/stream_encoder.c @@ -3872,10 +3...

Erik de Castro Lopo wrote: >> 3) configure.ac, line 140: 'AM_CONDITIONAL(FLAC__CPU_X86_64, test "x$cpu_x86_64" = xtrue)' >> >> Not sure about this, but other names inside AM_CONDITIONALs begin with FLaC__, >> not FLAC__. A quote from configure.ac: "NOTE that for many of the AM_CONDITIONALs >> we use the prefix FLaC__ instead of FLAC__ since aut...

As I wrote earlier, MSVC 2015 U2 incorrectly compiles stream_encoder_intrin_*.c files for x86-64 platform. As a result, flac works, but compression ratio is close to 1. This patch disables some compiler optimizations, and compression ratio reverts back to normal values. -------------- next part -------------- A non-text attachment was scrubbed... Name: msvc_bug.patch Type: application/octet-stream

...road. It seems that this problem with MSVC is local and only stream_encoder_intrin_*.c are affected. Or do you mean something like that -- share/compat.h: #if defined FLAC_ENABLE_MSVC2015U2_WORKAROUND1 #if (defined _MSC_VER) && (_MSC_FULL_VER == 190023918) && (defined FLAC__CPU_X86_64) #pragma optimize("g", off) /* workaround for a bug in MSVC 2015 U2 */ #endif #endif src/libFLAC/stream_encoder_intrin_*.c: #define FLAC_ENABLE_MSVC2015U2_WORKAROUND1 #include "share/compat.h" -- ? ...Not sure that share/compat.h is a right place for...

Erik de Castro Lopo wrote: > Ok, I'll take the original patch as it is. DO you have a link to a > bug report on this problem? It would be nice to put it in a comment > above the workaround. :sigh: I hoped that somebody else will find what's wrong and will create a bugreport... Well, here is the link:

The following series adds initial vector support for PowerPC64. On POWER9, flac --best is about 3.3x faster. Amitay Isaacs (2): Add m4 macro to check for C __attribute__ features Check if compiler supports target attribute on ppc64 Anton Blanchard (5): configure.ac: Remove SPE detection code configure.ac: Add VSX enable/disable configure.ac: Fix FLAC__CPU_PPC on little endian, and add