search for: flac__cpu_ia32

The #endifs are mismatched, and my builds were failing because lpc_restore_signal* weren't getting declared. I've also commented the endifs to make them easier to match. Also, is there any reason #ifdefs for FLAC__HAS_NASM and FLAC__CPU_IA32 are separate and nested the way they are and not combined like this?: #if defined(FLAC__CPU_IA32) && defined(FLAC__HAS_NASM) I'm not sure if there are portability issues with the above, though. --- orig/src/libFLAC/include/private/lpc.h +++ mod/src/libFLAC/include/private/lpc.h @@ -...

> Oliver St?neberg wrote: > > > This is simply fixed by putting those unused constants into the > > proper defines. I attached a patch against git 70b078c. > > Unfortunately it breaks x86_64 build (where FLAC__CPU_X86_64 is defined, and > FLAC__CPU_IA32 isn't). Maybe it's simpler to turn them into #defines such as > > #define FLAC__CPUINFO_IA32_CPUID_CMOV 0x00008000U > #define FLAC__CPUINFO_IA32_CPUID_EXTENDED_AMD_3DNOW 0x80000000U > > and so on? Maybe - I usually don't try to change the basics of code, but...

It's not possible to use ia32/*.nasm code in 64-bit compiles. There's still no 64-bit asm code in FLAC. I'm not familiar with asm too, so I wrote SSE-accelerated code using intrinsics. This code uses two new preprocessor macros: FLAC__CPU_X86_64 (analogous to FLAC__CPU_IA32) and FLAC__HAS_X86INTRIN (analogous to FLAC__HAS_NASM) Patch for cpu.c/cpu.h adds CPU features (sse3, ssse3) detection code for x86-64 architecture. Another patch adds SSE-accelerated functions: FLAC__lpc_compute_autocorrelation_intrin_sse_lag_4() FLAC__lpc_compute_autocorrelation_intr...

...many of the AM_CONDITIONALs >> we use the prefix FLaC__ instead of FLAC__ since autoconf triggers off 'AC_' in strings". > > I this was was a bug in and earlier version of autoconf, but I fixed > it anyway, just for the sake of uniformity. But such names (FLaC__NO_ASM, FLaC__CPU_IA32, FLaC__CPU_PPC, FLaC__USE_3DNOW, ...) begin with 'FLaC__' only in configure.ac. In all source files (.c, .h, .cpp) they begin with 'FLAC__' (all caps).

Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > The biggest of these tweaks weas to disable the intrinsics version > fero FLAC__CPU_IA32 because I couldn't get this to compile on > i386-linux (and we have the nasm versions). Still open to re-enabling > this if someone can get it to work. I know you're a skilled programmer, but... maybe you forgot to add -msse compiler option? -msse for SSE code, -msse2 for SSE2 code...

Oliver St?neberg wrote: >> Unfortunately it breaks x86_64 build (where FLAC__CPU_X86_64 is defined, and >> FLAC__CPU_IA32 isn't). Maybe it's simpler to turn them into #defines such as >> >> #define FLAC__CPUINFO_IA32_CPUID_CMOV 0x00008000U >> #define FLAC__CPUINFO_IA32_CPUID_EXTENDED_AMD_3DNOW 0x80000000U >> >> and so on? > > Maybe - I usually don't try to chan...

...for the sake of uniformity it's better to revert this commit http://git.xiph.org/?p=flac.git;a=commit;h=151739921b74fbf31420358a5fbeb094efa017ed because before it there was only one place of non-uniformity: line 140 in configure.ac, now there are several .c and .h files with all-caps FLAC__*** (FLAC__CPU_IA32, FLAC__HAS_NASM, FLaC__HAS_OGG) and suddenly FLaC__CPU_X86_64.

...src/libFLAC/include/private/stream_encoder.h @@ -37,6 +37,12 @@ #include <config.h> #endif +/* + * This is used to avoid overflow with unusual signals in 32-bit + * accumulator in the *precompute_partition_info_sums_* functions. + */ +#define FLAC__MAX_EXTRA_RESIDUAL_BPS 4 + #if (defined FLAC__CPU_IA32 || defined FLAC__CPU_X86_64) && defined FLAC__HAS_X86INTRIN #include "private/cpu.h" #include "FLAC/format.h" diff --git a/src/libFLAC/stream_encoder.c b/src/libFLAC/stream_encoder.c index e64ece2..8928a39 100644 --- a/src/libFLAC/stream_encoder.c +++ b/src/libFLAC/str...

1) src/share/grabbag/snprintf.c, line 42: 'on systems with a norrmal ISO C99' 'norrmal' -> 'normal' 2) src/flac/encode.c, line 1661: '(eg, very short files, < 10000 fames)' 'fames' -> frames? samples? bytes? 3) configure.ac, line 140: 'AM_CONDITIONAL(FLAC__CPU_X86_64, test "x$cpu_x86_64" = xtrue)' Not sure about this, but

...ot/flac/flac/src/libFLAC/bitreader.c,v retrieving revision 1.15 diff -u -r1.15 bitreader.c --- src/libFLAC/bitreader.c 28 Feb 2008 05:34:26 -0000 1.15 +++ src/libFLAC/bitreader.c 14 Mar 2008 13:19:46 -0000 @@ -149,6 +148,7 @@ FLAC__CPUInfo cpu_info; }; +#if FLAC__BYTES_PER_WORD == 4 && FLAC__CPU_IA32 #ifdef _MSC_VER /* OPT: an MSVC built-in would be better */ static _inline FLAC__uint32 local_swap32_(FLAC__uint32 x) @@ -173,6 +173,15 @@ done1: } } +#elif __GNUC__ +static void local_swap32_block_(FLAC__uint32 *start, FLAC__uint32 len) +{ + FLAC__uint32 *end; + + for(end = start + len; sta...

Hi, after having some discussion of the FPU/SSE behavior on the sf.net bug tracker as well as having some other changes we made for the MAME/MESS project sitting around I thought about joining this list to make things easier. First one is the latest modification we had to make to compile with clang 3.4 x64. Here are the warnings the 1.2.1 source will give with it:

...ndencies" and Input-> "Additional Dependencies" appropriately. Both the main app and the flac libs are build using the "runtime library" Multi-Threaded /MT (or /MTd for debug mode) The flac project is using the preprocessor definitions: WIN32 NDEBUG _LIB FLAC__HAS_OGG FLAC__CPU_IA32 FLAC__HAS_NASM FLAC__USE_3DNOW VERSION="1.2.0" FLAC__NO_DLL I'm not sure what else to try at this stage. I've reached the point where I start going in circles and accessing the same internet search results. Has anyone got any suggestions? Thanks Glenn

...+ nvals; - /* read unary part */ - while(1) { - while(cwords < br->words) { /* if we've not consumed up to a partial tail word... */ - brword b = br->buffer[cwords] << cbits; - if(b) { -#if 0 /* slower, probably due to bad register allocation... */ && defined FLAC__CPU_IA32 && !defined FLAC__NO_ASM && FLAC__BITS_PER_WORD == 32 - __asm { - bsr eax, b - not eax - and eax, 31 - mov i, eax - } -#else - i = COUNT_ZERO_MSBS(b); -#endif - uval += i; - bits = parameter; - i++; - cbits += i; - if(cbits == FLAC...

With these versions: ii autoconf 2.54-2 automatic configure script builder ii automake1.6 1.6.3-2 A tool for generating GNU Standards-complian I am unable to build the autoconfiscations. autoheader gives: autoheader2.50: error: AC_CONFIG_HEADERS not found in configure.in What versions are you using? (btw, I do think it would be a very good idea to start using

...2005 03:59:55 -0000 1.105 +++ configure.in 30 Jan 2005 05:23:53 -0000 @@ -42,7 +42,6 @@ dnl AC_CHECK_FUNCS(getopt_long , , [LIBOBJS="$LIBOBJS getopt.o getopt1.o"] ) AC_CHECK_FUNCS(getopt_long, [], []) -AC_CANONICAL_HOST case "$host_cpu" in i*86) cpu_ia32=true ; AC_DEFINE(FLAC__CPU_IA32) ;; powerpc) cpu_ppc=true ; AC_DEFINE(FLAC__CPU_PPC) ;; @@ -209,6 +208,9 @@ CFLAGS="$OUR_CFLAGS_HEAD $CFLAGS" CXXFLAGS="$OUR_CFLAGS_HEAD $CXXFLAGS" +AM_CONDITIONAL(FLaC__HAS_AS__TEMPORARILY_DISABLED, test "yes" = "no") +AM_CONDITIONAL(FLaC__HAS_GAS__TEM...

...OP Target_Dir "" # ADD BASE CPP /nologo /W3 /GX /O2 /D "WIN32" /D "NDEBUG" /D "_WINDOWS" /YX /FD /c # ADD CPP /nologo /W3 /GX /O2 /I "../../include" /I "./include" /D "WIN32" /D "NDEBUG" /D "_WINDOWS" /D "FLAC__CPU_IA32" /D "FLAC__HAS_NASM" /D "NO_VFORK" /D "STRICT" /YX /FD /c BSC32=bscmake.exe # ADD BASE BSC32 /nologo # ADD BSC32 /nologo LIB32=link.exe -lib # ADD BASE LIB32 /nologo # ADD LIB32 /nologo /out:"..\..\obj\lib\libFLAC.lib" !ELSEIF "$(CFG)" == &qu...

...th the main app and the flac libs are build using the "runtime > library" Multi-Threaded /MT (or /MTd for debug mode) > That is the MSVCR* library settings. > The flac project is using the preprocessor definitions: > > WIN32 > NDEBUG > _LIB > FLAC__HAS_OGG > FLAC__CPU_IA32 > FLAC__HAS_NASM > FLAC__USE_3DNOW > VERSION="1.2.0" > FLAC__NO_DLL > > I'm not sure what else to try at this stage. I've reached the point > where I start going in circles and accessing the same internet search > results. Has anyone got any suggestions? &...

...hanged, 1 insertion(+), 1 deletion(-) diff --git a/src/libFLAC/stream_decoder.c b/src/libFLAC/stream_decoder.c index f987c27..37934de 100644 --- a/src/libFLAC/stream_decoder.c +++ b/src/libFLAC/stream_decoder.c @@ -400,7 +400,7 @@ static FLAC__StreamDecoderInitStatus init_stream_internal_( #ifdef FLAC__CPU_IA32 FLAC__ASSERT(decoder->private_->cpuinfo.type == FLAC__CPUINFO_TYPE_IA32); #ifdef FLAC__HAS_NASM -#if 1 /*@@@@@@ OPT: not clearly faster, needs more testing */ +#if 0 /*@@@@@@ OPT: seems to be slower than FLAC__bitreader_read_rice_signed_block */ if(decoder->private_->cpuinfo.data...

...; It's not possible to use ia32/*.nasm code in 64-bit compiles. > There's still no 64-bit asm code in FLAC. I'm not familiar with asm too, > so I wrote SSE-accelerated code using intrinsics. > > This code uses two new preprocessor macros: > FLAC__CPU_X86_64 (analogous to FLAC__CPU_IA32) Ok, I have defined FLAC__CPU_X86_64 in configure.ac. > and FLAC__HAS_X86INTRIN (analogous to FLAC__HAS_NASM) When should FLAC__HAS_X86INTRIN be defined? What header file should I be checking for? Erik -- ---------------------------------------------------------------------- Erik de Castro...

...ith asm too, > so I wrote SSE-accelerated code using intrinsics. Thanks for your work on this. I've applied these patches, updated the configure script to detect the required features and then tweaked things slightly. The biggest of these tweaks weas to disable the intrinsics version fero FLAC__CPU_IA32 because I couldn't get this to compile on i386-linux (and we have the nasm versions). Still open to re-enabling this if someone can get it to work. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/