Displaying 2 results from an estimated 2 matches for "flac__cpu_have_cpuid_asm_ia32".
2016 Dec 03
2
Q: test for CPUID instruction presence
...FLAC__NO_ASM && (defined FLAC__HAS_NASM ||
FLAC__HAS_X86INTRIN)
info->use_asm = true; /* we assume a minimum of 80386 with
FLAC__CPU_IA32 */
#if FLAC__HAS_X86INTRIN
if(!FLAC__cpu_have_cpuid_x86())
return;
#else
if(!FLAC__cpu_have_cpuid_asm_ia32())
return;
#endif
I'll try to explain it:
#if !defined FLAC__NO_ASM && (defined FLAC__HAS_NASM ||
FLAC__HAS_X86INTRIN)
/* FLAC__HAS_NASM is defined,
or FLAC__HAS_X86INTRIN is set to 1, or both */
/*...
2016 Dec 05
1
Q: test for CPUID instruction presence
...ng.
>
> I propose that we release FLAC with cpu.c as it is now and deal with
> the consequences as they arise.
Makes sense.
But still... IMHO it makes sense to change "if !FLAC__HAS_X86INTRIN"
to "if defined FLAC__HAS_NASM". It covers more cases, and it's logical:
FLAC__cpu_have_cpuid_asm_ia32() can be called if (and only if) NASM is
available.
(the patch is attached just in case).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: have_cpuid.patch
Type: application/octet-stream
Size: 456 bytes
Desc: not available
URL: <http://lists.xiph.org/pipermai...