search for: flac__clz_uint32

1) FLAC supports only MSVS 2005 and newer, so (_MSC_VER >= 1400) is always true and can be removed. 2) The argument for FLAC__clz_uint32() is of FLAC__uint32 type, so FLAC__clz_soft_uint32() should have the same argument type. 3) The patch removes unnecessary parentheses around 'word' variable. 4) It also replaces "sizeof(FLAC__uint32) * CHAR_BIT - 1 - FLAC__clz_uint32(v)" with "FLAC__clz_uint32(v) ^ 31U&...

...share/endswap.h" /* Things should be fastest when this matches the machine word size */ -/* WATCHOUT: if you change this you must also change the following #defines down to COUNT_ZERO_MSBS below to match */ +/* WATCHOUT: if you change this you must also change the following #defines down to FLAC__clz_uint32 below to match */ /* WATCHOUT: there are a few places where the code will not work unless uint32_t is >= 32 bits wide */ /* also, some sections currently only have fast versions for 4 or 8 bytes per word */ #define FLAC__BYTES_PER_WORD 4 /* sizeof uint32_t */ @@ -56,27 +56,6 @@ #d...

...to FLAC__uint64 (8-byte int). IMHO it's a bug and this patch changes the type of idx variable inside FLAC__bitmath_ilog2_wide() from FLAC__uint64 to unsigned long. The type of idx variable inside FLAC__bitmath_ilog2() was also changed (from FLAC__uint32 to unsigned long), for symmetry. 2. FLAC__clz_uint32() returns the result of BitScanReverse() XOR 31. FLAC__bitmath_ilog2() returns 31-FLAC__clz_uint32() == 31-(BSR^31). As 0<=BSR<=31 so 31-(BSR^31) == BSR. But I don't think that compilers are so smart that can optimize this expression. So it is better to change FLAC__bitmath_ilog2() so it...

--- src/libFLAC/include/private/bitmath.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/libFLAC/include/private/bitmath.h b/src/libFLAC/include/private/bitmath.h index 61b0e03..d32b1a7 100644 --- a/src/libFLAC/include/private/bitmath.h +++ b/src/libFLAC/include/private/bitmath.h @@ -42,7 +42,7 @@ #endif /* Will never be emitted for MSVC, GCC, Intel compilers */

...is not true for most Unices. > However _BitScanReverse64() is called with a pointer to FLAC__uint64 > (8-byte int). IMHO it's a bug I would not call that a bug, just a result of trying to write cross platform code and relying on functions that are not specified by any standard. > 2. FLAC__clz_uint32() returns the result of BitScanReverse() XOR 31. > FLAC__bitmath_ilog2() returns 31-FLAC__clz_uint32() == 31-(BSR^31). > > As 0<=BSR<=31 so 31-(BSR^31) == BSR. But I don't think that compilers > are so smart that can optimize this expression. So it is better to change > FL...

...file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libFLAC/include/private/bitmath.h b/src/libFLAC/include/private/bitmath.h index 42ce639..e5c7695 100644 --- a/src/libFLAC/include/private/bitmath.h +++ b/src/libFLAC/include/private/bitmath.h @@ -74,7 +74,7 @@ static inline unsigned int FLAC__clz_uint32(FLAC__uint32 v) { /* Never used with input 0 */ #if defined(__INTEL_COMPILER) - return _bit_scan_reverse(n) ^ 31U; + return _bit_scan_reverse(v) ^ 31U; #elif defined(__GNUC__) && (__GNUC__ >= 4 || (__GNUC__ == 3 && __GNUC_MINOR__ >= 4)) /* This will translate either...

...9cf3288da9ec74501> <http://git.xiph.org/?p=flac.git;a=commitdiff;h=387b72731dbf79450050987b9b36bf70f286b098> <http://git.xiph.org/?p=flac.git;a=commitdiff;h=d30fe60fc616d626df2336e91bc698677a732447> that replaced bitness-agnostic brword/bwword and COUNT_ZERO_MSBS() with uint32_t and FLAC__clz_uint32() (which are apparently 32-bit only). Does it make sense to restore the ability to use FLAC__BYTES_PER_WORD == 8? (Honestly, I'm not sure that it ever worked previously... and I'm not sure that this change can improve libFLAC performance). Or is it better to change the comment that impl...

...int word) { static const unsigned char byte_to_unary_table[] = { @@ -69,6 +70,7 @@ inline unsigned int FLAC__clz_soft_uint32(unsigned int word) (word) > 0xff ? byte_to_unary_table[(word) >> 8] + 16 : byte_to_unary_table[(word)] + 24; } +#endif static inline unsigned int FLAC__clz_uint32(FLAC__uint32 v) { diff --git src/share/grabbag/Makefile.am src/share/grabbag/Makefile.am index d871b83..3fd0299 100644 --- src/share/grabbag/Makefile.am +++ src/share/grabbag/Makefile.am @@ -7,7 +7,6 @@ AM_CPPFLAGS = -I$(top_builddir) -I$(srcdir)/include -I$(top_srcdir)/include noinst_LTLIBRARIES...

...-issue-for-W.patch Type: application/octet-stream Size: 5823 bytes Desc: not available URL: <http://lists.xiph.org/pipermail/flac-dev/attachments/20170122/b0ecf40a/attachment-0004.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0006-bitmath.h-provide-a-FLAC__clz_uint32-inline-asm-solu.patch Type: application/octet-stream Size: 1291 bytes Desc: not available URL: <http://lists.xiph.org/pipermail/flac-dev/attachments/20170122/b0ecf40a/attachment-0005.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0007-lpc.c-provide-a-...