Displaying 6 results from an estimated 6 matches for "flac__assert_declaration".
2014 Nov 18
2
commit cf7d337
This commit makes MSVC to fail to compile libFLAC in debug config
with the following message:
error C2065: 'debug_target_offset' : undeclared identifier
(The removed FLAC__ASSERT_DECLARATION macros declare debug_target_offset
variable that was used in subsequent FLAC__ASSERTs)
2014 Nov 20
0
commit cf7d337
lvqcl wrote:
> This commit makes MSVC to fail to compile libFLAC in debug config
> with the following message:
>
> error C2065: 'debug_target_offset' : undeclared identifier
>
>
> (The removed FLAC__ASSERT_DECLARATION macros declare debug_target_offset
> variable that was used in subsequent FLAC__ASSERTs)
Thanks for that. I'll revert it.
Cheers,
Erik
--
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/
2017 Jan 13
0
[PATCH 1/4] Do not override CFLAGS, as CFLAGS is a user flag.
...+ b/include/FLAC/assert.h
@@ -34,7 +34,7 @@
#define FLAC__ASSERT_H
/* we need this since some compilers (like MSVC) leave assert()s on release code (and we don't want to use their ASSERT) */
-#ifdef DEBUG
+#ifndef NDEBUG
#include <assert.h>
#define FLAC__ASSERT(x) assert(x)
#define FLAC__ASSERT_DECLARATION(x) x
diff --git a/m4/ax_check_enable_debug.m4 b/m4/ax_check_enable_debug.m4
new file mode 100644
index 00000000..f99d75fe
--- /dev/null
+++ b/m4/ax_check_enable_debug.m4
@@ -0,0 +1,124 @@
+# ===========================================================================
+# http://www.gnu.org/software...
2017 Jan 15
0
[PATCH 1/2] Do not override CFLAGS, as CFLAGS is a user flag.
...+ b/include/FLAC/assert.h
@@ -34,7 +34,7 @@
#define FLAC__ASSERT_H
/* we need this since some compilers (like MSVC) leave assert()s on release code (and we don't want to use their ASSERT) */
-#ifdef DEBUG
+#ifndef NDEBUG
#include <assert.h>
#define FLAC__ASSERT(x) assert(x)
#define FLAC__ASSERT_DECLARATION(x) x
diff --git a/m4/ax_check_enable_debug.m4 b/m4/ax_check_enable_debug.m4
new file mode 100644
index 00000000..f99d75fe
--- /dev/null
+++ b/m4/ax_check_enable_debug.m4
@@ -0,0 +1,124 @@
+# ===========================================================================
+# http://www.gnu.org/software...
2017 Jan 15
4
Updated CFLAGS patches and make test compilation conditional
Hi Erik,
I've found a middleground for the problem of setting default CFLAGS. I've gone back
to setting them if {C,CXX,CPP,LD}FLAGS are unset at the onset of the configure script
(i.e., the user hasn't specified anything) and then proceed to set them to the defaults
as before. This has been suggested before:
https://lists.gnu.org/archive/html/autoconf/2006-04/msg00022.html
In
2017 Jan 13
9
Upstreaming Gentoo patches
Dear FLAC devs,
I would like to get some of our patches merged into master. Most
of them deal with adhering to GNU conventions, respectively not
overriding flags/variables that are up to the user to set. For instance,
honoring $(htmldir) is important, as we have installation paths for the
documentation that differ from what is currently coded in the various
Makefile.am's.
Regards
David