search for: flac__align_malloc_data

A preprocessor macro FLAC__ALIGN_MALLOC_DATA is defined in Makefiles but absent in *.vcproj files. This patch adds it to libFLAC_static.vcproj and libFLAC_dynamic.vcproj. -------------- next part -------------- A non-text attachment was scrubbed... Name: align_malloc.patch Type: application/octet-stream Size: 2862 bytes Desc: not available Ur...

Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > Patch applied, tested, commited and pushed. Great. But, what about my other patches? I admit that many of them aren't necessary, but (imho) a couple of them are important. I can explain in detail why I think this.

...ly :-). I'll try to redo the necessary patches with git. > * Remove restrict definition from include/share/compat.h. Applied. BTW, I tried to use 'restrict' keyword with MSVS 2010 and 2012 and in fact they don't support it. Only --restrict is supported. > * libFLAC and FLAC__ALIGN_MALLOC_DATA : Looks sane but doesn't apply. > * MSVC and M_LN2 : Looks sane but doesn't apply. It is also possible to add /D "_USE_MATH_DEFINES" as an additional option to libFLAC_static.vcproj and libFLAC_dynamic.vcproj. Don't know what is better. What do you think? > * bitmat...

With these versions: ii autoconf 2.54-2 automatic configure script builder ii automake1.6 1.6.3-2 A tool for generating GNU Standards-complian I am unable to build the autoconfiscations. autoheader gives: autoheader2.50: error: AC_CONFIG_HEADERS not found in configure.in What versions are you using? (btw, I do think it would be a very good idea to start using

...te aligned, and it complicates > things > if signal[] and residual[] are not aligned. Cool, I would appreciate any contributions you and/or Brady come up with. As for alignment, there are routines in memory.c to allocate aligned memory at 32-byte boundaries. It is turned on with a #define FLAC__ALIGN_MALLOC_DATA. Currently this is only turned on in configure.in for x86 cpu's but you can easily do it for powerpc. An asm version of FLAC__lpc_restore_signal_asm should also give a pretty good bang for the buck on the decoding side. Josh __________________________________ Do you Yahoo!? The New Yahoo!...

Op 13-11-14 om 17:45 schreef lvqcl: > FLAC__window_partial_tukey(): > > Np = (FLAC__int32)(p / 2.0f * N) - 1; > > and Np can be equal to -1. So later in the code > > for (; n < (end_n-Np); n++) > window[n] = 1.0f; > > libFLAC writes outside of window[] memory. That does the trick indeed. I still wonder how it is possible that this didn't trigger anything

...| 12 ++-- src/share/Makefile.am | 6 -- 10 files changed, 142 insertions(+), 47 deletions(-) create mode 100644 m4/ax_check_enable_debug.m4 diff --git a/configure.ac b/configure.ac index 235d2717..ba97bac0 100644 --- a/configure.ac +++ b/configure.ac @@ -205,14 +205,8 @@ AC_DEFINE(FLAC__ALIGN_MALLOC_DATA) AH_TEMPLATE(FLAC__ALIGN_MALLOC_DATA, [define to align allocated memory on 32-byte boundaries]) fi -AC_ARG_ENABLE(debug, -AC_HELP_STRING([--enable-debug], [Turn on debugging]), -[case "${enableval}" in - yes) debug=true ;; - no) debug=false ;; - *) AC_MSG_ERROR(bad value ${enableval}...

...--- src/libFLAC/memory.c 2 Feb 2007 06:58:22 -0000 1.19 +++ src/libFLAC/memory.c 15 Apr 2007 07:06:44 -0000 @@ -38,25 +38,26 @@ void *FLAC__memory_alloc_aligned(size_t bytes, void **aligned_address) { - void *x; + char *x; + unsigned increment; FLAC__ASSERT(0 != aligned_address); #ifdef FLAC__ALIGN_MALLOC_DATA /* align on 32-byte (256-bit) boundary */ x = malloc(bytes+31); - /* there's got to be a better way to do this right for all archs */ - if(sizeof(void*) == sizeof(unsigned)) - *aligned_address = (void*)(((unsigned)x + 31) & -32); - else if(sizeof(void*) == sizeof(FLAC__uint64)) - *ali...

...quot;xset" || test "x${LDFLAGS+set}" = "xset"], + [enable_flags_setting=no], + [enable_flags_setting=yes] +) +AC_MSG_RESULT([${enable_flags_setting}]) +AX_CHECK_ENABLE_DEBUG user_cflags=$CFLAGS #Prefer whatever the current ISO standard is. @@ -206,14 +213,7 @@ AC_DEFINE(FLAC__ALIGN_MALLOC_DATA) AH_TEMPLATE(FLAC__ALIGN_MALLOC_DATA, [define to align allocated memory on 32-byte boundaries]) fi -AC_ARG_ENABLE(debug, -AC_HELP_STRING([--enable-debug], [Turn on debugging]), -[case "${enableval}" in - yes) debug=true ;; - no) debug=false ;; - *) AC_MSG_ERROR(bad value ${enableval}...

Hi Erik, I've found a middleground for the problem of setting default CFLAGS. I've gone back to setting them if {C,CXX,CPP,LD}FLAGS are unset at the onset of the configure script (i.e., the user hasn't specified anything) and then proceed to set them to the defaults as before. This has been suggested before: https://lists.gnu.org/archive/html/autoconf/2006-04/msg00022.html In

Dear FLAC devs, I would like to get some of our patches merged into master. Most of them deal with adhering to GNU conventions, respectively not overriding flags/variables that are up to the user to set. For instance, honoring $(htmldir) is important, as we have installation paths for the documentation that differ from what is currently coded in the various Makefile.am's. Regards David

Hi, I have been playing with Altivec, and I rewrote a couple of the routines in assembly. Looking at the archives, I noticed that there may already be some effort on this. Anyways... Right now, I have two routines working. They need to be cleaned up, made relocatable, and documented; otherwise, they seem to work fairly well. I see an overall ~27% speed improvement when encoding with the

...AGS_HEAD $CFLAGS" CXXFLAGS="$OUR_CFLAGS_HEAD $CXXFLAGS" +AM_CONDITIONAL(FLaC__HAS_AS__TEMPORARILY_DISABLED, test "yes" = "no") +AM_CONDITIONAL(FLaC__HAS_GAS__TEMPORARILY_DISABLED, test "yes" = "no") + AM_CONFIG_HEADER(config.h) AH_TEMPLATE(FLAC__ALIGN_MALLOC_DATA, [define to align allocated memory on 32-byte boundaries]) AH_TEMPLATE(FLAC__CPU_IA32, [define if building for ia32/i386]) Index: src/flac/Makefile.am =================================================================== RCS file: /cvsroot/flac/flac/src/flac/Makefile.am,v retrieving revision 1.33...