search for: fixed_bfin

Hi Jean-Marc, I did some further checks with 1.2 beta 3: The problematic function is DIV32_16 inside fixed_bfin.h. When I comment it out (i.e. replace it by the generic version of the routine), the quality improves significantly. Nevertheless, there is still a horrible distortion when there is some overdrive/saturation in the input signal. For me, it looks like there's an instable filter which oscillates...

...My status at the moment is: - computing results for "generic" and "Blackfin ASM" versions of the DIV32_16 function are the same, there is no "algorithmic bug" - Instead, there seems some sort of memory corruption: When I comment out the DIV32_16 function inside "fixed_bfin.h", everything works fine. When I replace the DIV32_16 function inside "fixed_bfin.h" with a function, which is just a wrapper of the generic function: static inline spx_word16_t DIV32_16(spx_word32_t a, spx_word16_t b) { return DIV32_16_GENERIC ( a, b ); } (DIV32_16_GENERIC...

...1.1.12, too. I had no time in the last weeks to investigate this issue further, sorry. Hopefully, I'm able to do some more test the next days, but I have no real idea how to proceed Performance and quality seem to be o.k. for me if I deactivate the Blackfin optimizations inside the file "fixed_bfin.h". Because I am not an expert on Blackfin architecture and assembler up to now, I think it would be helpful to start some discussion with David Rowe (his blog points me to the fact he has done a lot of optimizations for Blackfin?)? If I read old posts from this mailing list and David's Bl...

...I have to look at inside the resampler function for saturation? best regards, Frank -----Urspr?ngliche Nachricht----- Von: Frank Lorenz <Frank_wtal@web.de> Gesendet: 24.01.08 15:28:49 An: speex-dev@xiph.org Betreff: FW: Re: [Speex-dev] Problem with Blackfin assembly optimizations -- bug in fixed_bfin.h? Hi Jean-Marc, I did some further checks with 1.2 beta 3: The problematic function is DIV32_16 inside fixed_bfin.h. When I comment it out (i.e. replace it by the generic version of the routine), the quality improves significantly. Nevertheless, there is still a horrible distortion when there is...

Hi, I just started to examine the DIV32_16 function (Blackfin ASM version), and wondered why the return value of the function inside 'fixed_bfin.h' is of type 'spx_word16_t', but the local variable 'res' which is returned by this function is of type 'spx_word32_t'. Is this a trick of optimization or a bug? (Same question for PDIV32_16 and MAX16, too!) best regards, Frank -----Urspr?ngliche Nachricht----- Von:...

...detection) fails -- the signal sounds like the speaker has a very ugly sore throat). I tried to deactivate each part of the optimizaitions inside the libspeex directory, one after another. Most of the "turn-offs" doesn't have any effect. When turning off the optimizations inside "fixed_bfin.h", there is a big improvement -- the decoded speech sounds good again, only on some positions in my speech signal is a huge "click" which sounds like an overdrive caused by an instable filter. When trying to switch off the optimizations from "filters_bfin.h", my little p...

...pr?ngliche Nachricht----- Von: "Jean-Marc Valin" > <jean-marc.valin@usherbrooke.ca> Gesendet: 01.02.08 12:11:39 An: > Frank Lorenz <Frank_wtal@web.de> CC: speex-dev@xiph.org Betreff: Re: > FW: Re: [Speex-dev] Problem with Blackfin assembly optimizations -- > bug in fixed_bfin.h / resampler saturation??? > > > Frank Lorenz a ?crit : >> didn't get a reply to my last post (see below) -- do you have no >> idea what happens here? > > Sorry, been quite busy lately. Still have a backlog of things to > respond to (sorry to others as well), s...

...t regards, Frank -----Urspr?ngliche Nachricht----- Von: "Jean-Marc Valin" <jean-marc.valin@usherbrooke.ca> Gesendet: 08.02.08 21:50:56 An: Frank Lorenz <Frank_wtal@web.de> CC: speex-dev@xiph.org Betreff: Re: [Speex-dev] Problem with Blackfin assembly optimizations -- bug in fixed_bfin.h / resampler saturation??? Frank Lorenz a ?crit : > Yes, this is another point: I wrote that the resampler breaks, but > this is not the case. Instead, the speex encoder corrupts its input > buffer when the "DIV32_16 bug" described above happens. Do you have > any idea how...

...st regards, Frank -----Urspr?ngliche Nachricht----- Von: "Jean-Marc Valin" <jean-marc.valin@usherbrooke.ca> Gesendet: 12.02.08 22:49:49 An: Frank Lorenz <Frank_wtal@web.de> CC: speex-dev@xiph.org Betreff: Re: [Speex-dev] Problem with Blackfin assembly optimizations -- bug in fixed_bfin.h / resampler saturation??? OK, a few things got accidentally broken. I've partially fixed it in svn/git (the limitation is that you can't link with both libspeex and libspeexdsp if configured as fixed-point debug). Can you compile/test now? Jean-Marc Frank Lorenz a ?crit : > Hi, &...

...2.02.08 22:49:49 An: > Frank Lorenz <Frank_wtal at web.de <http://lists.xiph.org/mailman/listinfo/speex-dev> > CC: speex-dev at xiph.org <http://lists.xiph.org/mailman/listinfo/speex-dev> Betreff: Re: > [Speex-dev] Problem with Blackfin assembly optimizations -- bug in > fixed_bfin.h / resampler saturation??? > > > OK, a few things got accidentally broken. I've partially fixed it in > svn/git (the limitation is that you can't link with both libspeex and > libspeexdsp if configured as fixed-point debug). > > Can you compile/test now? > &gt...

...ery incomplete compared with how many asm statements actually use hardware loops. Signed-off-by: Mike Frysinger <vapier at gentoo.org> --- libspeex/bfin.h | 15 +++++++++++++++ libspeex/cb_search_bfin.h | 9 ++++----- libspeex/filters_bfin.h | 15 ++++++++++----- libspeex/fixed_bfin.h | 15 +++++++++------ libspeex/lpc_bfin.h | 5 ++++- libspeex/lsp_bfin.h | 2 +- libspeex/ltp_bfin.h | 25 ++++++++++--------------- libspeex/misc_bfin.h | 4 +++- libspeex/quant_lsp_bfin.h | 7 +++++-- libspeex/vq_bfin.h | 7 +++++-- 10 files...

...a, spx_word16_t b) { spx_word32_t res; __asm__ ( "%1 = %1.L (X);\n\t" "%2 = %2.L (X);\n\t" "%0 = MAX(%1,%2);" : "=d" (res) : "%d" (a), "d" (b) ); return res; } --- Compiler says: "libspeex\fixed_bfin.h", line 48: cc1101: error: invalid constraint in asm statement : "%d" (a), "d" (b) ^ Following modification successfully passed: : "d" (a), "d" (b) Similarly, compiler doesn't understand the following line: : "=m" (res...

...122,8 @@ static OPUS_INLINE opus_int16 SAT16(opus_int32 x) { #include "arm/fixed_armv5e.h" #elif defined (OPUS_ARM_INLINE_ASM) #include "arm/fixed_armv4.h" +#elif defined (OPUS_ARM64_INLINE_ASM) +#include "arm/fixed_arm64.h" #elif defined (BFIN_ASM) #include "fixed_bfin.h" #elif defined (TI_C5X_ASM) diff --git a/celt/arm/fixed_arm64.h b/celt/arm/fixed_arm64.h new file mode 100644 index 0000000..7fa413b --- /dev/null +++ b/celt/arm/fixed_arm64.h @@ -0,0 +1,75 @@ +/* Copyright (C) 2014 Vidyo */ +/* + Redistribution and use in source and binary forms, with or...

...122,8 @@ static OPUS_INLINE opus_int16 SAT16(opus_int32 x) { #include "arm/fixed_armv5e.h" #elif defined (OPUS_ARM_INLINE_ASM) #include "arm/fixed_armv4.h" +#elif defined (OPUS_ARM64_INLINE_ASM) +#include "arm/fixed_arm64.h" #elif defined (BFIN_ASM) #include "fixed_bfin.h" #elif defined (TI_C5X_ASM) diff --git a/celt/arm/fixed_arm64.h b/celt/arm/fixed_arm64.h new file mode 100644 index 0000000..7fa413b --- /dev/null +++ b/celt/arm/fixed_arm64.h @@ -0,0 +1,75 @@ +/* Copyright (C) 2014 Vidyo */ +/* + Redistribution and use in source and binary forms, with or...

...ne by one and decide whether they help performance in specific case of ADI tools. It seem probable that in many if not most of the cases it would be better to use ADI built in functions or even leave the code in plain "C". For example, intuitively, I'd say that the whole content of fixed_bfin.h is better left in "C". Jean Marc equipped for that job much better than everyone else. Of course, he would have to convince Analog to sponsor his effort and to give him full version of VisualDSP for free. But since they did it once they are likely to do it again. I would very much like...

Here some Blackfin inline assembly, mainly picked and adapted from speex. It's helps a little on my BF537 eval board. Julien -------- /** @file fixed_bfin.h @brief Fixed-point operations for the ADI BF5xx DSP family */ /* Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: - Redistributions of source code must retain the above copyright no...

Hi Jean-Marc I'm trying to integrate your speex codec on our custom Blackfin board. The board is not uCLinux compatible and there is no chance that it will ever be. I am using ADI-supplied VisualDSP++ IDE and corresponding toolchain. As long as I am compiling "C"-only version of the library everything is fine. VisualDSP++ produces working library. There is only one not so minor

...nstraint valid for any architecture, which are defined: > >http://gcc.gnu.org/onlinedocs/gcc-4.2.0/gcc/Simple-Constraints.html#Simple-Constraints > >`m' A memory operand is allowed, with any kind of address that the machine > supports in general. > >> "libspeex\fixed_bfin.h", line 48: cc1101: error: invalid constraint in asm >> statement >> >> : "%d" (a), "d" (b) >> >> ^ > >Have a look at: > >http://gcc.gnu.org/onlinedocs/gcc-4.2.0/gcc/Modifiers.html#Modifiers > >`%' Declares...

...EDSP +#if defined(OPUS_ARM_INLINE_EDSP) && defined(FIXED_POINT) #include "arm/fixed_armv5e.h" -#elif defined (OPUS_ARM_INLINE_ASM) +#elif defined(OPUS_ARM_INLINE_ASM) && defined(FIXED_POINT) #include "arm/fixed_armv4.h" #elif defined (BFIN_ASM) #include "fixed_bfin.h" diff --git a/celt/arm/arm_celt_map.c b/celt/arm/arm_celt_map.c index 547a84d..a6313e7 100644 --- a/celt/arm/arm_celt_map.c +++ b/celt/arm/arm_celt_map.c @@ -42,8 +42,19 @@ opus_val32 (*const CELT_PITCH_XCORR_IMPL[OPUS_ARCHMASK+1])(const opus_val16 *, MAY_HAVE_NEON(celt_pitch_xcorr) /*...

....c + libspeex/window.c + libspeex/arch.h + libspeex/bfin.h + libspeex/cb_search_arm4.h + libspeex/cb_search_bfin.h + libspeex/cb_search_sse.h + libspeex/filters.h + libspeex/filters_arm4.h + libspeex/filters_bfin.h + libspeex/filters_sse.h + libspeex/fixed_arm4.h + libspeex/fixed_arm5e.h + libspeex/fixed_bfin.h + libspeex/fixed_debug.h + libspeex/lpc.h + libspeex/lpc_bfin.h + libspeex/ltp.h + libspeex/ltp_arm4.h + libspeex/ltp_sse.h + libspeex/math_approx.h + libspeex/misc_bfin.h + libspeex/nb_celp.h + libspeex/quant_lsp.h + libspeex/sb_celp.h + libspeex/stack_alloc.h + libspeex/vbr.h + libspeex/vq.h +...