search for: fix_features

Buggy host may advertised buggy host features (a usual case is that host advertise a feature whose dependencies were missed). In this case, driver should detect and disable the buggy features by itself. This patch introduces driver specific fix_features() method which is called just before features finalizing to detect and disable buggy features advertised by host. Virtio-net will be the first user. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat...

Buggy host may advertised buggy host features (a usual case is that host advertise a feature whose dependencies were missed). In this case, driver should detect and disable the buggy features by itself. This patch introduces driver specific fix_features() method which is called just before features finalizing to detect and disable buggy features advertised by host. Virtio-net will be the first user. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat...

Buggy host may advertised buggy host features (a usual case is that host advertise a feature whose dependencies were missed). In this case, driver should detect and disable the buggy features by itself. This patch introduces driver specific fix_features() method which is called just before features finalizing to detect and disable buggy features advertised by host. Virtio-net will be the first user. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat...

Buggy host may advertised buggy host features (a usual case is that host advertise a feature whose dependencies were missed). In this case, driver should detect and disable the buggy features by itself. This patch introduces driver specific fix_features() method which is called just before features finalizing to detect and disable buggy features advertised by host. Virtio-net will be the first user. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat...

...ubject-prefix: s/virito/virtio/ > Buggy host may advertised buggy host features (a usual case is that host > advertise a feature whose dependencies were missed). In this case, driver > should detect and disable the buggy features by itself. > > This patch introduces driver specific fix_features() method which is called > just before features finalizing to detect and disable buggy features > advertised by host. So the basic problem this patch fixes is that an individual driver may only specify a static set of features but cannot specify any dependencies, right? Adding a sanitizer st...

...detect the possible buggy features advertised by host > and fix them. One example is booting virtio-net with only ctrl_vq disabled, > qemu may still advertise many features which depends on it. This will > trigger several BUG()s in virtnet_send_command(). > > This patch utilizes the fix_features() method, and disables all features that > depends on ctrl_vq if it was not advertised. > > This fixes the crash when booting with ctrl_vq=off. > > Cc: Rusty Russell <rusty at rustcorp.com.au> > Cc: Michael S. Tsirkin <mst at redhat.com> > Signed-off-by: Jason Wan...

...detect the possible buggy features advertised by host > and fix them. One example is booting virtio-net with only ctrl_vq disabled, > qemu may still advertise many features which depends on it. This will > trigger several BUG()s in virtnet_send_command(). > > This patch utilizes the fix_features() method, and disables all features that > depends on ctrl_vq if it was not advertised. > > This fixes the crash when booting with ctrl_vq=off. > > Cc: Rusty Russell <rusty at rustcorp.com.au> > Cc: Michael S. Tsirkin <mst at redhat.com> > Signed-off-by: Jason Wan...

...correct this. >> Buggy host may advertised buggy host features (a usual case is that host >> advertise a feature whose dependencies were missed). In this case, driver >> should detect and disable the buggy features by itself. >> >> This patch introduces driver specific fix_features() method which is called >> just before features finalizing to detect and disable buggy features >> advertised by host. > So the basic problem this patch fixes is that an individual driver may > only specify a static set of features but cannot specify any > dependencies, right?...

...correct this. >> Buggy host may advertised buggy host features (a usual case is that host >> advertise a feature whose dependencies were missed). In this case, driver >> should detect and disable the buggy features by itself. >> >> This patch introduces driver specific fix_features() method which is called >> just before features finalizing to detect and disable buggy features >> advertised by host. > So the basic problem this patch fixes is that an individual driver may > only specify a static set of features but cannot specify any > dependencies, right?...

...rted by netfront Netback works by first setting all possible features, and then resetting some after connection, if the front-end didn''t negotiate them. Except that in the old 2.6.18 tree the "resetting" part was missing. In the pvops tree, this should work correctly through the fix_features mechanism. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> diff --git a/drivers/xen/netback/interface.c b/drivers/xen/netback/interface.c --- a/drivers/xen/netback/interface.c +++ b/drivers/xen/netback/interface.c @@ -98,8 +98,9 @@ static int netbk_change_mtu(struct net_d void netif_set...

This patch tries to detect the possible buggy features advertised by host and fix them. One example is current booting virtio-net with only ctrl_vq disabled, qemu may still advertise many features which depends it. This will trigger several BUG()s in virtnet_send_command(). This patch utilizes the fix_features() method, and disable all features that depends on ctrl_vq if it was not advertised. This fixes the crash when booting with ctrl_vq=off. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat.com> ---...

This patch tries to detect the possible buggy features advertised by host and fix them. One example is booting virtio-net with only ctrl_vq disabled, qemu may still advertise many features which depends on it. This will trigger several BUG()s in virtnet_send_command(). This patch utilizes the fix_features() method, and disables all features that depends on ctrl_vq if it was not advertised. This fixes the crash when booting with ctrl_vq=off. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --...

This patch tries to detect the possible buggy features advertised by host and fix them. One example is current booting virtio-net with only ctrl_vq disabled, qemu may still advertise many features which depends it. This will trigger several BUG()s in virtnet_send_command(). This patch utilizes the fix_features() method, and disable all features that depends on ctrl_vq if it was not advertised. This fixes the crash when booting with ctrl_vq=off. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat.com> ---...

...detect the possible buggy features advertised by host > and fix them. One example is booting virtio-net with only ctrl_vq disabled, > qemu may still advertise many features which depends on it. This will > trigger several BUG()s in virtnet_send_command(). > > This patch utilizes the fix_features() method, and disables all features that > depends on ctrl_vq if it was not advertised. > > This fixes the crash when booting with ctrl_vq=off. That's a qemu device property, right? Might want to mention that, as this line sounds like it is a kernel parameter. > > Cc: Rusty R...

...detect the possible buggy features advertised by host > and fix them. One example is booting virtio-net with only ctrl_vq disabled, > qemu may still advertise many features which depends on it. This will > trigger several BUG()s in virtnet_send_command(). > > This patch utilizes the fix_features() method, and disables all features that > depends on ctrl_vq if it was not advertised. > > This fixes the crash when booting with ctrl_vq=off. That's a qemu device property, right? Might want to mention that, as this line sounds like it is a kernel parameter. > > Cc: Rusty R...

...usty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Cornelia Huck <cornelia.huck at de.ibm.com> Cc: Wanlong Gao <gaowanlong at cn.fujitsu.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- Changes from V2: - fix typo - rename fix_features to sanitize_features --- drivers/virtio/virtio.c | 4 ++++ include/linux/virtio.h | 1 + include/linux/virtio_config.h | 12 ++++++++++++ 3 files changed, 17 insertions(+) diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index df598dd..6a86b4f 100644 --- a/drivers/vir...

...usty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Cornelia Huck <cornelia.huck at de.ibm.com> Cc: Wanlong Gao <gaowanlong at cn.fujitsu.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- Changes from V2: - fix typo - rename fix_features to sanitize_features --- drivers/virtio/virtio.c | 4 ++++ include/linux/virtio.h | 1 + include/linux/virtio_config.h | 12 ++++++++++++ 3 files changed, 17 insertions(+) diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index df598dd..6a86b4f 100644 --- a/drivers/vir...

...Huck <cornelia.huck at de.ibm.com> > Cc: Wanlong Gao <gaowanlong at cn.fujitsu.com> > Signed-off-by: Jason Wang <jasowang at redhat.com> Hmm this conflicts with virtio 1.0 work: we drop features as bitmap there. > --- > Changes from V2: > - fix typo > - rename fix_features to sanitize_features > --- > drivers/virtio/virtio.c | 4 ++++ > include/linux/virtio.h | 1 + > include/linux/virtio_config.h | 12 ++++++++++++ > 3 files changed, 17 insertions(+) > > diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c > index d...