search for: firstnondebuginstr

...he indentation uses 4 or more spaces instead of the preferred two. - There's commented out code in both c++ source and the .td files. Please either document why it's commented out or remove the code. "//FIXME: gcc complains on this." isn't helpful at all. - Macros like #define FirstNonDebugInstr(A) A->begin() are not only confusing, the name also says something that the definition doesn't provide. Please audit the macros and change them to UPPERCASE so it's obvious that there's some macro magic at work. Overall I think this should go in as soon as possible. It has been arou...

Moving this thread to llvmdev. On Tue, Oct 30, 2012 at 11:09:34PM -0700, Chris Lattner wrote: > On Oct 30, 2012, at 11:35 AM, Tom Stellard <tom at stellard.net> wrote: > >> Hi Tom, > >> > >> Time is running short, but this would be great. The best place to start is to begin decomposing the mega-patch into individual pieces that makes sense. Do you have

...uses 4 or more spaces instead of the preferred two. > - There's commented out code in both c++ source and the .td files. Please either document why it's commented out or remove the code. "//FIXME: gcc complains on this." isn't helpful at all. > - Macros like > #define FirstNonDebugInstr(A) A->begin() > are not only confusing, the name also says something that the definition doesn't provide. Please audit the macros and change them to UPPERCASE so it's obvious that there's some macro magic at work. > I've made these changes and also renamed the directory f...

...re spaces instead of the preferred two. >> - There's commented out code in both c++ source and the .td files. Please either document why it's commented out or remove the code. "//FIXME: gcc complains on this." isn't helpful at all. >> - Macros like >> #define FirstNonDebugInstr(A) A->begin() >> are not only confusing, the name also says something that the definition doesn't provide. Please audit the macros and change them to UPPERCASE so it's obvious that there's some macro magic at work. >> > > I've made these changes and also renam...

...vm/CodeGen/MachineInstrBuilder.h" > +#include "llvm/CodeGen/MachineJumpTableInfo.h" > +#include "llvm/CodeGen/MachineLoopInfo.h" > +#include "llvm/CodeGen/MachineRegisterInfo.h" > +#include "llvm/Target/TargetInstrInfo.h" > + > +#define FirstNonDebugInstr(A) A->begin() > +using namespace llvm; > + > +// TODO: move-begin. > + > +//===----------------------------------------------------------------------===// > +// > +// Statistics for CFGStructurizer. > +// > +//===--------------------------------------------------------...