search for: firstboot_service

...$f -done +if test \"$1\" = \"start\" +then + for f in $d/* ; do + if test -x \"$f\" + then + echo '=== Running' $f '===' >>$logfile + $f >>$logfile 2>&1 + rm -f $f + fi + done +fi " firstboot_dir let firstboot_service = sprintf "\ @@ -56,7 +77,7 @@ WantedBy=default.target let failed fs = ksprintf (fun msg -> failwith (s_"firstboot: failed: " ^ msg)) fs -let rec install_service g root = +let rec install_service g distro = g#mkdir_p firstboot_dir; g#mkdir_p (sprintf "%s/scripts&q...

..._done echo '=== Running' $f '===' 2>&1 | tee $logfile - $f 2>&1 | tee $logfile - rm -f $f + $d_done/$(basename $f) 2>&1 | tee $logfile fi done + rm -f $d_done/* fi -" firstboot_dir +" firstboot_dir firstboot_dir let firstboot_service = sprintf "\ [Unit] -- 1.9.3

...firstboot.ml | 74 ++++++++++++++++++++++++++++++++++++-------------- 1 file changed, 54 insertions(+), 20 deletions(-) diff --git a/customize/firstboot.ml b/customize/firstboot.ml index f1e5807..52dfbbe 100644 --- a/customize/firstboot.ml +++ b/customize/firstboot.ml @@ -82,7 +82,7 @@ fi let firstboot_service = sprintf "\ [Unit] -Description=virt-sysprep firstboot service +Description=libguestfs firstboot service After=network.target Before=prefdm.service @@ -122,10 +122,27 @@ WantedBy=default.target *) let unitdir = "/usr/lib/systemd/system" in g#mkdir_p unitdir; -...

...27 @@ WantedBy=default.target *) let unitdir = "/usr/lib/systemd/system" in g#mkdir_p unitdir; - let unitfile = sprintf "%s/firstboot.service" unitdir in + let unitfile = sprintf "%s/virt-sysprep-firstboot.service" unitdir in g#write unitfile firstboot_service; g#mkdir_p "/etc/systemd/system/default.target.wants"; - g#ln_sf unitfile "/etc/systemd/system/default.target.wants" + g#ln_sf unitfile "/etc/systemd/system/default.target.wants"; + + (* Try to remove the old firstboot.service files. *) + let oldunitfi...

....ml b/customize/firstboot.ml index 35cb87c2b..bd4f7850f 100644 --- a/customize/firstboot.ml +++ b/customize/firstboot.ml @@ -80,7 +80,7 @@ then fi " firstboot_dir firstboot_dir - let systemd_target = "default.target" + let systemd_target = "multi-user.target" let firstboot_service = sprintf "\ [Unit] -- 2.13.2

...> *) > let unitdir = "/usr/lib/systemd/system" in > g#mkdir_p unitdir; > - let unitfile = sprintf "%s/firstboot.service" unitdir in > + let unitfile = sprintf "%s/virt-sysprep-firstboot.service" unitdir in > g#write unitfile firstboot_service; > g#mkdir_p "/etc/systemd/system/default.target.wants"; > - g#ln_sf unitfile "/etc/systemd/system/default.target.wants" > + g#ln_sf unitfile "/etc/systemd/system/default.target.wants"; > + > + (* Try to remove the old firstboot.service fil...

If a script does not finish, hangs, etc, it would be executed again at the next boot, since the injected firstboot.sh helper removes it only after it finished. Since firstboot.sh only runs executable files, then remove the executable attributes before running it, so it will not run again. Also, remove any file found in the scripts subdirectory, be it just run or run in a previous boot. This

In the TODO file there's a discussion of perhaps writing a new 'virt-customize' tool. I think it's probably better (or at any rate, easier) to just add this functionality into virt-sysprep. That is what this small series of patches aims to achieve. Note these are not very well tested at the moment. The first patch adds a generic and useful '--firstboot' flag. The

See: https://bugzilla.redhat.com/show_bug.cgi?id=1469655 https://github.com/systemd/systemd/issues/6334 https://lists.freedesktop.org/archives/systemd-devel/2017-July/039325.html

v1: https://www.redhat.com/archives/libguestfs/2017-July/msg00127.html v2: - Remove /etc/systemd/system/default.target.wants/guestfs-firstboot.service link as well. - Use multi-user.target for virt-p2v as well. Rich.

There's not going to be an easy way to present this patch. It's huge and interconnected. Anyway, what it does is lay the groundwork for a new tool which I'm calling 'virt-customize'. virt-customize is virt-builder, but without the part where it downloads a template from a respository. Just the part where it customizes the template, that is, installing packages, editing