search for: first_version

...(* The first stable version that the symbol appeared in, for * example (1, 2) if the symbol was added in development cycle - * 1.1.x and thus the first stable version was 1.2 + * 1.1.x and thus the first stable version was 1.2. This is + * filled in by the generator, add new calls to the first_version + * table instead. *) - first_version : int * int; + mutable first_version : int * int; } and arg = | Bool of string (* bool *) @@ -916,7 +918,7 @@ let default_call = { args = []; optargs = []; ret = RErr; see_also = []; permitted_sta...

This doesn't include Eric's new APIs, but if you push those then I can rebase this one on top. Rich.

...100755 --- a/generator/generator +++ b/generator/generator @@ -1243,6 +1243,36 @@ Get the current TLS PSK filename."; }; *) + "set_request_structured_replies", { + default_call with + args = [Bool "request"]; ret = RErr; + permitted_states = [ Created ]; + first_version = (1, 2); + shortdesc = "control use of structured replies"; + longdesc = "\ +By default, libnbd tries to negotiate structured replies with the +server, as this protocol extension must be in use before +C<nbd_can_meta_context> or C<nbd_can_df> can return true. Howe...

...e option does more clearly. Anyway this looks fine to me. ACK I have one comment unrelated to the patch: > + "set_request_structured_replies", { > + default_call with > + args = [Bool "request"]; ret = RErr; > + permitted_states = [ Created ]; > + first_version = (1, 2); I just know that we're going to end up adding new APIs and forgetting to set the first_version field. There are various things we could do to prevent this: (1) In ‘default_call’ set first_version = (0, 0). Update all existing calls with first_version = (1, 0). Then add a check th...

...nes wrote: > See discussion in this and following messages: > https://www.redhat.com/archives/libguestfs/2019-September/msg00020.html > --- > generator/generator | 131 ++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 121 insertions(+), 10 deletions(-) > > +let first_version = [ > + "set_debug", (1, 0); > + "get_debug", (1, 0); > + "set_debug_callback", (1, 0); > + "clear_debug_callback", (1, 0); > + "set_handle_name", (1, 0); > + "get_handle_name", (1, 0); > + "set_export_name...

This patch adds support for symbol versions. It is based on what libvirt does. The generated syms file looks like: LIBNBD_1.0 { global: nbd_...; nbd_...; local: *; }; In a future stable 1.2 release, new symbols would go into a new section which would look like this: LIBNBD_1.2 { global: nbd_new_symbol; nbd_another_new_symbol; local: *; } LIBNBD_1.0; In my testing the

--- generator/generator | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/generator/generator b/generator/generator index 1252bdb..13cb0b9 100755 --- a/generator/generator +++ b/generator/generator @@ -3121,6 +3121,31 @@ let () = failwithf "%s: first_version must be 1.x" name; if minor mod 2 <> 0 then failwithf "%s: first_version must refer to a stable release" name + ) handle_calls; + + (* Because of the way we use completion free callbacks to + * free persistent buffers in non-C languages, any function + * w...

...+++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/generator/generator b/generator/generator > index 1252bdb..13cb0b9 100755 > --- a/generator/generator > +++ b/generator/generator > @@ -3121,6 +3121,31 @@ let () = > failwithf "%s: first_version must be 1.x" name; > if minor mod 2 <> 0 then > failwithf "%s: first_version must refer to a stable release" name > + ) handle_calls; > + > + (* Because of the way we use completion free callbacks to > + * free persistent buffers in non-C l...

...as server in guest, and then connect libnbd as client on host? Then add 'nbdkit nbd vsock=...' to let the nbdkit pass-through wrapper convert vsock from guest into TCP or Unix socket on the host to other host clients that don't know how to do vsock. > @@ -2793,6 +2836,8 @@ let first_version = [ > "aio_connect_systemd_socket_activation", (1, 2); > "connect_socket", (1, 2); > "aio_connect_socket", (1, 2); > + "connect_vsock", (1, 2); > + "aio_connect_vsock", (1, 2); > As this is Linux-only (and for tha...

...++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/generator/generator b/generator/generator index 7d3f656..ad1cb6b 100755 --- a/generator/generator +++ b/generator/generator @@ -4487,7 +4487,8 @@ let generate_docs_nbd_pod name { args; optargs; ret; first_version = (major, minor) } () = pr "=head1 NAME\n"; pr "\n"; - pr "nbd_%s - %s\n" name shortdesc; + pr_wrap ' ' (fun () -> pr "nbd_%s - %s" name shortdesc); + pr "\n"; pr "\n"; pr "=head1 SYNOPSIS\n"; -- 2.23...

...ous commands"; - Link "can_meta_context"; Link "block_status"]; + Link "can_meta_context"; Link "block_status"; + Link "get_init_flags"]; }; "aio_get_fd", { @@ -3031,6 +3057,7 @@ let first_version = [ "set_uri_allow_transports", (1, 2); "set_uri_allow_tls", (1, 2); "set_uri_allow_local_file", (1, 2); + "get_init_flags", (1, 2); (* These calls are proposed for a future version of libnbd, but * have not been added to any released versio...

...st? Then add 'nbdkit nbd vsock=...' > to let the nbdkit pass-through wrapper convert vsock from guest into > TCP or Unix socket on the host to other host clients that don't know > how to do vsock. I'm afraid I don't understand this. > >@@ -2793,6 +2836,8 @@ let first_version = [ > > "aio_connect_systemd_socket_activation", (1, 2); > > "connect_socket", (1, 2); > > "aio_connect_socket", (1, 2); > >+ "connect_vsock", (1, 2); > >+ "aio_connect_vsock", (1, 2); > > As this is L...

...dshake_flags(3)>"]; + see_also = ["L<nbd_get_handshake_flags(3)>"; + "L<nbd_get_structured_replies_negotiated(3)>"; + "L<nbd_get_tls_negotiated(3)>"]; }; "get_size", { @@ -2654,6 +2673,7 @@ let first_version = [ "can_fast_zero", (1, 2); "set_request_structured_replies", (1, 2); "get_request_structured_replies", (1, 2); + "get_structured_replies_negotiated", (1, 2); "get_tls_negotiated", (1, 2); "get_protocol", (1, 2); "...

...e) the connection +would have failed if TLS could not be negotiated, and in +C<LIBNBD_TLS_DISABLE> mode TLS is not tried."; + see_also = ["L<nbd_set_tls(3)>"; "L<nbd_get_tls(3)>"]; }; "set_tls_certificates", { @@ -2527,6 +2552,7 @@ let first_version = [ "can_fast_zero", (1, 2); "set_request_structured_replies", (1, 2); "get_request_structured_replies", (1, 2); + "get_tls_negotiated", (1, 2); (* These calls are proposed for a future version of libnbd, but * have not been added to any re...

This is a series of patches to libnbd and nbdkit adding AF_VSOCK support. On the host side it allows you to start an nbdkit instance which listens on a virtio-vsock socket: $ ./nbdkit -fv --vsock memory 1G ... nbdkit: debug: bound to vsock 2:10809 On the guest side you can then use libnbd to connect to the server: $ ./run nbdsh -c 'h.connect_vsock(2, 10809)' -c

...["L<nbd_set_handshake_flags(3)>"; + "L<nbd_aio_is_created(3)>"; "L<nbd_aio_is_ready(3)>"]; + }; + "add_meta_context", { default_call with args = [ String "name" ]; ret = RErr; @@ -2521,6 +2589,8 @@ let first_version = [ "can_fast_zero", (1, 2); "set_request_structured_replies", (1, 2); "get_request_structured_replies", (1, 2); + "set_handshake_flags", (1, 2); + "get_handshake_flags", (1, 2); (* These calls are proposed for a future version of lib...

This is a combination of these two earlier series: https://www.redhat.com/archives/libguestfs/2019-August/msg00235.html https://www.redhat.com/archives/libguestfs/2019-August/msg00240.html plus changes to allow .callback = NULL / .free != NULL, and to reduce the complexity of freeing callbacks. Although it's rather long there's nothing complex here. We might consider squashing some

...newstyle-fixed\">. Other strings might +be returned in future. Most modern NBD servers use C<\"newstyle-fixed\">. +" +^ non_blocking_test_call_description + }; + "get_size", { default_call with args = []; ret = RInt64; @@ -2553,6 +2577,7 @@ let first_version = [ "set_request_structured_replies", (1, 2); "get_request_structured_replies", (1, 2); "get_tls_negotiated", (1, 2); + "get_protocol", (1, 2); (* These calls are proposed for a future version of libnbd, but * have not been added to any rel...

...t; transport +using L<nbd_set_uri_allow_transports(3)>. + +=item Read from local files + +Default: denied + +To allow URIs to contain references to local files +(eg. for parameters like C<tls-psk-file>) call +L<nbd_set_uri_allow_local_file(3)>. =back @@ -2900,6 +3020,9 @@ let first_version = [ "aio_connect_socket", (1, 2); "connect_vsock", (1, 2); "aio_connect_vsock", (1, 2); + "set_uri_allow_transports", (1, 2); + "set_uri_allow_tls", (1, 2); + "set_uri_allow_local_file", (1, 2); (* These calls are proposed...

...status"; Link "can_meta_context"; + Link "add_meta_context"; Link "get_nr_meta_contexts"; + Link "get_meta_context"; Link "set_opt_mode"]; }; "set_uri_allow_transports", { @@ -2814,6 +2881,9 @@ let first_version = [ (* Added in 1.5.x development cycle, will be stable and supported in 1.6. *) "set_strict_mode", (1, 6); "get_strict_mode", (1, 6); + "get_nr_meta_contexts", (1, 6); + "get_meta_context", (1, 6); + "clear_meta_contexts", (1, 6); (...