search for: finished_success

...if transfer is None: + disk_service = h['disk_service'] + disk = disk_service.get() + if disk.status == types.DiskStatus.OK: + continue + + if transfer.phase == types.ImageTransferPhase.FINISHED_SUCCESS: + debug("finalized after %s seconds", time.time() - start) + break + + if transfer.phase == types.ImageTransferPhase.FINALIZING_SUCCESS: + if time.time() > start + timeout: + raise RuntimeEr...

...): + pass + + id = 123 + status = DiskStatus.OK + +class ImageTransferPhase(Enum): + CANCELLED = 'cancelled' + FINALIZING_FAILURE = 'finalizing_failure' + FINALIZING_SUCCESS = 'finalizing_success' + FINISHED_FAILURE = 'finished_failure' + FINISHED_SUCCESS = 'finished_success' + INITIALIZING = 'initializing' + PAUSED_SYSTEM = 'paused_system' + PAUSED_USER = 'paused_user' + RESUMING = 'resuming' + TRANSFERRING = 'transferring' + UNKNOWN = 'unknown' + + def __init__(self, imag...

v1 was here: https://www.redhat.com/archives/libguestfs/2018-September/msg00121.html v2: - Rewrote patch 2 from scratch so it incorporates Nir's suggestions. - Add fake module to EXTRA_DIST. - Retested. Unfortunately I am no longer able to test the ordinary conversion path because ovirtsdk4 is incompatible with Fedora 29 / Python 3.7:

..., no? If the disk status is LOCKED, we should continue. But in this case there is no point to check the transfer again. What if the finalize failed, and the disk was deleted? Do we get disk = None or some exception? > + > + if transfer.phase == > types.ImageTransferPhase.FINISHED_SUCCESS: > + debug("finalized after %s seconds", time.time() - > start) > + break > + > + if transfer.phase == > types.ImageTransferPhase.FINALIZING_SUCCESS: > + if time.time() > start + timeout: >...

This adds a test of -o rhv-upload. Obviously for an upstream test we cannot require a working oVirt server. This test works by faking the ovirtsdk4 Python module, setting PYTHONPATH so that the fake module is picked up instead of the real module (if installed). However it's more complex than that because the nbdkit plugin also expects to talk to a working imageio HTTPS server. Therefore

...status = DiskStatus.OK > + > +class ImageTransferPhase(Enum): > + CANCELLED = 'cancelled' > + FINALIZING_FAILURE = 'finalizing_failure' > + FINALIZING_SUCCESS = 'finalizing_success' > + FINISHED_FAILURE = 'finished_failure' > + FINISHED_SUCCESS = 'finished_success' > + INITIALIZING = 'initializing' > + PAUSED_SYSTEM = 'paused_system' > + PAUSED_USER = 'paused_user' > + RESUMING = 'resuming' > + TRANSFERRING = 'transferring' > + UNKNOWN = 'unknown'...

...types.DiskStatus.LOCKED: continue > > What if the finalize failed, and the disk was deleted? Do we get disk = None > or some exception? sdk.NotFoundError exception should be thrown. > >> >> + >> + if transfer.phase == types.ImageTransferPhase.FINISHED_SUCCESS: >> + debug("finalized after %s seconds", time.time() - start) >> + break >> + >> + if transfer.phase == >> types.ImageTransferPhase.FINALIZING_SUCCESS: >> + if time.time() > sta...

Fix NameError introduced by inocomplete change to extract create_transfer() by extracting cancel_transfer() function. Finally extract finallize_transfer() function, dealing with the poorly documented and over complicated oVirt SDK. Tested with: libguestfs-1.40.2-4.fc30.x86_64 nbdkit-1.12.8-1.fc30.x86_64 Tested flows: - Successful import - Error in close() - by injecting long sleep in vdsm